From fe9fcf67ac7359201c42528f21e419a3e821ec7b Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Fri, 4 Apr 2025 15:37:20 +0800 Subject: [PATCH] cmake: Fix googletest deprecated warnings by using target_compile_options() Previously, we attempted to disable deprecated declarations warnings when building gtest by adding `-Wno-deprecated-declarations` to the COMPILE_OPTIONS property of the googletest directory. However, this approach failed to apply the option when actually building gtest. This change applies the compile option directly to the `gtest` target using target_compile_options() instead. Verified by forcing the condition to TRUE and confirming the option is included when building `gtest-all.cc` through `cmake --build ~/dev/ceph/build --target gtest --verbose`. Signed-off-by: Kefu Chai --- src/CMakeLists.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 23b9442bd28af..801086e1268a1 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -777,9 +777,8 @@ if(WITH_TESTS) $) if(NOT COMPILER_IGNORES_DEPRECATED_DECL_IN_SYSTEM_HEADERS) # See https://github.com/llvm/llvm-project/issues/76515 - set_property(DIRECTORY googletest - APPEND - PROPERTY COMPILE_OPTIONS "-Wno-deprecated-declarations") + target_compile_options(gtest + PRIVATE "-Wno-deprecated-declarations") endif() add_library(GTest::GTest ALIAS gtest) add_library(GTest::Main ALIAS gtest_main) -- 2.39.5