From 358fa0532b3441dd9e59ab4752c22fbcb2e6efb0 Mon Sep 17 00:00:00 2001 From: Aashish Sharma Date: Thu, 10 Apr 2025 11:59:36 +0530 Subject: [PATCH] mgr/dashboard: add description for default Pool Application select options Add a description for the default pool application values in the pool creation form i.e cephfs <-> FileSystem, rbd <-> Block, rgw <-> Object. Fixes: https://tracker.ceph.com/issues/70866 Signed-off-by: Aashish Sharma --- .../src/app/ceph/pool/pool-form/pool-form-data.ts | 8 +++++++- .../src/app/ceph/pool/pool-form/pool-form.component.ts | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form-data.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form-data.ts index 2c5dc57eb5b3..4e7dd8b80925 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form-data.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form-data.ts @@ -9,6 +9,12 @@ export class PoolFormData { crushInfo = false; applications: any; + readonly APP_LABELS: Record = { + cephfs: 'Filesystem', + rbd: 'Block', + rgw: 'Object' + }; + constructor() { this.poolTypes = ['erasure', 'replicated']; this.applications = { @@ -26,7 +32,7 @@ export class PoolFormData { pattern: $localize`Allowed characters '_a-zA-Z0-9'`, maxlength: $localize`Maximum length is 128 characters` }, - filter: $localize`Filter or add applications'`, + filter: $localize`Filter or add applications`, add: $localize`Add application` }) }; diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.ts index b7cda346e984..b68d52dfdced 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.ts @@ -301,7 +301,7 @@ export class PoolFormComponent extends CdForm implements OnInit { private setAvailableApps(apps: string[] = this.data.applications.default) { this.data.applications.available = _.uniq(apps.sort()).map( - (x: string) => new SelectOption(false, x, '') + (x: string) => new SelectOption(false, x, this.data.APP_LABELS[x] || x) ); } -- 2.47.3