From c2895805f026cd907a667a39dfc189340fac79a8 Mon Sep 17 00:00:00 2001 From: Jon Date: Mon, 23 Jun 2025 17:18:25 +0100 Subject: [PATCH] Fix issue where ceph_test_rados_io_sequence could select a chunksize of 0 which is not valid. Fixes an off by one error where we were selecting a chunk size from the range of 0-(X-1) inclusive instead of from a range of 0-X inclusive Signed-off-by: Jon Bailey --- .../ceph_test_rados_io_sequence.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/osd/ceph_test_rados_io_sequence/ceph_test_rados_io_sequence.cc b/src/test/osd/ceph_test_rados_io_sequence/ceph_test_rados_io_sequence.cc index 396ec815afa..1149fab4ec4 100644 --- a/src/test/osd/ceph_test_rados_io_sequence/ceph_test_rados_io_sequence.cc +++ b/src/test/osd/ceph_test_rados_io_sequence/ceph_test_rados_io_sequence.cc @@ -537,19 +537,19 @@ ceph::io_sequence::tester::SelectErasureChunkSize::generate_selections() { if (4096 % minimum_chunksize == 0) { choices.push_back(4096); } else { - choices.push_back(minimum_chunksize * rng(4)); + choices.push_back(minimum_chunksize * (rng(4) + 1)); } if ((64 * 1024) % minimum_chunksize == 0) { choices.push_back(64 * 1024); } else { - choices.push_back(minimum_chunksize * rng(64)); + choices.push_back(minimum_chunksize * (rng(64) + 1)); } if ((256 * 1024) % minimum_chunksize == 0) { choices.push_back(256 * 1024); } else { - choices.push_back(minimum_chunksize * rng(256)); + choices.push_back(minimum_chunksize * (rng(256) + 1)); } return choices; -- 2.47.3