From 0c89509e1bbd5256584ea98778e07854b7e02437 Mon Sep 17 00:00:00 2001
From: Xuehan Xu <xuxuehan@qianxin.com>
Date: Tue, 1 Jul 2025 17:06:16 +0800
Subject: [PATCH] crimson/osd: put PGBackend/RecoveryBackend/PGRecovery and
 other related classes into the crimson::osd  namespace

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
---
 src/crimson/osd/ec_backend.cc                  | 4 ++++
 src/crimson/osd/ec_backend.h                   | 4 ++++
 src/crimson/osd/pg.h                           | 6 +++---
 src/crimson/osd/pg_backend.cc                  | 3 +++
 src/crimson/osd/pg_backend.h                   | 9 +++++----
 src/crimson/osd/pg_recovery.cc                 | 5 ++++-
 src/crimson/osd/pg_recovery.h                  | 7 ++++---
 src/crimson/osd/pg_recovery_listener.h         | 8 ++++----
 src/crimson/osd/recovery_backend.cc            | 4 ++++
 src/crimson/osd/recovery_backend.h             | 7 ++++---
 src/crimson/osd/replicated_backend.cc          | 4 ++++
 src/crimson/osd/replicated_backend.h           | 7 ++++---
 src/crimson/osd/replicated_recovery_backend.cc | 4 ++++
 src/crimson/osd/replicated_recovery_backend.h  | 4 ++++
 14 files changed, 55 insertions(+), 21 deletions(-)

diff --git a/src/crimson/osd/ec_backend.cc b/src/crimson/osd/ec_backend.cc
index 8325affa859c..85bcb51e786a 100644
--- a/src/crimson/osd/ec_backend.cc
+++ b/src/crimson/osd/ec_backend.cc
@@ -2,6 +2,8 @@
 
 #include "crimson/osd/shard_services.h"
 
+namespace crimson::osd {
+
 ECBackend::ECBackend(shard_id_t shard,
                      ECBackend::CollectionRef coll,
                      crimson::osd::ShardServices& shard_services,
@@ -35,3 +37,5 @@ ECBackend::submit_transaction(const std::set<pg_shard_t> &pg_shards,
   // todo
   return make_ready_future<rep_op_ret_t>(seastar::now(), seastar::now());
 }
+
+}
diff --git a/src/crimson/osd/ec_backend.h b/src/crimson/osd/ec_backend.h
index b14c78c9fc4a..b28f7581bec8 100644
--- a/src/crimson/osd/ec_backend.h
+++ b/src/crimson/osd/ec_backend.h
@@ -9,6 +9,8 @@
 #include "osd/osd_types.h"
 #include "pg_backend.h"
 
+namespace crimson::osd {
+
 class ECBackend : public PGBackend
 {
 public:
@@ -39,3 +41,5 @@ private:
     return seastar::now();
   }
 };
+
+}
diff --git a/src/crimson/osd/pg.h b/src/crimson/osd/pg.h
index 643b9ce58dd3..74d431a453d4 100644
--- a/src/crimson/osd/pg.h
+++ b/src/crimson/osd/pg.h
@@ -47,8 +47,6 @@
 
 class MQuery;
 class OSDMap;
-class PGBackend;
-class ReplicatedBackend;
 class PGPeeringEvent;
 class osd_op_params_t;
 
@@ -68,6 +66,8 @@ namespace crimson::osd {
 class OpsExecuter;
 class SnapTrimEvent;
 class PglogBasedRecovery;
+class PGBackend;
+class ReplicatedBackend;
 
 class PG : public boost::intrusive_ref_counter<
   PG,
@@ -1014,7 +1014,7 @@ private:
 
 private:
   friend class IOInterruptCondition;
-  friend class ::ReplicatedBackend;
+  friend class ReplicatedBackend;
   struct log_update_t {
     std::set<pg_shard_t> waiting_on;
     seastar::shared_promise<> all_committed;
diff --git a/src/crimson/osd/pg_backend.cc b/src/crimson/osd/pg_backend.cc
index 42f5f8242021..b794d349491b 100644
--- a/src/crimson/osd/pg_backend.cc
+++ b/src/crimson/osd/pg_backend.cc
@@ -43,6 +43,8 @@ using std::string;
 using std::string_view;
 using crimson::common::local_conf;
 
+namespace crimson::osd {
+
 std::unique_ptr<PGBackend>
 PGBackend::create(pg_t pgid,
 		  const pg_shard_t pg_shard,
@@ -1854,3 +1856,4 @@ void PGBackend::clone_for_write(
   txn.rmattr(coll->get_cid(), ghobject_t{to}, SS_ATTR);
 }
 
+}
diff --git a/src/crimson/osd/pg_backend.h b/src/crimson/osd/pg_backend.h
index 07e4aa8ae567..3402d31ff4ae 100644
--- a/src/crimson/osd/pg_backend.h
+++ b/src/crimson/osd/pg_backend.h
@@ -29,10 +29,9 @@ namespace ceph::os {
 }
 
 namespace crimson::osd {
-  class ShardServices;
-  class PG;
-  class ObjectContextLoader;
-}
+class ShardServices;
+class PG;
+class ObjectContextLoader;
 
 class PGBackend
 {
@@ -517,3 +516,5 @@ private:
 
   friend class RecoveryBackend;
 };
+
+}
diff --git a/src/crimson/osd/pg_recovery.cc b/src/crimson/osd/pg_recovery.cc
index 51f9faf18577..b9b67b4881f0 100644
--- a/src/crimson/osd/pg_recovery.cc
+++ b/src/crimson/osd/pg_recovery.cc
@@ -22,7 +22,8 @@ SET_SUBSYS(osd);
 
 using std::map;
 using std::set;
-using PglogBasedRecovery = crimson::osd::PglogBasedRecovery;
+
+namespace crimson::osd {
 
 void PGRecovery::start_pglogbased_recovery()
 {
@@ -711,3 +712,5 @@ void PGRecovery::on_backfill_reserved()
   backfill_state->process_event(
     BackfillState::Triggered{}.intrusive_from_this());
 }
+
+}
diff --git a/src/crimson/osd/pg_recovery.h b/src/crimson/osd/pg_recovery.h
index f85709c501d0..7cb476e802f0 100644
--- a/src/crimson/osd/pg_recovery.h
+++ b/src/crimson/osd/pg_recovery.h
@@ -15,12 +15,11 @@
 
 #include "osd/object_state.h"
 
+class MOSDPGBackfillRemove;
+
 namespace crimson::osd {
 class UrgentRecovery;
 class PglogBasedRecovery;
-}
-
-class MOSDPGBackfillRemove;
 class PGBackend;
 
 class PGRecovery : public crimson::osd::BackfillState::BackfillListener {
@@ -148,3 +147,5 @@ private:
   friend crimson::osd::PG;
   // backfill end
 };
+
+}
diff --git a/src/crimson/osd/pg_recovery_listener.h b/src/crimson/osd/pg_recovery_listener.h
index ab50b99a639f..a6f7f00f965e 100644
--- a/src/crimson/osd/pg_recovery_listener.h
+++ b/src/crimson/osd/pg_recovery_listener.h
@@ -10,10 +10,8 @@
 #include "osd/osd_types.h"
 
 namespace crimson::osd {
-  class ShardServices;
-  class PglogBasedRecovery;
-};
-
+class ShardServices;
+class PglogBasedRecovery;
 class RecoveryBackend;
 class PGRecovery;
 
@@ -45,3 +43,5 @@ public:
   virtual void reset_pglog_based_recovery_op() = 0;
   virtual void schedule_event_after(PGPeeringEventRef evt, float delay) = 0;
 };
+
+}
diff --git a/src/crimson/osd/recovery_backend.cc b/src/crimson/osd/recovery_backend.cc
index 5c25409a80a4..97be44536e81 100644
--- a/src/crimson/osd/recovery_backend.cc
+++ b/src/crimson/osd/recovery_backend.cc
@@ -16,6 +16,8 @@
 
 SET_SUBSYS(osd);
 
+namespace crimson::osd {
+
 hobject_t RecoveryBackend::get_temp_recovery_object(
   const hobject_t& target,
   eversion_t version) const
@@ -459,3 +461,5 @@ RecoveryBackend::handle_backfill_op(
 					  (uint16_t)m->get_header().type)));
   }
 }
+
+}
diff --git a/src/crimson/osd/recovery_backend.h b/src/crimson/osd/recovery_backend.h
index 6198cb11787c..699b31a0e006 100644
--- a/src/crimson/osd/recovery_backend.h
+++ b/src/crimson/osd/recovery_backend.h
@@ -19,9 +19,8 @@
 #include "osd/recovery_types.h"
 #include "osd/osd_types.h"
 
-namespace crimson::osd{
-  class PG;
-}
+namespace crimson::osd {
+class PG;
 
 class RecoveryBackend {
 public:
@@ -306,3 +305,5 @@ private:
     crimson::net::ConnectionXcoreRef conn);
   interruptible_future<> handle_backfill_remove(MOSDPGBackfillRemove& m);
 };
+
+}
diff --git a/src/crimson/osd/replicated_backend.cc b/src/crimson/osd/replicated_backend.cc
index a62ebaae3dd0..e0cf611f9be5 100644
--- a/src/crimson/osd/replicated_backend.cc
+++ b/src/crimson/osd/replicated_backend.cc
@@ -15,6 +15,8 @@
 
 SET_SUBSYS(osd);
 
+namespace crimson::osd {
+
 ReplicatedBackend::ReplicatedBackend(pg_t pgid,
                                      pg_shard_t whoami,
 				     crimson::osd::PG& pg,
@@ -355,3 +357,5 @@ void ReplicatedBackend::do_pct(const MOSDPGPCT &m)
   DEBUGDPP("{}", dpp, m);
   pg.peering_state.update_pct(m.pg_committed_to);
 }
+
+}
diff --git a/src/crimson/osd/replicated_backend.h b/src/crimson/osd/replicated_backend.h
index 43030bd0609d..ebaf665b7672 100644
--- a/src/crimson/osd/replicated_backend.h
+++ b/src/crimson/osd/replicated_backend.h
@@ -14,9 +14,8 @@
 #include "pg_backend.h"
 
 namespace crimson::osd {
-  class ShardServices;
-  class PG;
-}
+class ShardServices;
+class PG;
 
 class ReplicatedBackend : public PGBackend
 {
@@ -104,3 +103,5 @@ public:
   /// Handle MOSDPGPCT message
   void do_pct(const MOSDPGPCT &m);
 };
+
+}
diff --git a/src/crimson/osd/replicated_recovery_backend.cc b/src/crimson/osd/replicated_recovery_backend.cc
index 71a1deef575b..1d280a7e3a7d 100644
--- a/src/crimson/osd/replicated_recovery_backend.cc
+++ b/src/crimson/osd/replicated_recovery_backend.cc
@@ -19,6 +19,8 @@ using std::less;
 using std::map;
 using std::string;
 
+namespace crimson::osd {
+
 RecoveryBackend::interruptible_future<>
 ReplicatedRecoveryBackend::recover_object(
   const hobject_t& soid,
@@ -1379,3 +1381,5 @@ ReplicatedRecoveryBackend::get_md_from_push_op(PushOp &push_op)
   }
   return std::make_pair(std::move(oi), std::move(ssc));
 }
+
+}
diff --git a/src/crimson/osd/replicated_recovery_backend.h b/src/crimson/osd/replicated_recovery_backend.h
index b46a99b3d3b2..5d80cd9d44ab 100644
--- a/src/crimson/osd/replicated_recovery_backend.h
+++ b/src/crimson/osd/replicated_recovery_backend.h
@@ -15,6 +15,8 @@
 #include "messages/MOSDPGRecoveryDeleteReply.h"
 #include "os/ObjectStore.h"
 
+namespace crimson::osd {
+
 class ReplicatedRecoveryBackend : public RecoveryBackend {
 public:
   ReplicatedRecoveryBackend(crimson::osd::PG& pg,
@@ -179,3 +181,5 @@ private:
   std::pair<object_info_t, crimson::osd::SnapSetContextRef>
   get_md_from_push_op(PushOp &push_op);
 };
+
+}
-- 
2.47.3