From 5382bf2908ae9c484a6aa3afdd9a2401cfd2e48f Mon Sep 17 00:00:00 2001 From: Naveen Naidu Date: Wed, 2 Jul 2025 10:22:02 +0530 Subject: [PATCH] .github/workflows/scripts/config-diff-post-comment.js: fix config check ok logic currently, whenever a "config diff tool output" comment is created it also has the string `/config check ok` string in it. The next time the test run it see's this text and assumes that the user has commented it. We fix the logic to makes sure that we ignore such cases. Signed-off-by: Naveen Naidu --- .github/workflows/scripts/config-diff-post-comment.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/scripts/config-diff-post-comment.js b/.github/workflows/scripts/config-diff-post-comment.js index 5e99bf8ae1650..3326f27cb7b98 100644 --- a/.github/workflows/scripts/config-diff-post-comment.js +++ b/.github/workflows/scripts/config-diff-post-comment.js @@ -14,7 +14,9 @@ module.exports = async ({ github, context, core, configDiff }) => { ); // Check if any comment contains `/config check ok` - const configCheckOkComment = comments.find(comment => comment.body.includes("/config check ok")); + const configCheckOkComment = comments.find( + comment => comment.body.includes("/config check ok") && !comment.body.includes("### Config Diff Tool Output") + ); if (configCheckOkComment) { core.info("Found '/config check ok' comment. Returning with success."); return; -- 2.39.5