From e1366bfffde8fe1ae46ce89279c5877cf9384eee Mon Sep 17 00:00:00 2001
From: Afreen Misbah <afreen@ibm.com>
Date: Tue, 29 Jul 2025 23:31:15 +0530
Subject: [PATCH] mgr/dasboard: fix pool e2e

- added data-testid for mirroring checkbox

Signed-off-by: Afreen Misbah <afreen@ibm.com>
---
 .../mgr/dashboard/frontend/cypress/e2e/pools/pools.po.ts      | 4 ++--
 .../src/app/ceph/pool/pool-form/pool-form.component.html      | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/pybind/mgr/dashboard/frontend/cypress/e2e/pools/pools.po.ts b/src/pybind/mgr/dashboard/frontend/cypress/e2e/pools/pools.po.ts
index 63e3f4a3f9f0c..25767fd97d6f6 100644
--- a/src/pybind/mgr/dashboard/frontend/cypress/e2e/pools/pools.po.ts
+++ b/src/pybind/mgr/dashboard/frontend/cypress/e2e/pools/pools.po.ts
@@ -26,7 +26,7 @@ export class PoolPageHelper extends PageHelper {
     cy.get('[data-testid="pgNum"]').clear().type(`${placement_groups}`);
     this.setApplications(apps);
     if (mirroring) {
-      cy.get('#rbdMirroring').check({ force: true });
+      cy.get('[data-testid="rbd-mirroring-check"]').check({ force: true });
     }
     cy.get('cd-submit-button').click();
   }
@@ -36,7 +36,7 @@ export class PoolPageHelper extends PageHelper {
     this.navigateEdit(name);
 
     if (mirroring) {
-      cy.get('#rbdMirroring').should('be.checked');
+      cy.get('[data-testid="rbd-mirroring-check"]').should('be.checked');
     }
 
     cy.get('[data-testid="pgNum"]').clear().type(`${new_pg}`);
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.html
index f68895512ab4d..a8402259aaa27 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.html
@@ -203,6 +203,7 @@
             <div class="custom-control custom-checkbox">
               <input class="custom-control-input"
                      id="rbdMirroring"
+                     data-testid="rbd-mirroring-check"
                      type="checkbox"
                      formControlName="rbdMirroring">
               <label class="custom-control-label"
-- 
2.39.5