From 8d1033ee089aae014808b5b4c00c1817ba68b773 Mon Sep 17 00:00:00 2001 From: Edwin Rodriguez Date: Wed, 8 Oct 2025 12:20:36 -0400 Subject: [PATCH] mds: Remove unnecessary std::move on const expression in MetricsHandler::handle_payload Fixes: https://tracker.ceph.com/issues/73430 Signed-off-by: Edwin Rodriguez --- src/mds/MetricsHandler.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mds/MetricsHandler.cc b/src/mds/MetricsHandler.cc index a67e90134a9..23811a42a75 100644 --- a/src/mds/MetricsHandler.cc +++ b/src/mds/MetricsHandler.cc @@ -368,7 +368,9 @@ std::chrono::steady_clock::now().time_since_epoch()).count()); auto& vec = subvolume_metrics_map[path]; dout(20) << " accumulating subv_metric " << payload.subvolume_metrics[i] << dendl; - vec.emplace_back(std::move(payload.subvolume_metrics[i])); + // std::move of the const expression of the trivially-copyable type 'const value_type' + // (aka 'const AggregatedIOMetrics') has no effect; remove std::move() + vec.emplace_back(payload.subvolume_metrics[i]); vec.back().time_stamp = now_ms; } } -- 2.47.3