From 9ad0fd3f1a5f3aa9d751abd21bd57b8a5ba93f4a Mon Sep 17 00:00:00 2001 From: John Mulligan Date: Fri, 13 Mar 2026 13:42:09 -0400 Subject: [PATCH] script/build-with-container: add CONFIGURE_ARGS env var to configure step Add a new optional CONFIGURE_ARGS environment variable to the configure step so that there's a mechanism to pass custom cmake options that aren't handled elsewhere in the run-make.sh script. Because configure is a rather fundamental build step it's probably preferable to set this via an env file so that it persists across rebuilds. Using an environment var here also avoids both needing to change run-make.sh or add another CLI option to BWC which already has too many. Signed-off-by: John Mulligan --- src/script/build-with-container.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/script/build-with-container.py b/src/script/build-with-container.py index c9fc99fe3429..1c23ce71d471 100755 --- a/src/script/build-with-container.py +++ b/src/script/build-with-container.py @@ -813,7 +813,11 @@ def get_container(ctx): @Builder.set(Steps.CONFIGURE) def bc_configure(ctx): - """Configure the build""" + """Configure the build. + + Use the environment variable CONFIGURE_ARGS to pass custom arguments + for cmake configuration if needed. + """ ctx.build.wants(Steps.CONTAINER, ctx) ctx.build.wants(Steps.NPM_CACHE, ctx) cmd = _container_cmd( @@ -821,7 +825,7 @@ def bc_configure(ctx): [ "bash", "-c", - f"cd {ctx.cli.homedir} && source ./src/script/run-make.sh && has_build_dir || configure", + f"cd {ctx.cli.homedir} && source ./src/script/run-make.sh && has_build_dir || configure ${{CONFIGURE_ARGS}}", ], ) with ctx.user_command(): -- 2.47.3