From a1a66fa5bc45cb3ed8496e0313cde182dfdd0d47 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sun, 29 Mar 2026 19:41:08 +0800 Subject: [PATCH] crimson/osd: fix wrong log arguments in get_option_value and _get_early_config Both log calls referenced option.config_key (the ceph config key name) where option.option_name (the CLI flag) was intended: logger().warn("get_option_value --option_name {} ...", option.config_key); logger().info("Configure option_name {} with value : {}", option.config_key, ...); Fix both to log option.option_name. Also remove the trailing space before the colon in the info format string. Signed-off-by: Kefu Chai --- src/crimson/osd/main_config_bootstrap_helpers.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/crimson/osd/main_config_bootstrap_helpers.cc b/src/crimson/osd/main_config_bootstrap_helpers.cc index 07e9910dee04..12442eaf4d53 100644 --- a/src/crimson/osd/main_config_bootstrap_helpers.cc +++ b/src/crimson/osd/main_config_bootstrap_helpers.cc @@ -129,7 +129,7 @@ std::optional get_option_value(const SeastarOption& option) { break; } default: - logger().warn("get_option_value --option_name {} encountered unknown type", option.config_key); + logger().warn("get_option_value: {} has unknown type", option.option_name); return std::nullopt; } return std::nullopt; @@ -197,7 +197,7 @@ _get_early_config(int argc, const char *argv[]) for (const auto& option : seastar_options) { auto option_value = get_option_value(option); if (option_value) { - logger().info("Configure option_name {} with value : {}", option.config_key, option_value); + logger().info("configure {} with value: {}", option.option_name, option_value); ret.early_args.emplace_back(option.option_name); if (option.value_type != Option::TYPE_BOOL) { ret.early_args.emplace_back(*option_value); -- 2.47.3