From a519613c404cf54cddb86c4f366ef22dc7bcae87 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sun, 29 Mar 2026 19:41:24 +0800 Subject: [PATCH] crimson/osd: fix inaccurate comment about child early-exit in get_early_config The comment contained a typo ("taged") and vaguely referred to "one of the parameters" without explaining what actually happens: the child calls exit(0) for early-exit paths such as --help and --version, and the parent detects this by checking for a clean exit with no pipe data. Signed-off-by: Kefu Chai --- src/crimson/osd/main_config_bootstrap_helpers.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/crimson/osd/main_config_bootstrap_helpers.cc b/src/crimson/osd/main_config_bootstrap_helpers.cc index 3454b5dbc394..aafd52964a11 100644 --- a/src/crimson/osd/main_config_bootstrap_helpers.cc +++ b/src/crimson/osd/main_config_bootstrap_helpers.cc @@ -337,8 +337,7 @@ get_early_config(int argc, const char *argv[]) int status; waitpid(worker, &status, 0); - // One of the parameters was taged as exit(0) in the child process - // so we need to check if we should exit here + // child exited via exit(0) for early-exit paths (e.g. --help, --version) if (!have_data && WIFEXITED(status) && WEXITSTATUS(status) == 0) { exit(0); } -- 2.47.3