From e61684de67feb8abb241aaf1d6f5605833ad064d Mon Sep 17 00:00:00 2001 From: Sagar Gopale Date: Wed, 15 Apr 2026 11:25:12 +0530 Subject: [PATCH] mgr/dashboard: fix namespace block size in namespace form Fixes: https://tracker.ceph.com/issues/76034 Signed-off-by: Sagar Gopale --- .../nvmeof-namespaces-form.component.spec.ts | 6 +++--- .../nvmeof-namespaces-form.component.ts | 6 ++++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.spec.ts index dd4c35eaa6cf..b2868bc43e4a 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.spec.ts @@ -137,16 +137,16 @@ describe('NvmeofNamespacesFormComponent', () => { expect(nvmeofService.createNamespace).toHaveBeenCalled(); }); - it('should not send block_size from namespace_size UI field', () => { + it('should send block_size from namespace_size UI field', () => { formHelper.setValue('pool', 'rbd'); formHelper.setValue('image_size', new FormatterService().toBytes('1GiB')); formHelper.setValue('subsystem', MOCK_SUBSYSTEM); - formHelper.setValue('namespace_size', 10); + formHelper.setValue('namespace_size', 1024); component.onSubmit(); const request = (nvmeofService.createNamespace as jasmine.Spy).calls.mostRecent().args[1]; - expect(request.block_size).toBeUndefined(); + expect(request.block_size).toBe(1024); }); }); }); diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.ts index f3488cb68adc..a33a06d73b85 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.ts @@ -330,6 +330,8 @@ export class NvmeofNamespacesFormComponent implements OnInit { const loopCount = isGatewayProvisioned ? nsCount : 1; + const blockSize = this.nsForm.getValue('namespace_size'); + for (let i = 1; i <= loopCount; i++) { const request: NamespaceCreateRequest = { gw_group: this.group, @@ -338,6 +340,10 @@ export class NvmeofNamespacesFormComponent implements OnInit { no_auto_visible: noAutoVisible }; + if (blockSize) { + request.block_size = blockSize; + } + if (isGatewayProvisioned) { const rbdImageName = this.nsForm.getValue('rbd_image_name'); if (rbdImageName) { -- 2.47.3