From 38412a464fe1bb313a954ccf909f447f0db538c0 Mon Sep 17 00:00:00 2001 From: Afreen Misbah Date: Thu, 23 Apr 2026 18:53:25 +0530 Subject: [PATCH] Fix unit test Signed-off-by: Afreen Misbah --- .../service-form/service-form.component.spec.ts | 2 +- .../src/app/shared/api/nvmeof.service.spec.ts | 16 ---------------- .../src/app/shared/api/nvmeof.service.ts | 4 +++- 3 files changed, 4 insertions(+), 18 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.spec.ts index 7db7faa1543e..bfd6cd4a627e 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.spec.ts @@ -109,7 +109,7 @@ describe('ServiceFormComponent', () => { // placement labels take only single value formHelper.setValue('service_type', 'mgr'); formHelper.setValue('placement', 'label'); - formHelper.setValue('label', "{content: 'foo', selected: true}"); + formHelper.setValue('label', { content: 'foo', selected: true }); component.onSubmit(); diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.spec.ts index 70c3da05eb4a..417197d0666b 100755 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.spec.ts @@ -340,22 +340,6 @@ describe('NvmeofService', () => { req.flush(mockGroups); }); - it('should filter hosts by array label placement', (done) => { - const mockGroups = [ - [{ spec: { group: 'default' }, placement: { hosts: [], label: ['nvmeof', 'storage'] } }] - ]; - mockHostService.getAllHosts.mockReturnValue(of(allHosts)); - - service.getHostsForGroup('default').subscribe((hosts: any[]) => { - expect(hosts.length).toBe(1); - expect(hosts[0].hostname).toBe('host3'); - done(); - }); - - const req = httpTesting.expectOne(`${API_PATH}/gateway/group`); - req.flush(mockGroups); - }); - it('should return empty array when group not found', (done) => { const mockGroups = [ [{ spec: { group: 'other' }, placement: { hosts: ['host1'], label: [] } }] diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.ts index 85fde2ce9302..3b2b57dbf35e 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.ts @@ -210,7 +210,9 @@ export class NvmeofService { return this.getSubsystem(subsystemNqn, group).pipe( mapTo(true), catchError((e) => { - e?.preventDefault(); + if (_.isFunction(e?.preventDefault)) { + e.preventDefault(); + } return observableOf(false); }) ); -- 2.47.3