From ab4b3732b1fbf07894aeacc928ac12eb19d819c1 Mon Sep 17 00:00:00 2001 From: Mykola Golub Date: Sun, 24 Jan 2016 12:26:36 +0200 Subject: [PATCH] journal: flush commit position on metadata shutdown A crash was observed on JournalTrimmer destroy, which was called by the Journaler after metadata shutdown. JournalTrimmer destructor also calls flush_commit_position, but at that time metadata m_timer is already null and it crushed there. Signed-off-by: Mykola Golub --- src/journal/JournalMetadata.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/journal/JournalMetadata.cc b/src/journal/JournalMetadata.cc index 0cd935f2f2e0..e4833a1dc4d6 100644 --- a/src/journal/JournalMetadata.cc +++ b/src/journal/JournalMetadata.cc @@ -74,6 +74,8 @@ void JournalMetadata::shutdown() { } } + flush_commit_position(); + if (m_timer != NULL) { Mutex::Locker locker(m_timer_lock); m_timer->shutdown(); -- 2.47.3