From 083a0064a359ccca6f08fa9a9dc134d607244cae Mon Sep 17 00:00:00 2001 From: xiexingguo Date: Fri, 26 Feb 2016 19:35:55 +0800 Subject: [PATCH] osd: update sprintf() to snprintf() Which is safer. Also enlarge length of name to 32, which shall be big enough to hold a int64_t value. Signed-off-by: xie xingguo --- src/osd/OSDMap.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/osd/OSDMap.cc b/src/osd/OSDMap.cc index 9a01c1b2197..855d33075e9 100644 --- a/src/osd/OSDMap.cc +++ b/src/osd/OSDMap.cc @@ -2771,8 +2771,8 @@ int OSDMap::build_simple_crush_map(CephContext *cct, CrushWrapper& crush, loc["rack"] = "localrack"; loc["root"] = "default"; ldout(cct, 10) << " adding osd." << o << " at " << loc << dendl; - char name[8]; - sprintf(name, "osd.%d", o); + char name[32]; + snprintf(name, sizeof(name), "osd.%d", o); crush.insert_item(cct, o, 1.0, name, loc); } -- 2.47.3