From 3cfdef7f52416fbe68f37ad7f37f39c55d7901ad Mon Sep 17 00:00:00 2001 From: Zack Cerza Date: Thu, 25 Feb 2016 17:59:51 -0700 Subject: [PATCH] Add a warning when gitbuilder 404s When determining the ceph hash, we usually ask gitbuilder. When that fails, the error is misleading but it would take a bit of refactoring to truly fix it. Let's at least put a useful warning before the confusing error message. Signed-off-by: Zack Cerza --- teuthology/suite.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/teuthology/suite.py b/teuthology/suite.py index 66d17979e..87d924687 100644 --- a/teuthology/suite.py +++ b/teuthology/suite.py @@ -446,6 +446,16 @@ def get_hash(project='ceph', branch='master', flavor='basic', log.debug("Gitbuilder URL: %s", url) resp = requests.get(url) if not resp.ok: + msg = "Got a {0} trying to get hash for project '{1}' " + \ + "and branch '{2}' from URL: {3}" + log.warn( + msg.format( + resp.status_code, + project, + branch, + url + ) + ) return None return str(resp.text.strip()) -- 2.47.3