From e92b3950cd261d36de422ccaa4a2441d41c80d0c Mon Sep 17 00:00:00 2001
From: Mykola Golub <mgolub@mirantis.com>
Date: Mon, 27 Jun 2016 14:45:02 +0300
Subject: [PATCH] librbd: potential use after free on refresh error

Signed-off-by: Mykola Golub <mgolub@mirantis.com>
---
 src/librbd/AioImageRequestWQ.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/librbd/AioImageRequestWQ.cc b/src/librbd/AioImageRequestWQ.cc
index eb5d83096742..725e96a8770d 100644
--- a/src/librbd/AioImageRequestWQ.cc
+++ b/src/librbd/AioImageRequestWQ.cc
@@ -457,9 +457,8 @@ void AioImageRequestWQ::handle_refreshed(int r, AioImageRequest<> *req) {
                  << "req=" << req << dendl;
   if (r < 0) {
     req->fail(r);
-    delete req;
-
     finish_queued_op(req);
+    delete req;
     finish_in_flight_op();
   } else {
     // since IO was stalled for refresh -- original IO order is preserved
-- 
2.47.3