From 256eb4cd27a1389a93b0e743d0ae65f69f7417a5 Mon Sep 17 00:00:00 2001 From: Yuval Lifshitz Date: Thu, 13 Nov 2025 20:24:18 +0000 Subject: [PATCH] rgw/logging: do not create empty temporary objects Fixes: https://tracker.ceph.com/issues/73845 Signed-off-by: Yuval Lifshitz --- src/rgw/driver/rados/rgw_sal_rados.cc | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/src/rgw/driver/rados/rgw_sal_rados.cc b/src/rgw/driver/rados/rgw_sal_rados.cc index 0a89c943663a0..308cd181eb5fe 100644 --- a/src/rgw/driver/rados/rgw_sal_rados.cc +++ b/src/rgw/driver/rados/rgw_sal_rados.cc @@ -1313,23 +1313,8 @@ int RadosBucket::commit_logging_object(const std::string& obj_name, << ". error: " << ret << dendl; return ret; } + mtime = ceph::real_time::clock::now(); ldpp_dout(dpp, 20) << "INFO: temporary logging object '" << temp_obj_name << "' does not exist. committing it empty" << dendl; - // creating an empty object - if (ret = rgw_put_system_obj(dpp, store->svc()->sysobj, - data_pool, - temp_obj_name, - bl_data, // empty bufferlist - true, // exclusive - nullptr, - ceph::real_time::clock::now(), - y); ret < 0) { - if (ret == -EEXIST) { - ldpp_dout(dpp, 5) << "WARNING: race detected in committing an empty logging object '" << temp_obj_name << dendl; - } else { - ldpp_dout(dpp, 1) << "ERROR: failed to commit empty logging object '" << temp_obj_name << "'. error: " << ret << dendl; - } - return ret; - } } uint64_t size = bl_data.length(); -- 2.39.5