From b4446f20a34b0bc978f176a59e5f3c59ec58374d Mon Sep 17 00:00:00 2001
From: Anushruti Sharma <anushruti10116@gmail.com>
Date: Mon, 25 Aug 2025 22:16:19 +0530
Subject: [PATCH] fixing review comment

Signed-off-by: Anushruti Sharma <anushruti10116@gmail.com>
---
 .../ceph-mixin/dashboards/rgw.libsonnet       | 16 ++++++----
 .../dashboards_out/radosgw-overview.json      | 32 ++++++++++++++++---
 2 files changed, 37 insertions(+), 11 deletions(-)

diff --git a/monitoring/ceph-mixin/dashboards/rgw.libsonnet b/monitoring/ceph-mixin/dashboards/rgw.libsonnet
index db49fc6ab4f79..09d66f8b80ac8 100644
--- a/monitoring/ceph-mixin/dashboards/rgw.libsonnet
+++ b/monitoring/ceph-mixin/dashboards/rgw.libsonnet
@@ -200,7 +200,7 @@ local g = import 'grafonnet/grafana.libsonnet';
         1,
         datasource,
         legend_alignAsTable,
-        legend_avg,
+        legend_avg, 
         legend_min,
         legend_max,
         legend_current,
@@ -708,8 +708,8 @@ local g = import 'grafonnet/grafana.libsonnet';
         gridPos: { x: 0, y: 27, w: 24, h: 1 },
       },
       RgwOverviewPanel(
-        'Persistent Topic Length',
-        '',
+        'Pending Notifications by Topic',
+        'Shows the number of pending notifications in each Object topic queue, indicating how many messages are waiting to be delivered',
         '',
         'short',
         |||
@@ -722,10 +722,11 @@ local g = import 'grafonnet/grafana.libsonnet';
         28,
         12,
         8
-      ),
+        )
+      + { options: { legend: { calcs: ['lastNotNull'], displayMode: 'list', placement: 'right', showLegend: true, sortBy: 'Last *', sortDesc: true } } },
       RgwOverviewPanel(
-        'Persistent Topic Size',
-        '',
+        'Pending Notifications size',
+        'Shows the total size of pending notifications stored per Object topic, reflecting how much data is waiting to be delivered.',
         'deckbytes',
         'short',
         |||
@@ -738,7 +739,8 @@ local g = import 'grafonnet/grafana.libsonnet';
         28,
         12,
         8
-      ),
+      )
+      + { options: { legend: { calcs: ['lastNotNull'], displayMode: 'list', placement: 'right', showLegend: true, sortBy: 'Last *', sortDesc: true } } },
     ]),
   'radosgw-detail.json':
     local RgwDetailsPanel(aliasColors,
diff --git a/monitoring/ceph-mixin/dashboards_out/radosgw-overview.json b/monitoring/ceph-mixin/dashboards_out/radosgw-overview.json
index 28f5627473de9..babfab8026109 100644
--- a/monitoring/ceph-mixin/dashboards_out/radosgw-overview.json
+++ b/monitoring/ceph-mixin/dashboards_out/radosgw-overview.json
@@ -1211,7 +1211,7 @@
          "dashLength": 10,
          "dashes": false,
          "datasource": "$datasource",
-         "description": "",
+         "description": "Shows the number of pending notifications in each Object topic queue, indicating how many messages are waiting to be delivered",
          "fieldConfig": {
             "defaults": {
                "custom": {
@@ -1246,6 +1246,18 @@
          "linewidth": 1,
          "links": [ ],
          "nullPointMode": "null as zero",
+         "options": {
+            "legend": {
+               "calcs": [
+                  "lastNotNull"
+               ],
+               "displayMode": "list",
+               "placement": "right",
+               "showLegend": true,
+               "sortBy": "Last *",
+               "sortDesc": true
+            }
+         },
          "percentage": false,
          "pointradius": 5,
          "points": false,
@@ -1267,7 +1279,7 @@
          "thresholds": [ ],
          "timeFrom": null,
          "timeShift": null,
-         "title": "Persistent Topic Length",
+         "title": "Pending Notifications by Topic",
          "tooltip": {
             "shared": true,
             "sort": 0,
@@ -1306,7 +1318,7 @@
          "dashLength": 10,
          "dashes": false,
          "datasource": "$datasource",
-         "description": "",
+         "description": "Shows the total size of pending notifications stored per Object topic, reflecting how much data is waiting to be delivered.",
          "fieldConfig": {
             "defaults": {
                "custom": {
@@ -1341,6 +1353,18 @@
          "linewidth": 1,
          "links": [ ],
          "nullPointMode": "null as zero",
+         "options": {
+            "legend": {
+               "calcs": [
+                  "lastNotNull"
+               ],
+               "displayMode": "list",
+               "placement": "right",
+               "showLegend": true,
+               "sortBy": "Last *",
+               "sortDesc": true
+            }
+         },
          "percentage": false,
          "pointradius": 5,
          "points": false,
@@ -1362,7 +1386,7 @@
          "thresholds": [ ],
          "timeFrom": null,
          "timeShift": null,
-         "title": "Persistent Topic Size",
+         "title": "Pending Notifications size",
          "tooltip": {
             "shared": true,
             "sort": 0,
-- 
2.39.5