Kefu Chai [Mon, 19 Nov 2018 07:05:51 +0000 (15:05 +0800)]
crimson/net: define an alias of seastar::stop_iteration
Signed-off-by: Kefu Chai <kchai@redhat.com>
Yingxin [Wed, 24 Oct 2018 14:49:30 +0000 (22:49 +0800)]
crimson/net: check short reads in `read_exactly()`
Signed-off-by: Yingxin <yingxin.cheng@intel.com>
Yingxin [Wed, 17 Oct 2018 20:45:53 +0000 (04:45 +0800)]
crimson/net: connection closed during connecting
It is possible during `seastar::connect()`, the connection is marked
closed (when SocketConnection::socket is unavailable), then
`seastar::connect()` successfully returns a connected socket.
Signed-off-by: Yingxin <yingxin.cheng@intel.com>
Sage Weil [Mon, 19 Nov 2018 23:31:17 +0000 (17:31 -0600)]
Merge PR #24874 into master
* refs/pull/24874/head:
os/filestore: collect partition/device metadata from journal
os/filestore: include journal in get_devices result
Reviewed-by: Rick Chen <rick.chen@prophetstor.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Sage Weil [Mon, 19 Nov 2018 23:29:57 +0000 (17:29 -0600)]
Merge PR #25140 into master
* refs/pull/25140/head:
mon: by default, do NOT warn about misplaced objects
mon: add mon_warn_on_misplaced option
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: João Eduardo Luís <joao@suse.de>
Sage Weil [Mon, 19 Nov 2018 23:29:41 +0000 (17:29 -0600)]
Merge PR #25147 into master
* refs/pull/25147/head:
mgr/devicehealth: implement config_notify hook
mgr: call config_notify method when mgr's config has changed
mon/MonClient: add callback for (any) config change
common/config: fix debug output for config callbacks changes
Reviewed-by: Tim Serong <tserong@suse.com>
Patrick Donnelly [Mon, 19 Nov 2018 22:17:14 +0000 (14:17 -0800)]
Merge PR #25158 into master
* refs/pull/25158/head:
[doc] Fix typo in luminious release notes
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Sage Weil [Mon, 19 Nov 2018 19:15:21 +0000 (13:15 -0600)]
Merge PR #25111 into master
* refs/pull/25111/head:
test: Add test for requested scrub priority
osd: Prioritize user specified scrubs
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Yuri Weinstein [Mon, 19 Nov 2018 16:49:06 +0000 (08:49 -0800)]
Merge pull request #23819 from dongbula/nf-add-bucket-option-in-usage
rgw: add bucket as option when show/trim usage
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Yuri Weinstein [Mon, 19 Nov 2018 16:47:27 +0000 (08:47 -0800)]
Merge pull request #23318 from theanalyst/wip-curl-errstring
rgw: http client: print curl error messages during curl failures
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Neha Ojha [Mon, 19 Nov 2018 16:46:43 +0000 (22:16 +0530)]
Merge pull request #25069 from markhpc/wip-memory-autotune-doc
doc/rados: Add bluestore memory autotuning docs.
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Yuri Weinstein [Mon, 19 Nov 2018 16:44:50 +0000 (08:44 -0800)]
Merge pull request #24492 from theanalyst/wip-rgw-es-attr-fixes
rgw: ES sync: be more restrictive on object system attrs
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Yuri Weinstein [Mon, 19 Nov 2018 16:44:10 +0000 (08:44 -0800)]
Merge pull request #24730 from pritha-srivastava/wip-rgw-role-fixes
rgw: Minor fixes to radosgw-admin commands for a role.
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Yuri Weinstein [Mon, 19 Nov 2018 16:43:10 +0000 (08:43 -0800)]
Merge pull request #24846 from taoCH/wip-fix-librgw-quota-check
rgw_file: not check max_objects when creating file
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Maxime [Mon, 19 Nov 2018 15:36:04 +0000 (16:36 +0100)]
[doc] Fix typo in luminious release notes
Signed-off-by: Maxime <maxime@root314.com>
Jason Dillaman [Mon, 19 Nov 2018 15:22:52 +0000 (20:52 +0530)]
Merge pull request #24935 from leseb/rbd-mirror-on-reboot
systemd: enable ceph-rbd-mirror.target
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Sebastian Wagner [Mon, 19 Nov 2018 13:55:30 +0000 (14:55 +0100)]
Merge pull request #24863 from jtlayton/wip-orchestrator
mgr/orchestrator: Add support for "ceph orchestrator service ls"
Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Tim Serong <tserong@suse.com>
Lenz Grimmer [Mon, 19 Nov 2018 12:16:28 +0000 (13:16 +0100)]
Merge pull request #24932 from tspmelo/wip-nodejs-update
mgr/dashboard: Update Node.js to current LTS
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Nathan Cutler [Mon, 19 Nov 2018 11:50:57 +0000 (12:50 +0100)]
Merge pull request #24779 from smithfarm/wip-luminous-release-notes
doc: Luminous v12.2.9 release notes
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Lenz Grimmer [Mon, 19 Nov 2018 10:48:35 +0000 (11:48 +0100)]
Merge pull request #25136 from Devp00l/wip-easy-e2e-dev
mgr/dashboard: npm run e2e:dev
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Kefu Chai [Mon, 19 Nov 2018 08:54:20 +0000 (16:54 +0800)]
Merge pull request #25139 from tchaikov/wip-xmlsec
test/dashboard: fix segfault when importing dm.xmlsec.binding
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Mykola Golub [Mon, 19 Nov 2018 07:59:03 +0000 (09:59 +0200)]
Merge pull request #25096 from dillaman/wip-rbd-mirror-peers
librbd: move mirror peer attribute handling from CLI to API
Reviewed-by: Mykola Golub <mgolub@suse.com>
Sage Weil [Sun, 18 Nov 2018 13:04:40 +0000 (07:04 -0600)]
Merge PR #20665 into master
* refs/pull/20665/head:
mgr/balancer: add crush_compat_metrics param
Reviewed-by: Sage Weil <sage@redhat.com>
Sage Weil [Sat, 17 Nov 2018 13:15:36 +0000 (07:15 -0600)]
mgr/devicehealth: implement config_notify hook
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Sat, 17 Nov 2018 13:15:19 +0000 (07:15 -0600)]
mgr: call config_notify method when mgr's config has changed
This provides a hook for the module to refresh any config values it has
cached in module-local variables.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Sat, 17 Nov 2018 12:50:17 +0000 (06:50 -0600)]
mon/MonClient: add callback for (any) config change
This is a coarse "there was some config update". It's fired whether or
not it values are observed.
Signed-off-by: Sage Weil <sage@redhat.com>
Casey Bodley [Fri, 16 Nov 2018 19:23:39 +0000 (14:23 -0500)]
Merge pull request #25135 from cbodley/wip-test-log-garble
test: fix libc++ crash in Log.GarbleRecovery
Reviewed-by: Adam Kupczyk <akucpzyk@redhat.com>
Kefu Chai [Fri, 16 Nov 2018 17:25:47 +0000 (01:25 +0800)]
test/dashboard: fix segfault when importing dm.xmlsec.binding
python-saml depends on dm.xmlsec.binding which is a python binding of
xmlsec C library. but without -DXMLSEC_NO_SIZE_T the compiled
dm.xmlsec.binding segfaults when `import dm.xmlsec.binding`. see
https://github.com/onelogin/python-saml/issues/30 and
https://github.com/4teamwork/ftw.saml2auth/issues/3 .
in long term, we might want to switch to python-saml, see
http://tracker.ceph.com/issues/37081
Signed-off-by: Kefu Chai <kchai@redhat.com>
Sage Weil [Fri, 16 Nov 2018 17:03:37 +0000 (11:03 -0600)]
mon: by default, do NOT warn about misplaced objects
Misplaced objects are not something that puts the health or safety of
data in jeopardy. Don't warn about it by default.
Since this is a change in behavior, add a release note.
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Fri, 16 Nov 2018 17:00:52 +0000 (11:00 -0600)]
mon: add mon_warn_on_misplaced option
Control whether we issue HEALTH_WARN due to misplaced objects.
Signed-off-by: Sage Weil <sage@redhat.com>
Yuri Weinstein [Fri, 16 Nov 2018 16:06:51 +0000 (08:06 -0800)]
Merge pull request #22613 from zhangsw/fix-rgw-copyobj-tailtag
rgw: Copying object data should generate new tail tag for the new object.
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Yuri Weinstein [Fri, 16 Nov 2018 16:06:23 +0000 (08:06 -0800)]
Merge pull request #23652 from theanalyst/rgw/awsv4/presign-slashes
rgw: s3: awsv4 drop special handling for x-amz-credential
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Yuri Weinstein [Fri, 16 Nov 2018 16:03:35 +0000 (08:03 -0800)]
Merge pull request #25003 from ivancich/wip-update-reshard-params
rgw: reshard improvements
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Yuri Weinstein [Fri, 16 Nov 2018 16:03:09 +0000 (08:03 -0800)]
Merge pull request #25102 from cbodley/wip-rgw-log-http-status
rgw: log http status with op prefix if available
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Stephan Müller [Fri, 16 Nov 2018 14:39:53 +0000 (15:39 +0100)]
mgr/dashboard: npm run e2e:dev
The new command introduced will make developing e2e tests faster, as
Protractor will attach to the running development server that was
previously started running 'npm start'.
Fixes: https://tracker.ceph.com/issues/37291
Signed-off-by: Stephan Müller <smueller@suse.com>
Casey Bodley [Fri, 16 Nov 2018 15:36:12 +0000 (10:36 -0500)]
test: fix libc++ crash in Log.GarbleRecovery
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Alfredo Deza [Fri, 16 Nov 2018 15:28:16 +0000 (10:28 -0500)]
Merge pull request #25007 from jan--f/c-v-dont-duplicated-rejected-reasons
ceph-volume: rename Device property valid to available
Reviewed-by: Alfredo Deza <adeza@redhat.com>
Casey Bodley [Fri, 16 Nov 2018 14:57:04 +0000 (09:57 -0500)]
Merge pull request #25002 from yehudasa/wip-rgw-svc-5
rgw: fix uninitialized access
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Fri, 16 Nov 2018 14:32:08 +0000 (22:32 +0800)]
Merge pull request #24967 from bi-shun/fix-brotli
compressor: Fix build of Brotli Compressor
Reviewed-by: Kefu Chai <kchai@redhat.com>
Lenz Grimmer [Fri, 16 Nov 2018 14:26:32 +0000 (15:26 +0100)]
Merge pull request #24803 from tspmelo/wip-i18n
mgr/dashboard: Add i18n support
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Sage Weil [Fri, 16 Nov 2018 13:11:44 +0000 (07:11 -0600)]
Merge PR #14092 into master
* refs/pull/14092/head:
mgr/DaemonServer: fix session leak
mon/MonClient: ignore new mon commands while stopping
mgr/DeviceState: fix DeviceState initial refcount
qa/suites: valgrind ceph-mgr too
Reviewed-by: Kefu Chai <kchai@redhat.com>
Sage Weil [Fri, 16 Nov 2018 13:11:15 +0000 (07:11 -0600)]
Merge PR #25052 into master
* refs/pull/25052/head:
mgr: lock pg_map too for osd_pool_stats and notify_osdmap
mgr/DaemonServer: use with_osdmap_and_pgmap instead of nested calls
mgr/ClusterState: add with_osdmap_and_pgmap
Reviewed-by: Kefu Chai <kchai@redhat.com>
BI SHUN KE [Wed, 7 Nov 2018 08:14:22 +0000 (16:14 +0800)]
compressor: modify brotli compression plugin.
* add "common/ceph_context.h" header file to CompressionPluginBrotli.cc
* set the brotli v1.0.7 stable version for compressor plugin use.
Signed-off-by: BI SHUN KE <aionshun@livemail.tw>
Alfredo Deza [Fri, 16 Nov 2018 12:52:57 +0000 (07:52 -0500)]
Merge pull request #25092 from jan--f/c-v-inventory-doc
doc: add ceph-volume inventory sections
Reviewed-by: Alfredo Deza <adeza@redhat.com>
Jason Dillaman [Wed, 14 Nov 2018 16:26:51 +0000 (21:56 +0530)]
rbd: switch to use new mirror peer attribute API methods
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Jason Dillaman [Wed, 14 Nov 2018 15:40:26 +0000 (21:10 +0530)]
librbd: new API methods to get/set mirror peer attributes
The dashboard will need to manipulate the remote cluster mon_host and
key attributes. This logic should be re-used between the rbd CLI and
the dashboard.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Lenz Grimmer [Fri, 16 Nov 2018 11:59:37 +0000 (12:59 +0100)]
Merge pull request #25053 from rhcs-dashboard/pytest-faulthandler
mgr/dashboard: add pytest plugin: faulthandler
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Sage Weil [Fri, 16 Nov 2018 10:38:31 +0000 (04:38 -0600)]
common/config: fix debug output for config callbacks changes
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Thu, 15 Nov 2018 22:27:18 +0000 (16:27 -0600)]
mgr: lock pg_map too for osd_pool_stats and notify_osdmap
Fixes: http://tracker.ceph.com/issues/36766
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Thu, 15 Nov 2018 22:28:34 +0000 (16:28 -0600)]
mgr/DaemonServer: use with_osdmap_and_pgmap instead of nested calls
Signed-off-by: Sage Weil <sage@redhat.com>
Kefu Chai [Fri, 16 Nov 2018 10:34:24 +0000 (18:34 +0800)]
Merge pull request #25046 from tchaikov/wip-16500
tests: do not check for invalid k/m combinations
Reviewed-by: Jianpeng Ma <jianpeng.ma@intel.com>
Lenz Grimmer [Fri, 16 Nov 2018 10:16:42 +0000 (11:16 +0100)]
Merge pull request #25084 from s0nea/wip-dashboard-add-missing-test-suites
mgr/dashboard/qa: add missing dashboard suites
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Jan Fajerski [Fri, 16 Nov 2018 08:27:34 +0000 (09:27 +0100)]
c-v device test: rename valid to available
Update test to reflect
8a80990471108b0920d1d8aa1239733ae2b20e9c
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
Jan Fajerski [Fri, 16 Nov 2018 08:24:37 +0000 (09:24 +0100)]
inventory test: rename valid to available
Fixes test to reflect
8a80990471108b0920d1d8aa1239733ae2b20e9c
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
Jan Fajerski [Fri, 16 Nov 2018 08:22:06 +0000 (09:22 +0100)]
ceph-volume: rename Device property valid to available
This flag is used in the inventory reporting and available is deemed more
appropriate. Furthermore this fixes a bug where rejected_reasons
accumulated duplicate entries.
Fixes: http://tracker.ceph.com/issues/36701
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
Jan Fajerski [Wed, 14 Nov 2018 13:09:37 +0000 (14:09 +0100)]
doc: add ceph-volume inventory sections
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
Sage Weil [Fri, 16 Nov 2018 06:23:14 +0000 (00:23 -0600)]
Merge PR #24973 into master
* refs/pull/24973/head:
mgr: Separate diskprediction cloud plugin from the diskprediction plugin
Sage Weil [Fri, 16 Nov 2018 06:22:37 +0000 (00:22 -0600)]
Merge PR #20185 into master
* refs/pull/20185/head:
Common, log: Added functionality test for recovery after silenced (#20174)
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sage Weil [Fri, 16 Nov 2018 06:22:17 +0000 (00:22 -0600)]
Merge PR #19987 into master
* refs/pull/19987/head:
qa/tasks/ceph: ignore failure when chown ceph:ceph
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
hsiang41 [Wed, 7 Nov 2018 14:05:35 +0000 (22:05 +0800)]
mgr: Separate diskprediction cloud plugin from the diskprediction plugin
Separate diskprediction local cloud from the diskprediction plugin.
Devicehealth invoke device prediction function related on the global
configuration "device_failure_prediction_mode".
Signed-off-by: Rick Chen <rick.chen@prophetstor.com>
Sage Weil [Fri, 9 Nov 2018 03:30:09 +0000 (21:30 -0600)]
mgr/DaemonServer: fix session leak
Signed-off-by: Sage Weil <sage@redhat.com>
Sage Weil [Fri, 9 Nov 2018 03:28:18 +0000 (21:28 -0600)]
mon/MonClient: ignore new mon commands while stopping
If one thread is stopping and another threads tries to send a new mon
command, just ignore it.
Signed-off-by: Sage Weil <sage@redhat.com>
Kefu Chai [Fri, 16 Nov 2018 05:22:16 +0000 (13:22 +0800)]
Merge pull request #20683 from Aran85/wip-rados-loadgen-align
tools: add offset-align option to "rados" load-gen
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Fri, 16 Nov 2018 05:21:07 +0000 (13:21 +0800)]
Merge pull request #24799 from xiexingguo/wip-js-safe-to-destroy
mgr/DaemonServer: add js-output for "ceph osd safe-to-destroy"
Reviewed-by: Sage Weil <sage@redhat.com>
Kefu Chai [Fri, 16 Nov 2018 05:19:53 +0000 (13:19 +0800)]
Merge pull request #24969 from joke-lee/doc-dump-journal-help-info
osd: add --dump-journal option in ceph-osd help info
Reviewed-by: Neha Ojha <nojha@redhat.com>
Jason Dillaman [Thu, 15 Nov 2018 06:49:37 +0000 (12:19 +0530)]
librbd: retry mirror disable if parent/clone ordering causes issues
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Sage Weil [Thu, 15 Nov 2018 22:26:48 +0000 (16:26 -0600)]
mgr/ClusterState: add with_osdmap_and_pgmap
Several call sites need to lock both
Signed-off-by: Sage Weil <sage@redhat.com>
Casey Bodley [Thu, 15 Nov 2018 19:01:17 +0000 (14:01 -0500)]
Merge pull request #24866 from linuxbox2/wip-rm-aclparser
rgw: remove rgw_aclparser.cc
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 16:06:57 +0000 (00:06 +0800)]
Merge pull request #25108 from tchaikov/wip-bluestore-repair
tools/ceph_kvstore_tool: do not open rocksdb when repairing it
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Jeff Layton [Wed, 14 Nov 2018 17:38:22 +0000 (12:38 -0500)]
orchestrator: merge the ServiceLocation class into ServiceDescription
The ServiceDescription object just holds a list of ServiceLocation
objects. Eliminate ServiceLocation and merge it into the
ServiceDescription class. Have describe_service return a list of
ServiceDescriptions.
Suggested-by: Tim Serong <tserong@suse.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 13:15:33 +0000 (21:15 +0800)]
Merge pull request #25070 from tchaikov/wip-25146
rocksdb: pick up a fix to be backward compatible
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Jeff Layton [Tue, 30 Oct 2018 18:28:02 +0000 (14:28 -0400)]
orchestrator_cli: add an orchestrator service ls function
There's currently no way to enumerate the services that the
orchestrator backend knows about. Add a "service ls" command
that will list them with some basic info, subject to filters
given on the command line.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Wed, 31 Oct 2018 17:42:56 +0000 (13:42 -0400)]
orchestrator/rook: rework describe_service() to accomodate "service ls"
Rework the describe_service operation for rook to allow listing of
services, with optional filters for service type, id and nodename.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeff Layton [Tue, 30 Oct 2018 18:21:33 +0000 (14:21 -0400)]
orchestrator: rework describe_service prototype to allow for nodename
...and a new service_type field in ServiceLocation object.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Tatjana Dehler [Wed, 14 Nov 2018 07:36:31 +0000 (08:36 +0100)]
mgr/dashboard/qa: add missing dashboard suites
Fixes: https://tracker.ceph.com/issues/37152
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
Kefu Chai [Tue, 13 Nov 2018 03:28:40 +0000 (11:28 +0800)]
rocksdb: pick up a fix to be backward compatible
see https://github.com/facebook/rocksdb/pull/3488
also bump up the rocksdb version to v5.17.2
Fixes: http://tracker.ceph.com/issues/25146
Signed-off-by: Kefu Chai <kchai@redhat.com>
David Zafman [Thu, 6 Sep 2018 04:42:43 +0000 (21:42 -0700)]
test: Add test for requested scrub priority
Signed-off-by: David Zafman <dzafman@redhat.com>
David Zafman [Thu, 15 Nov 2018 07:56:51 +0000 (23:56 -0800)]
osd: Prioritize user specified scrubs
Fixes: http://tracker.ceph.com/issues/37269
Signed-off-by: David Zafman <dzafman@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 07:40:04 +0000 (15:40 +0800)]
Merge pull request #24901 from wjwithagen/wjw-fix-rbd-ggate-cmake
tool: link rbd-ggate against librados-cxx
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 07:29:39 +0000 (15:29 +0800)]
Merge pull request #25060 from mooncak/fix_typos
doc: Fix some typos
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 07:14:03 +0000 (15:14 +0800)]
Merge pull request #24999 from MrStupnikov/master-docfix-1358
doc: Put command template into literal block
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Wed, 14 Nov 2018 08:33:04 +0000 (16:33 +0800)]
erasure-code/lrc: error out if "l == 0"
l (locality) should not be 0, and k+m should be multiple of it
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 12 Nov 2018 03:04:54 +0000 (11:04 +0800)]
erasure-code: return error using `ss` not derr
log is not very visible from user's perspective. we'd better return the
error message using the input parameter, if the technique is
unsupported.
also, remove the trailing newline, as `ss` will be sent back to user,
it's the the front-end's responsibility to format the error message.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 12 Nov 2018 01:55:14 +0000 (09:55 +0800)]
tests: do not check for invalid k/m combinations
This reverts commit
c5bafae6fd10282f408695c7763b1277469123f6.
in
37f73607 and
3ec41030, we detect invalid "k". and we should always
detect invalid combinations of parameters in
ErasureCodeInterface::init(), and return -EINVAL instead of "autotune" them
as put in the commit message of
c5bafae6, if the profile is invalid for
given erasure plugin. so ErasureCodeBench::encode() and
ErasureCodeBench::decode() will bail out with the error message returned by
ErasureCodeInterface::init() if the parameters are not valid.
also, i checked all ErasureCodeInterface::init() implementations, none
of them is overwriting the settings without returning a non-zero return
code. so we are not overriding or autotuning the settings specified by
user.
Fixes: http://tracker.ceph.com/issues/16500
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Mon, 12 Nov 2018 01:49:53 +0000 (09:49 +0800)]
tests: use stoi() instead of atoi()
stoi() is simpler if we need to convert std::string to integer.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 06:28:47 +0000 (14:28 +0800)]
Merge pull request #24996 from mcv21/bug/note_file_move
debian: correct ceph-common relationship with older radosgw package
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 06:26:53 +0000 (14:26 +0800)]
Merge pull request #25048 from swinds24/master_fix_36764
ceph-mgr: hold lock while accessing the request list and submitting request
Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 06:16:05 +0000 (14:16 +0800)]
Merge pull request #24458 from rzarzynski/wip-osd-drop-osd_instructions
osd: drop the unused request_redirect_t::osd_instructions
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 06:13:39 +0000 (14:13 +0800)]
Merge pull request #24141 from liu-chunmei/ceph_seastar_perfcounter
common,crimson: port perfcounters to seastar
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 06:12:09 +0000 (14:12 +0800)]
Merge pull request #24858 from jecluis/wip-pr-19983-tests
qa/cephtool: test bounds on pool's `hit_set_*`
Reviewed-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 06:06:54 +0000 (14:06 +0800)]
Merge pull request #25106 from tchaikov/wip-qa-envlibrados
qa: fix upgrade tests and test_envlibrados_for_rocksdb.sh
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 05:56:19 +0000 (13:56 +0800)]
tools/ceph_kvstore_tool: do not open rocksdb when repairing it
before this change, the `need_open_db` parameter is passed to the
constructor of BlueStore as `min_alloc_size`. and rocksdb will fail to
repair because Repairer::Run() also tries to acquire the db lock, and it
will fail to do so if the lock file is already acquired by
BlueStore::_mount().
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 05:02:59 +0000 (13:02 +0800)]
qa: patch rocksdb the right way
quote from patch(1)
> but usually just
>
> patch -pnum <patchfile
Signed-off-by: Kefu Chai <kchai@redhat.com>
Neha Ojha [Thu, 15 Nov 2018 04:51:55 +0000 (20:51 -0800)]
Merge pull request #24979 from neha-ojha/wip-upgrade-bug
doc/releases/mimic.rst: make note of 13.2.2 upgrade bug
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 04:09:49 +0000 (12:09 +0800)]
Merge pull request #25072 from tchaikov/wip-silence-sign-compare
os/tests: silence -Wsign-compare warning
Reviewed-by: Jos Collin <jcollin@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 01:47:27 +0000 (09:47 +0800)]
qa: use FOUND_VAR to be backward compatible with cmake 2.8.12
before this change, we assume that the variable set if rados::radospp is
found will be radospp_FOUND, but this is a feature cmake 3, see
https://cmake.org/cmake/help/v3.3/module/FindPackageHandleStandardArgs.html
while the cmake shipped by centos is cmake 2.8.12, where the variable
name will be <UPPERCASED_NAME>_FOUND, see
https://cmake.org/cmake/help/v2.8.12/cmake.html#module:FindPackageHandleStandardArgs
in the test of test_envlibrados_for_rocksdb.sh, we are using cmake not
the cmake3 offered by EPEL7, so RADOSPP_FOUND will be set instead. that's why
executable env_librados_test will fail to link against rados::radospp.
as rados::radospp won't be defined if radospp_FOUND is not defined/set.
after this change, the 2nd mode of FIND_PACKAGE_HANDLE_STANDARD_ARGS()
is used instead to ensure that radospp_FOUND is defined even if cmake
2.8.12 is used.
also, the message() commands for debugging purpose are removed.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Kefu Chai [Thu, 15 Nov 2018 03:34:29 +0000 (11:34 +0800)]
qa/suites: add librados2 to "extra_packages" for upgrade tests
we use the playbook of "testnodes.yml" defined by ceph-cm-ansible for
initializing test nodes, and the role of "testnode" is used by
testnodes.yml. "testnode" requires "qemu-system-x86" or "qemu-kvm"
package to be installed. the qemu in turn depends on librbd1 and
librados2.
before librados3 was introduced, this worked perfectly. because in ceph
repo, qa/packages/packages.yaml defines the default set of packages the
"install" tasks should install. and in that yaml file, librados2 was
listed. so the package management system will overwrite the librados2
installed by ansible playbook with the version specified by the
"install" task, as apt/yum thinks this is what user requires explicitly,
so it's fine to install a different version of librados2.
after librados3 was introduced, librados2 was removed from
qa/packages/packages.yaml. because, by default, we need to install
librados3 instead of librados2 for ready a nautilus cluster. but the
problem is, the packge list also applies to "install" tasks installing
releases before nautilus, where we still need to replace the librados2
installed by ansible.
so, to address this issue, "librados2" is added to "extra_packages" of
the "install" tasks of tests installing old releases to install
librados2 explicitly instead of as a dependency of other ceph packages
like librbd1.
Signed-off-by: Kefu Chai <kchai@redhat.com>
xie xingguo [Mon, 29 Oct 2018 08:56:07 +0000 (16:56 +0800)]
mgr/DaemonServer: add js-output for "ceph osd safe-to-destroy"
E.g.:
- case 1:
$ceph osd safe-to-destroy 0 1 2 -f json-pretty
Error EAGAIN: 12 pgs have unknown state; cannot draw any conclusions
- case 2:
$ceph osd safe-to-destroy 0 1 2 -f json-pretty
{
"safe_to_destroy": [
0,
1,
2
],
"active": [],
"missing_stats": [],
"stored_pgs": []
}
- case 3:
$ceph osd safe-to-destroy 0 1 2 -f json-pretty
{
"safe_to_destroy": [],
"active": [
0,
1,
2
],
"missing_stats": [],
"stored_pgs": []
}
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Tiago Melo [Wed, 7 Nov 2018 19:01:53 +0000 (19:01 +0000)]
mgr/dashboard: Trim HTML translations
Signed-off-by: Tiago Melo <tmelo@suse.com>
Tiago Melo [Mon, 29 Oct 2018 12:54:43 +0000 (12:54 +0000)]
mgr/dashboard: Add locale files
Signed-off-by: Tiago Melo <tmelo@suse.com>