X-Git-Url: http://git.apps.os.sepia.ceph.com/?p=xfstests-dev.git;a=blobdiff_plain;f=src%2Fopen_by_handle.c;h=9c13b2ab072b8173d6592bb5ddfbf775119013b2;hp=63ebdacbe09f8d2abcc7820b6176ea98fa130e22;hb=259cf891310f9a4519e74de2b66ba084dac27763;hpb=52107267320f7c695921f97a0231797ddf05b32e diff --git a/src/open_by_handle.c b/src/open_by_handle.c index 63ebdacb..9c13b2ab 100644 --- a/src/open_by_handle.c +++ b/src/open_by_handle.c @@ -27,13 +27,13 @@ /* -usage: open_by_handle [-c|-l|-u|-d] [num_files] +usage: open_by_handle [-cludmrwapk] [num_files] Examples: -1. Create test set of N files and try to get their NFS handles: +1. Create test set of of test_dir with N files and try to get their NFS handles: - open_by_handle -c [N] + open_by_handle -cp [N] This is used by new helper _require_exportfs() to check if filesystem supports exportfs @@ -41,14 +41,32 @@ Examples: 2. Get file handles for existing test set, drop caches and try to open all files by handle: - open_by_handle [N] + open_by_handle -p [N] -3. Get file handles for existing test set, unlink all test files, - drop caches, try to open all files by handle and expect ESTALE: +3. Get file handles for existing test set, write data to files, + drop caches, open all files by handle, read and verify written + data, write new data to file: - open_by_handle -d [N] + open_by_handle -rwa [N] -4. Get file handles for existing test set, hardlink all test files, +4. Get file handles for existing test set, unlink all test files, + remove test_dir, drop caches, try to open all files by handle + and expect ESTALE: + + open_by_handle -dp [N] + +5. Get file handles for existing test set, keep open file handles for all + test files, unlink all test files, drop caches and try to open all files + by handle (should work): + + open_by_handle -dk [N] + +6. Get file handles for existing test set, rename all test files, + drop caches, try to open all files by handle (should work): + + open_by_handle -m [N] + +7. Get file handles for existing test set, hardlink all test files, then unlink the original files, drop caches and try to open all files by handle (should work): @@ -74,23 +92,30 @@ Examples: #include #include #include +#include #define MAXFILES 1024 struct handle { struct file_handle fh; unsigned char fid[MAX_HANDLE_SZ]; -} handle[MAXFILES]; +} handle[MAXFILES], dir_handle; void usage(void) { - fprintf(stderr, "usage: open_by_handle [-c|-l|-u|-d] [num_files]\n"); + fprintf(stderr, "usage: open_by_handle [-cludmrwapk] [num_files]\n"); fprintf(stderr, "\n"); fprintf(stderr, "open_by_handle -c [N] - create N test files under test_dir, try to get file handles and exit\n"); fprintf(stderr, "open_by_handle [N] - get file handles of test files, drop caches and try to open by handle\n"); + fprintf(stderr, "open_by_handle -k [N] - get file handles of files that are kept open, drop caches and try to open by handle\n"); + fprintf(stderr, "open_by_handle -w [N] - write data to test files before open by handle\n"); + fprintf(stderr, "open_by_handle -r [N] - read data from test files after open by handle and verify written data\n"); + fprintf(stderr, "open_by_handle -a [N] - write data to test files after open by handle\n"); fprintf(stderr, "open_by_handle -l [N] - create hardlinks to test files, drop caches and try to open by handle\n"); fprintf(stderr, "open_by_handle -u [N] - unlink (hardlinked) test files, drop caches and try to open by handle\n"); fprintf(stderr, "open_by_handle -d [N] - unlink test files and hardlinks, drop caches and try to open by handle\n"); + fprintf(stderr, "open_by_handle -m [N] - rename test files, drop caches and try to open by handle\n"); + fprintf(stderr, "open_by_handle -p - create/delete and try to open by handle also test_dir itself\n"); exit(EXIT_FAILURE); } @@ -98,23 +123,39 @@ int main(int argc, char **argv) { int i, c; int fd; - int ret; + int ret = 0; int failed = 0; + char dname[PATH_MAX]; char fname[PATH_MAX]; char fname2[PATH_MAX]; char *test_dir; + char *mount_dir; int mount_fd, mount_id; int numfiles = 1; - int create = 0, delete = 0, nlink = 1; + int create = 0, delete = 0, nlink = 1, move = 0; + int rd = 0, wr = 0, wrafter = 0, parent = 0; + int keepopen = 0; if (argc < 2 || argc > 4) usage(); - while ((c = getopt(argc, argv, "clud")) != -1) { + while ((c = getopt(argc, argv, "cludmrwapk")) != -1) { switch (c) { case 'c': create = 1; break; + case 'w': + /* Write data before open_by_handle_at() */ + wr = 1; + break; + case 'r': + /* Read data after open_by_handle_at() */ + rd = 1; + break; + case 'a': + /* Write data after open_by_handle_at() */ + wrafter = 1; + break; case 'l': nlink = 2; break; @@ -126,6 +167,15 @@ int main(int argc, char **argv) delete = 1; nlink = 0; break; + case 'm': + move = 1; + break; + case 'p': + parent = 1; + break; + case 'k': + keepopen = 1; + break; default: fprintf(stderr, "illegal option '%s'\n", argv[optind]); case 'h': @@ -142,9 +192,27 @@ int main(int argc, char **argv) usage(); } - mount_fd = open(test_dir, O_RDONLY|O_DIRECTORY); + if (parent) { + strcpy(dname, test_dir); + /* + * -p flag implies that test_dir is NOT a mount point, + * so its parent can be used as mount_fd for open_by_handle_at. + */ + mount_dir = dirname(dname); + if (create) + ret = mkdir(test_dir, 0700); + if (ret < 0 && errno != EEXIST) { + strcat(dname, ": mkdir"); + perror(dname); + return EXIT_FAILURE; + } + } else { + mount_dir = test_dir; + } + + mount_fd = open(mount_dir, O_RDONLY|O_DIRECTORY); if (mount_fd < 0) { - perror(test_dir); + perror(mount_dir); return EXIT_FAILURE; } @@ -156,7 +224,7 @@ int main(int argc, char **argv) sprintf(fname2, "%s/link%06d", test_dir, i); fd = open(fname, O_RDWR | O_CREAT | O_TRUNC, 0644); if (fd < 0) { - printf("Warning (%s,%d), open(%s) failed.\n", __FILE__, __LINE__, fname); + strcat(fname, ": open(O_CREAT)"); perror(fname); return EXIT_FAILURE; } @@ -164,7 +232,8 @@ int main(int argc, char **argv) /* blow up leftovers hardlinks if they exist */ ret = unlink(fname2); if (ret < 0 && errno != ENOENT) { - perror("unlink"); + strcat(fname2, ": unlink"); + perror(fname2); return EXIT_FAILURE; } } @@ -178,11 +247,48 @@ int main(int argc, char **argv) handle[i].fh.handle_bytes = MAX_HANDLE_SZ; ret = name_to_handle_at(AT_FDCWD, fname, &handle[i].fh, &mount_id, 0); if (ret < 0) { - perror("name_to_handle"); + strcat(fname, ": name_to_handle"); + perror(fname); + return EXIT_FAILURE; + } + if (keepopen) { + /* Open without close to keep unlinked files around */ + fd = open(fname, O_RDONLY); + if (fd < 0) { + strcat(fname, ": open(O_RDONLY)"); + perror(fname); + return EXIT_FAILURE; + } + } + } + + if (parent) { + dir_handle.fh.handle_bytes = MAX_HANDLE_SZ; + ret = name_to_handle_at(AT_FDCWD, test_dir, &dir_handle.fh, &mount_id, 0); + if (ret < 0) { + strcat(dname, ": name_to_handle"); + perror(dname); return EXIT_FAILURE; } } + /* write data to files */ + for (i=0; wr && i < numfiles; i++) { + sprintf(fname, "%s/file%06d", test_dir, i); + fd = open(fname, O_WRONLY, 0644); + if (fd < 0) { + strcat(fname, ": open"); + perror(fname); + return EXIT_FAILURE; + } + if (write(fd, "aaaa", 4) != 4) { + strcat(fname, ": write before"); + perror(fname); + return EXIT_FAILURE; + } + close(fd); + } + /* after creating test set only check that fs supports exportfs */ if (create) return EXIT_SUCCESS; @@ -193,7 +299,20 @@ int main(int argc, char **argv) sprintf(fname2, "%s/link%06d", test_dir, i); ret = link(fname, fname2); if (ret < 0) { - perror("link"); + strcat(fname2, ": link"); + perror(fname2); + return EXIT_FAILURE; + } + } + + /* rename the files */ + for (i=0; move && i < numfiles; i++) { + sprintf(fname, "%s/file%06d", test_dir, i); + sprintf(fname2, "%s/link%06d", test_dir, i); + ret = rename(fname, fname2); + if (ret < 0) { + strcat(fname2, ": rename"); + perror(fname2); return EXIT_FAILURE; } } @@ -204,14 +323,25 @@ int main(int argc, char **argv) sprintf(fname2, "%s/link%06d", test_dir, i); ret = unlink(fname); if (ret < 0) { - perror("unlink"); + strcat(fname, ": unlink"); + perror(fname); return EXIT_FAILURE; } /* with -d flag, delete the hardlink if it exists */ if (!nlink) ret = unlink(fname2); if (ret < 0 && errno != ENOENT) { - perror("unlink"); + strcat(fname2, ": unlink"); + perror(fname2); + return EXIT_FAILURE; + } + } + + if (parent && delete && !nlink) { + ret = rmdir(test_dir); + if (ret < 0) { + strcat(dname, ": rmdir"); + perror(dname); return EXIT_FAILURE; } } @@ -239,22 +369,85 @@ int main(int argc, char **argv) */ for (i=0; i < numfiles; i++) { errno = 0; - fd = open_by_handle_at(mount_fd, &handle[i].fh, O_RDWR); - if (nlink && fd >= 0) { + fd = open_by_handle_at(mount_fd, &handle[i].fh, wrafter ? O_RDWR : O_RDONLY); + if ((nlink || keepopen) && fd >= 0) { + if (rd) { + char buf[4] = {0}; + int size = read(fd, buf, 4); + if (size < 0) { + strcat(fname, ": read"); + perror(fname); + return EXIT_FAILURE; + } + if (size < 4 || memcmp(buf, "aaaa", 4)) { + printf("open_by_handle(%s) returned stale data '%.*s'!\n", fname, size, buf); + } + } + if (wrafter && write(fd, "aaaa", 4) != 4) { + strcat(fname, ": write after"); + perror(fname); + return EXIT_FAILURE; + } close(fd); continue; - } else if (!nlink && fd < 0 && (errno == ENOENT || errno == ESTALE)) { + } else if (!nlink && !keepopen && fd < 0 && (errno == ENOENT || errno == ESTALE)) { continue; } + sprintf(fname, "%s/file%06d", test_dir, i); if (fd >= 0) { - printf("open_by_handle(%d) opened an unlinked file!\n", i); + printf("open_by_handle(%s) opened an unlinked file!\n", fname); close(fd); } else { - printf("open_by_handle(%d) returned %d incorrectly on %s file!\n", i, errno, - nlink ? "a linked" : "an unlinked"); + printf("open_by_handle(%s) returned %d incorrectly on %s%s file!\n", + fname, errno, + nlink ? "a linked" : "an unlinked", + keepopen ? " open" : ""); } failed++; } + + if (parent) { + fd = open_by_handle_at(mount_fd, &dir_handle.fh, O_RDONLY|O_DIRECTORY); + if (fd >= 0) { + if (!nlink) { + printf("open_by_handle(%s) opened an unlinked dir!\n", dname); + return EXIT_FAILURE; + } else if (rd) { + /* + * Sanity check dir fd - expect to access orig file IFF + * it was not unlinked nor renamed. + */ + strcpy(fname, "file000000"); + ret = faccessat(fd, fname, F_OK, 0); + if ((ret == 0) != (!delete && !move) || + ((ret < 0) && errno != ENOENT)) { + strcat(fname, ": unexpected result from faccessat"); + perror(fname); + return EXIT_FAILURE; + } + /* + * Expect to access link file if ran test with -l flag + * (nlink > 1), -m flag (orig moved to link name) or + * -u flag (which implied previous -l run). + */ + strcpy(fname2, "link000000"); + ret = faccessat(fd, fname2, F_OK, 0); + if (ret < 0 && (nlink > 1 || delete || move || + errno != ENOENT)) { + strcat(fname2, ": unexpected result from faccessat"); + perror(fname2); + return EXIT_FAILURE; + } + } + close(fd); + } else if (nlink || !(errno == ENOENT || errno == ESTALE)) { + printf("open_by_handle(%s) returned %d incorrectly on %s dir!\n", + dname, errno, + nlink ? "a linked" : "an unlinked"); + return EXIT_FAILURE; + } + } + if (failed) return EXIT_FAILURE; return EXIT_SUCCESS;