fstests: _fail test by default when _scratch_mount fails
authorEryu Guan <eguan@redhat.com>
Wed, 7 Feb 2018 09:31:36 +0000 (17:31 +0800)
committerEryu Guan <eguan@redhat.com>
Thu, 22 Feb 2018 06:02:44 +0000 (14:02 +0800)
commit69eb6281a9d37110364bd08476599efb3a996440
tree6f370d338eae1c1e0951da3787715b136022a1db
parent729381bda427effaddbae25af6395bb257aaf63a
fstests: _fail test by default when _scratch_mount fails

Previously _scratch_mount didn't check the mount status and most
tests continue to run even if the mount failed (unless test checks
for the mount status explicitly). This would result in running tests
on the underlying filesystem (usually rootfs) and implicit test
failures, and such failures can be annoying and are usually hard to
debug.

Now _fail test by default if _scratch_mount failed and introduce
_try_scratch_mount for tests that need to check mount results
themselves.

Suggested-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
109 files changed:
common/attr
common/dmapi
common/dump
common/encrypt
common/filestreams
common/fuzzy
common/log
common/overlay
common/punch
common/quota
common/rc
common/xfs
tests/btrfs/004
tests/btrfs/007
tests/btrfs/009
tests/btrfs/012
tests/btrfs/042
tests/btrfs/057
tests/btrfs/091
tests/btrfs/131
tests/btrfs/136
tests/ext4/003
tests/ext4/006
tests/ext4/007
tests/ext4/008
tests/ext4/011
tests/ext4/012
tests/ext4/024
tests/ext4/025
tests/ext4/305
tests/ext4/306
tests/generic/015
tests/generic/019
tests/generic/050
tests/generic/052
tests/generic/053
tests/generic/054
tests/generic/055
tests/generic/062
tests/generic/064
tests/generic/068
tests/generic/069
tests/generic/076
tests/generic/077
tests/generic/079
tests/generic/082
tests/generic/083
tests/generic/105
tests/generic/117
tests/generic/120
tests/generic/169
tests/generic/235
tests/generic/270
tests/generic/294
tests/generic/317
tests/generic/318
tests/generic/388
tests/generic/390
tests/generic/403
tests/generic/466
tests/shared/003
tests/xfs/005
tests/xfs/009
tests/xfs/016
tests/xfs/017
tests/xfs/019
tests/xfs/021
tests/xfs/034
tests/xfs/041
tests/xfs/042
tests/xfs/044
tests/xfs/045
tests/xfs/057
tests/xfs/067
tests/xfs/072
tests/xfs/073
tests/xfs/075
tests/xfs/077
tests/xfs/079
tests/xfs/083
tests/xfs/085
tests/xfs/090
tests/xfs/092
tests/xfs/094
tests/xfs/098
tests/xfs/103
tests/xfs/104
tests/xfs/111
tests/xfs/121
tests/xfs/130
tests/xfs/137
tests/xfs/141
tests/xfs/177
tests/xfs/181
tests/xfs/183
tests/xfs/189
tests/xfs/263
tests/xfs/270
tests/xfs/297
tests/xfs/333
tests/xfs/338
tests/xfs/340
tests/xfs/433
tests/xfs/434
tests/xfs/435
tests/xfs/436
tests/xfs/439
tests/xfs/442
tests/xfs/443