xfstests 223: reinitialize MKFS_OPTIONS
authorBoris Ranto <branto@redhat.com>
Thu, 18 Nov 2010 02:44:57 +0000 (20:44 -0600)
committerEric Sandeen <sandeen@sandeen.net>
Thu, 18 Nov 2010 02:44:57 +0000 (20:44 -0600)
commita9f5ef25fb2e6d66c43441fb0d2277ce62d1d2e3
tree45a435bdfe63c2d6bd06a8a7301e1cb9e50163ae
parent376623749527399ab39d02c6675999541b657fcc
xfstests 223: reinitialize MKFS_OPTIONS

Test case 223 constantly fails because the variable carrying mkfs
options is not being reinitialized.

Test calls function _scratch_mkfs_geom repeatedly in for loop without
cleaning the MKFS_OPTIONS variable. Since _scratch_mkfs_geom only
appends options to the variable, MKFS_OPTIONS looks like this in 5th
iteration:
MKFS_OPTIONS="-bsize=4096-b size=4096 -d su=8192,sw=4-b size=4096 -d
su=16384,sw=4-b size=4096 -d su=32768,sw=4-b size=4096 -d
su=65536,sw=4-b size=4096 -d su=131072,sw=4"

It is also easy to see that _scratch_mkfs_geom does not append leading
space when it appends the variable.

Following patch fixes the issue for me and based on my testing does not
break any other test case:

Signed-off-by: Boris Ranto <branto@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
223
common.rc