generic/108: Fix return value check from _get_scsi_debug_dev
authorNikolay Borisov <nborisov@suse.com>
Thu, 25 May 2017 09:08:46 +0000 (12:08 +0300)
committerEryu Guan <eguan@redhat.com>
Thu, 25 May 2017 09:11:55 +0000 (17:11 +0800)
commitc51ab0a8502e9387f3bdecb53699b422464fd5b1
treeedc6f0b628a9be56af8b61ccfdba87e4fc322477
parentce16ed94a8d9bc9704dfd45751cbdcd8f7488c24
generic/108: Fix return value check from _get_scsi_debug_dev

_get_scsi_debug_dev is supposed to return a "/dev/$device".
However, in case the scsi device is not mapped to a disk, hence
/dev/sd* doesn't exist, then get_scsi_debug_dev would return only
the "/dev/" string. In generic/108 we check whether return value is
"" and only then consider it a failure. This behavior allows the
test to erroneously consider _get_scsi_debug_dev succeeded even if
it returned a malformed string. Fix this by correctly checking
whether the return value is "/dev/"

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
tests/generic/108