new: don't allow new tests in group 'other' master
authorDarrick J. Wong <djwong@kernel.org>
Fri, 17 Sep 2021 00:40:06 +0000 (17:40 -0700)
committerEryu Guan <guaneryu@gmail.com>
Sun, 26 Sep 2021 13:36:20 +0000 (21:36 +0800)
The 'other' group is vaguely defined at best -- other than what?  It's
not clear what tests belong in this group, and it has become a dumping
ground for random stuff that are classified in other groups.  Don't let
people create new other group tests.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
new

diff --git a/new b/new
index 3a657d2..9651e0e 100755 (executable)
--- a/new
+++ b/new
@@ -100,6 +100,9 @@ check_groups() {
                        echo "Invalid characters in group(s): ${inval}"
                        echo "Only lower cases, digits and underscore are allowed in groups, separated by space"
                        return 1
                        echo "Invalid characters in group(s): ${inval}"
                        echo "Only lower cases, digits and underscore are allowed in groups, separated by space"
                        return 1
+               elif [ "${g}" = "other" ]; then
+                       echo "Do not add more tests to group \"other\""
+                       return 1
                elif ! group_names | grep -q -w "${g}"; then
                        echo "Warning: group \"${g}\" not defined in documentation"
                        return 1
                elif ! group_names | grep -q -w "${g}"; then
                        echo "Warning: group \"${g}\" not defined in documentation"
                        return 1
@@ -111,16 +114,16 @@ check_groups() {
 
 if [ $# -eq 0 ]; then
        # interactive mode
 
 if [ $# -eq 0 ]; then
        # interactive mode
-       prompt="Add to group(s) [other] (separate by space, ? for list): "
+       prompt="Add to group(s) [auto] (separate by space, ? for list): "
        while true; do
                read -p "${prompt}" -a new_groups || exit 1
                case "${#new_groups[@]}" in
                0)
        while true; do
                read -p "${prompt}" -a new_groups || exit 1
                case "${#new_groups[@]}" in
                0)
-                       new_groups=("other")
+                       new_groups=("auto")
                        ;;
                1)
                        if [ "${new_groups[0]}" = "?" ]; then
                        ;;
                1)
                        if [ "${new_groups[0]}" = "?" ]; then
-                               echo $(group_names)
+                               echo $(group_names | grep -v -w 'other')
                                continue
                        fi
                        ;;
                                continue
                        fi
                        ;;