fsx: shut up compiler warnings
authorDarrick J. Wong <darrick.wong@oracle.com>
Fri, 7 Dec 2018 06:23:39 +0000 (22:23 -0800)
committerEryu Guan <guaneryu@gmail.com>
Sun, 9 Dec 2018 14:55:23 +0000 (22:55 +0800)
Fix unused variables and potential filename overflows in fsx.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-By: Allison Henderson <allison.henderson@oracle.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
ltp/fsx.c

index b0157ba357b4f90ba5dc9f45e601534b697d076a..5601c70c1b89abe4b43d84ca580df0eee215a7ba 100644 (file)
--- a/ltp/fsx.c
+++ b/ltp/fsx.c
@@ -121,7 +121,7 @@ char        *bname;                         /* basename of our test file */
 char   *logdev;                        /* -i flag */
 char   *logid;                         /* -j flag */
 char   dname[1024];                    /* -P flag */
-char   goodfile[1024];
+char   goodfile[PATH_MAX];
 int    dirpath = 0;                    /* -P flag */
 int    fd;                             /* fd for our test file */
 
@@ -185,7 +185,7 @@ const char *replayops = NULL;
 const char *recordops = NULL;
 FILE * fsxlogf = NULL;
 FILE * replayopsf = NULL;
-char opsfile[1024];
+char opsfile[PATH_MAX];
 int badoff = -1;
 int closeopen = 0;
 
@@ -541,13 +541,13 @@ mark_log(void)
 void
 dump_fsync_buffer(void)
 {
-       char fname_buffer[1024];
+       char fname_buffer[PATH_MAX];
        int good_fd;
 
        if (!good_buf)
                return;
 
-       snprintf(fname_buffer, 1024, "%s%s.mark%d", dname,
+       snprintf(fname_buffer, sizeof(fname_buffer), "%s%s.mark%d", dname,
                 bname, mark_nr);
        good_fd = open(fname_buffer, O_WRONLY|O_CREAT|O_TRUNC, 0666);
        if (good_fd < 0) {
@@ -1865,7 +1865,7 @@ main(int argc, char **argv)
 {
        int     i, style, ch;
        char    *endp, *tmp;
-       char logfile[1024];
+       char logfile[PATH_MAX];
        struct stat statbuf;
        int o_flags = O_RDWR|O_CREAT|O_TRUNC;