xfstests: make 258 more forgiving of timestamp rounding
authorEric Sandeen <sandeen@redhat.com>
Mon, 3 Oct 2011 16:52:33 +0000 (16:52 +0000)
committerAlex Elder <aelder@sgi.com>
Fri, 7 Oct 2011 22:33:55 +0000 (17:33 -0500)
Rather than testing for an exact timestamp, which could vary
due to rounding, just check that it is not positive,
which is the failure case we're looking for.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
258
258.out

diff --git a/258 b/258
index 6fadca0f0c05f84e959d973f93cff6cf003995bc..e0441a54515db6bc37f4c4af08de286211b0afd6 100644 (file)
--- a/258
+++ b/258
@@ -53,8 +53,12 @@ TESTFILE=$TEST_DIR/timestamp-test.txt
 echo "Creating file with timestamp of Jan 1, 1960"
 touch -t 196001010101 $TESTFILE
 # Should yield -315593940 (prior to epoch)
-echo -n "Stat of file yields: "
-stat -c %X $TESTFILE
+echo "Testing for negative seconds since epoch"
+ts=`stat -c %X $TESTFILE`
+if [ "$ts" -ge 0 ]; then
+       echo "Timestamp wrapped: $ts"
+       _fail "Timestamp wrapped"
+fi
 
 # unmount, remount, and check the timestamp
 echo "Remounting to flush cache"
@@ -62,7 +66,11 @@ umount $TEST_DEV
 mount $TEST_DEV $TEST_DIR
 
 # Should yield -315593940 (prior to epoch)
-echo -n "Stat of file yields: "
-stat -c %X $TESTFILE
+echo "Testing for negative seconds since epoch"
+ts=`stat -c %X $TESTFILE`
+if [ "$ts" -ge 0 ]; then
+       echo "Timestamp wrapped: $ts"
+       _fail "Timestamp wrapped"
+fi
 
 status=0 ; exit
diff --git a/258.out b/258.out
index 11b91685c4e21dd29a9fce76a40a07fe971853b6..87fae0ff36bd60f22fad47851b54d15a01b33853 100644 (file)
--- a/258.out
+++ b/258.out
@@ -1,5 +1,5 @@
 QA output created by 258
 Creating file with timestamp of Jan 1, 1960
-Stat of file yields: -315593940
+Testing for negative seconds since epoch
 Remounting to flush cache
-Stat of file yields: -315593940
+Testing for negative seconds since epoch