xfstests: skip dump tests if dump utils not found
authorEric Sandeen <sandeen@sandeen.net>
Mon, 20 Apr 2009 02:11:32 +0000 (21:11 -0500)
committerEric Sandeen <sandeen@sandeen.net>
Mon, 20 Apr 2009 02:11:32 +0000 (21:11 -0500)
I was running xfstests on a NAS box which had no xfsdump,
and any tests which required xfsdump were failing in not-so-nice
ways:

+ xfsdump not found
038      [failed, exit status 1] - output mismatch (see 038.out.bad)

I think using _notrun is a lot better:

038      [not run] xfsdump not found

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Josef 'Jeff' Sipek" <jeffpc@josefsipek.net>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
common.dump

index 6d2f120f20f5a6d841372c646e69c27d1a1c020b..fcc4945a178c132032c169097403c326a2e653e9 100644 (file)
@@ -23,9 +23,9 @@ if [ -n "$DEBUGDUMP" ]; then
        [ -x $here/xfsinvutil ] && echo "Using xfstests' xfsinvutil for debug"
 fi
 
-[ "$XFSDUMP_PROG" = "" ]    && _fatal "xfsdump not found"
-[ "$XFSRESTORE_PROG" = "" ] && _fatal "xfsrestore not found"
-[ "$XFSINVUTIL_PROG" = "" ] && _fatal "xfsinvutil not found"
+[ "$XFSDUMP_PROG" = "" ]    && _notrun "xfsdump not found"
+[ "$XFSRESTORE_PROG" = "" ] && _notrun "xfsrestore not found"
+[ "$XFSINVUTIL_PROG" = "" ] && _notrun "xfsinvutil not found"
 
 # status returned for not run tests
 NOTRUNSTS=2