common/fuzzy: online re-scrub should not preen
authorDarrick J. Wong <darrick.wong@oracle.com>
Fri, 27 Oct 2017 00:43:12 +0000 (17:43 -0700)
committerEryu Guan <eguan@redhat.com>
Fri, 27 Oct 2017 05:55:50 +0000 (13:55 +0800)
When we're doing the second online scrub (to figure out if the
repair did any good) we shouldn't let that second scrub preen the
filesystem in any way. If scrub finds things it can't/won't preen
that turns into a nonzero return code which gets reported
(incorrectly) as a failure.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
common/fuzzy

index 8453c29fc9e36097ce72c5a10d04893ba813a3c2..86492687bfe55cbae4589613a5bf04a5d9579945 100644 (file)
@@ -274,7 +274,7 @@ __scratch_xfs_fuzz_field_test() {
                # which scrub doesn't know how to fix.
                echo "++ Online scrub"
                if [ "$1" != "sb 0" ]; then
-                       _scratch_scrub -e continue 2>&1
+                       _scratch_scrub -n -e continue 2>&1
                        res=$?
                        test $res -ne 0 && \
                                (>&2 echo "online re-scrub ($res) with ${field} = ${fuzzverb}.")