generic/631: remove useless nfs_export=off
authorYang Xu <xuyang2018.jy@fujitsu.com>
Mon, 26 Apr 2021 07:57:03 +0000 (15:57 +0800)
committerEryu Guan <guaneryu@gmail.com>
Sun, 9 May 2021 13:50:22 +0000 (21:50 +0800)
The nfs_export feature was introduced since kernel v4.16-rc1 after
commit f168f1098dd9038 ("ovl: add support for "nfs_export"
configuration").  On old kernel, this case will result in infinite
loop because overlay mount failed because of unrecognized mount
options nfs_export=off.

In kernel documentation, overlay.rst said "the mount options
index=off,nfs_export=on are conflicting for a read-write mount and
will result in an error.".  So using single index=off is also ok in
here.

Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
tests/generic/631

index c43f3de..0fa47e4 100755 (executable)
@@ -74,7 +74,7 @@ worker() {
        local l="lowerdir=$SCRATCH_MNT/lowerdir:$SCRATCH_MNT/lowerdir1"
        local u="upperdir=$SCRATCH_MNT/upperdir$tag"
        local w="workdir=$SCRATCH_MNT/workdir$tag"
        local l="lowerdir=$SCRATCH_MNT/lowerdir:$SCRATCH_MNT/lowerdir1"
        local u="upperdir=$SCRATCH_MNT/upperdir$tag"
        local w="workdir=$SCRATCH_MNT/workdir$tag"
-       local i="index=off,nfs_export=off"
+       local i="index=off"
 
        touch $SCRATCH_MNT/workers/$tag
        while test -e $SCRATCH_MNT/running; do
 
        touch $SCRATCH_MNT/workers/$tag
        while test -e $SCRATCH_MNT/running; do