xfstests: make 223 use more compatible indirection operator
authorAlain Renaud <arenaud@sgi.com>
Fri, 1 Oct 2010 13:09:33 +0000 (13:09 +0000)
committerAlex Elder <aelder@sgi.com>
Fri, 1 Oct 2010 20:58:27 +0000 (15:58 -0500)
Hello all,

I notice while running xfstests on SLES machine that the test 223 fail
because of syntax error.

# bash 223
QA output created by 223
223: line 66: syntax error near unexpected token `>'
223: line 66: `    _scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE&>>  $seq.full'

The error is due to the use of the '&>>' operator for redirection
that does not work  on older bash version(3.2.x).  Note that this
operator only seem to work with bash version 4.X+

This patch simply replace the operator with '>>  $seq.full 2>&1'
which does the same thing.

Signed-off-by: Alain Renaud <arenaud@sgi.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
223

diff --git a/223 b/223
index 7af026cbc2077e0d31d9049d0ac0620392f7f596..8f8696be2f064c9dc9b99c2fdeb8f30736fa95b7 100755 (executable)
--- a/223
+++ b/223
@@ -63,7 +63,7 @@ for SUNIT_K in 8 16 32 64 128; do
        let SUNIT_BLOCKS=$SUNIT_BYTES/$BLOCKSIZE
 
        echo "=== mkfs with su $SUNIT_BLOCKS blocks x 4 ==="
-       _scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE &>> $seq.full
+       _scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE >> $seq.full 2>&1
        _scratch_mount
 
        for SIZE_MULT in 1 2 8 64 256; do
@@ -73,10 +73,10 @@ for SUNIT_K in 8 16 32 64 128; do
                for FILE in 1 2 3 4; do
                        xfs_io -F -f -c "falloc 0 $SIZE" \
                                $SCRATCH_MNT/file-$FILE-$SIZE-falloc \
-                                       &>> $seq.full
+                                       >> $seq.full 2>&1
                        xfs_io -F -f -c "pwrite 0 $SIZE" \
                                $SCRATCH_MNT/file-$FILE-$SIZE-write \
-                                       &>> $seq.full
+                                       >> $seq.full 2>&1
                        src/t_stripealign $SCRATCH_MNT/file-$FILE-$SIZE-falloc \
                                $SUNIT_BLOCKS | _filter_scratch
                        src/t_stripealign $SCRATCH_MNT/file-$FILE-$SIZE-write \
@@ -85,7 +85,8 @@ for SUNIT_K in 8 16 32 64 128; do
        done
 
        echo "=== Testing size 1g falloc on ${SUNIT_K}k stripe ==="
-       xfs_io -F -f -c "falloc 0 1g" $SCRATCH_MNT/file-1g-falloc &>> $seq.full
+       xfs_io -F -f -c "falloc 0 1g" \
+           $SCRATCH_MNT/file-1g-falloc >> $seq.full 2>&1
        src/t_stripealign $SCRATCH_MNT/file-1g-falloc $SUNIT_BLOCKS \
            | _filter_scratch
 
@@ -93,7 +94,7 @@ for SUNIT_K in 8 16 32 64 128; do
 
        echo "=== Testing size 1073745920 falloc on ${SUNIT_K}k stripe ==="
        xfs_io -F -f -c "falloc 0 1073745920" \
-               $SCRATCH_MNT/file-1073745920-falloc &>> $seq.full
+               $SCRATCH_MNT/file-1073745920-falloc >> $seq.full 2>&1
        src/t_stripealign $SCRATCH_MNT/file-1073745920-falloc \
                $SUNIT_BLOCKS | _filter_scratch