xfstests: don't assume that falloc_punch implies falloc in test 255
authorTheodore Ts'o <tytso@mit.edu>
Tue, 5 Mar 2013 17:59:42 +0000 (17:59 +0000)
committerRich Johnston <rjohnston@sgi.com>
Tue, 5 Mar 2013 19:02:27 +0000 (13:02 -0600)
As of Linux 3.9-rc1, ext4 will support the punch operation on file
systems using indirect blocks, but it can not support the fallocate
operation (since there is no way to mark a block as uninitialized
using indirect block scheme).  This caused test 255 to fail, since it
only used _require_xfS_io_falloc_punch assuming that all file systems
which supported punch can also support fallocate.  Fix this.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
255

diff --git a/255 b/255
index 008396316963c25236812dd71db038b6b212deca..ae1d8e05580f614dca3f8ac11821ef0aa8ff1092 100755 (executable)
--- a/255
+++ b/255
@@ -48,6 +48,7 @@ _supported_fs generic
 _supported_os Linux
 
 _require_xfs_io_falloc_punch
+_require_xfs_io_falloc
 _require_xfs_io_fiemap
 
 testfile=$TEST_DIR/255.$$