257: check getdents64() for duplicates

The test checks if no duplicate d_off values are returned and that
those values are seekable to the right inodes.

[Fixed typo "histoty" -> "history". -Alex]

Signed-off-by: Gražvydas Ignotas <notasas@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>

diff --git a/257 b/257
new file mode 100644 (file)
index 0000000..fb81e07
--- /dev/null
+++ b/257
@@ -0,0 +1,56 @@
+#! /bin/bash
+#
+# Check that no duplicate d_off values are returned and that those
+# values are seekable. Most work is done by the C program here.
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2011 Gražvydas Ignotas
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+# creator
+owner=notasas@gmail.com
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1       # failure is the default!
+
+_cleanup()
+{
+       rm -rf $TEST_DIR/ttt
+}
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common.rc
+. ./common.filter
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+
+mkdir $TEST_DIR/ttt
+for n in {1..168}; do
+    touch $TEST_DIR/ttt/$n;
+done
+src/t_dir_offset2 $TEST_DIR/ttt
+
+# success, all done
+echo "*** done"
+rm -f $seq.full
+status=0

diff --git a/257.out b/257.out
new file mode 100644 (file)
index 0000000..ac232ec
--- /dev/null
+++ b/257.out
@@ -0,0 +1,2 @@
+QA output created by 257
+*** done

diff --git a/group b/group
index 0c746c86fbb865ac7aa36a89802cfa4a7d3cb115..a7424956f261d502246bed8a3b628bb310284217 100644 (file)
--- a/group
+++ b/group
@@ -370,3 +370,4 @@ deprecated
 254 auto quick
 255 auto quick prealloc
 256 auto quick
+257 dir auto quick

diff --git a/src/Makefile b/src/Makefile
index 91088bf4cabb7710d0eb99b8bb61710b7663def4..67250ee53062314214ac90279b2c50cfcb284dff 100644 (file)
--- a/src/Makefile
+++ b/src/Makefile
@@ -17,7 +17,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
        preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
        locktest unwritten_mmap bulkstat_unlink_test t_stripealign \
        bulkstat_unlink_test_modified t_dir_offset t_futimens t_immutable \
-       stale_handle pwrite_mmap_blocked fstrim
+       stale_handle pwrite_mmap_blocked fstrim t_dir_offset2
 
 SUBDIRS =
 

diff --git a/src/t_dir_offset2.c b/src/t_dir_offset2.c
new file mode 100644 (file)
index 0000000..4792e10
--- /dev/null
+++ b/src/t_dir_offset2.c
@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) 2011 Gražvydas Ignotas
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it would be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write the Free Software Foundation,
+ * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+/*
+ * This test checks if no duplicate d_off values are returned and
+ * that these offsets are seekable to entry with the right inode.
+ */
+
+#include <fcntl.h>
+#include <stdio.h>
+#include <unistd.h>
+#include <stdint.h>
+#include <stdlib.h>
+#include <sys/stat.h>
+#include <sys/syscall.h>
+
+struct linux_dirent64 {
+       uint64_t        d_ino;
+       uint64_t        d_off;
+       unsigned short  d_reclen;
+       unsigned char   d_type;
+       char            d_name[0];
+};
+
+#define BUF_SIZE 4096
+#define HISTORY_LEN 1024
+
+static uint64_t d_off_history[HISTORY_LEN];
+static uint64_t d_ino_history[HISTORY_LEN];
+
+int
+main(int argc, char *argv[])
+{
+       int fd, nread;
+       char buf[BUF_SIZE];
+       struct linux_dirent64 *d;
+       int bpos, total, i;
+       off_t lret;
+       int retval = EXIT_SUCCESS;
+
+       fd = open(argv[1], O_RDONLY | O_DIRECTORY);
+       if (fd < 0) {
+               perror("open");
+               exit(EXIT_FAILURE);
+       }
+
+       total = 0;
+       for ( ; ; ) {
+               nread = syscall(SYS_getdents64, fd, buf, BUF_SIZE);
+               if (nread == -1) {
+                       perror("getdents");
+                       exit(EXIT_FAILURE);
+               }
+
+               if (nread == 0)
+                       break;
+
+               for (bpos = 0; bpos < nread; total++) {
+                       d = (struct linux_dirent64 *) (buf + bpos);
+
+                       if (total >= HISTORY_LEN) {
+                               fprintf(stderr, "too many files\n");
+                               break;
+                       }
+
+                       for (i = 0; i < total; i++)
+                       {
+                               if (d_off_history[i] == d->d_off) {
+                                       fprintf(stderr, "entries %d and %d have duplicate d_off %lld\n",
+                                               i, total, (long long int)d->d_off);
+                                       retval = EXIT_FAILURE;
+                               }
+                       }
+                       d_off_history[total] = d->d_off;
+                       d_ino_history[total] = d->d_ino;
+                       bpos += d->d_reclen;
+               }
+       }
+
+       /* check if seek works correctly */
+       d = (struct linux_dirent64 *)buf;
+       for (i = total - 1; i >= 0; i--)
+       {
+               lret = lseek(fd, i > 0 ? d_off_history[i - 1] : 0, SEEK_SET);
+               if (lret == -1) {
+                       perror("lseek");
+                       exit(EXIT_FAILURE);
+               }
+
+               nread = syscall(SYS_getdents64, fd, buf, BUF_SIZE);
+               if (nread == -1) {
+                       perror("getdents");
+                       exit(EXIT_FAILURE);
+               }
+
+               if (nread == 0) {
+                       fprintf(stderr, "getdents returned 0 on entry %d\n", i);
+                       retval = EXIT_FAILURE;
+               }
+
+               if (d->d_ino != d_ino_history[i]) {
+                       fprintf(stderr, "entry %d has inode %lld, expected %lld\n",
+                               i, (long long int)d->d_ino, (long long int)d_ino_history[i]);
+                       retval = EXIT_FAILURE;
+               }
+       }
+
+       close(fd);
+       exit(retval);
+}