fsstress: fix incorrect if condition check for collapse range mode
authorNamjae Jeon <namjae.jeon@samsung.com>
Tue, 13 May 2014 05:26:59 +0000 (15:26 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 13 May 2014 05:26:59 +0000 (15:26 +1000)
There is if condition to be block aligned for off and len of Collapse range.
But off and len for all fallocate opearion can be aligned by incorrect
if condition check.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
ltp/fsstress.c

index 29fc250d1e4c4877ad239aca03aa50c8766da4c6..b56fe5c6a1044cca8c249175c4ad15ad72f969b6 100644 (file)
@@ -2230,7 +2230,7 @@ do_fallocate(int opno, long r, int mode)
         * Collapse range requires off and len to be block aligned, make it
         * more likely to be the case.
         */
-       if (FALLOC_FL_COLLAPSE_RANGE && (opno % 2)) {
+       if ((mode & FALLOC_FL_COLLAPSE_RANGE) && (opno % 2)) {
                off = ((off + stb.st_blksize - 1) & ~(stb.st_blksize - 1));
                len = ((len + stb.st_blksize - 1) & ~(stb.st_blksize - 1));
        }