config: make sure tests check for loop device support

Several tests happen to make use of loop device support without the
requisite pre-test checks. This results in spurious failures for systems
that might not have loop device support. Add _require_loop checks to
shared/298, xfs/206 and xfs/259.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

diff --git a/tests/shared/298 b/tests/shared/298
index f13c14b3fd14ae599f7d2afd4da29a4e968f3e61..8211da39d8c603edd571e553d2a07f911e626a22 100755 (executable)
--- a/tests/shared/298
+++ b/tests/shared/298
@@ -32,6 +32,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 
 _supported_fs ext4 xfs
 _supported_os Linux
 
 _supported_fs ext4 xfs
 _supported_os Linux

+_require_loop

 _require_fstrim
 _require_xfs_io_command "fiemap"
 _require_fs_space $TEST_DIR 307200
 _require_fstrim
 _require_xfs_io_command "fiemap"
 _require_fs_space $TEST_DIR 307200

diff --git a/tests/xfs/206 b/tests/xfs/206
index 0bbd5953e84a6d96cef0107db17f9e452b4905b6..f739597fb5745cee76dbf7da0b9ff842f2fd5e11 100755 (executable)
--- a/tests/xfs/206
+++ b/tests/xfs/206
@@ -53,6 +53,7 @@ _cleanup()
 # Modify as appropriate.
 _supported_fs xfs
 _supported_os IRIX Linux
 # Modify as appropriate.
 _supported_fs xfs
 _supported_os IRIX Linux

+_require_loop

 
 bitsperlong=`src/feature -w`
 if [ "$bitsperlong" -ne 64 ]; then
 
 bitsperlong=`src/feature -w`
 if [ "$bitsperlong" -ne 64 ]; then

diff --git a/tests/xfs/259 b/tests/xfs/259
index b8bd69a22eb483d71c9f1c51a811537270bd96a8..8241d94dbb30276f3052ccb7aac5a387d16c1efa 100755 (executable)
--- a/tests/xfs/259
+++ b/tests/xfs/259
@@ -41,7 +41,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15
 # real QA test starts here
 _supported_fs xfs
 _supported_os Linux
 # real QA test starts here
 _supported_fs xfs
 _supported_os Linux

-
+_require_loop

 _require_math
 
 testfile=$TEST_DIR/259.image
 _require_math
 
 testfile=$TEST_DIR/259.image