btrfs: Add a test for leaking root crash at unmount time
authorQu Wenruo <wqu@suse.com>
Wed, 20 May 2020 11:44:42 +0000 (19:44 +0800)
committerEryu Guan <guaneryu@gmail.com>
Sun, 24 May 2020 16:12:27 +0000 (00:12 +0800)
Test if canceled balance could lead to root leakage.
If the kernel has CONFIG_BTRFS_DEBUG compiled, unmount time root leakge
check would detect it, and cause NULL pointer dereference as the pages
of the leaked root are already freed.

The fix is titled "btrfs: relocation: Fix reloc root leakage and the NULL
 pointer reference caused by the leakage".

Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
tests/btrfs/212 [new file with mode: 0755]
tests/btrfs/212.out [new file with mode: 0644]
tests/btrfs/group

diff --git a/tests/btrfs/212 b/tests/btrfs/212
new file mode 100755 (executable)
index 0000000..36e6322
--- /dev/null
@@ -0,0 +1,85 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2020 SUSE Linux Products GmbH. All Rights Reserved.
+#
+# FS QA Test 212
+#
+# Test if unmounting a fs with balance canceled can lead to crash.
+# This needs CONFIG_BTRFS_DEBUG compiled, which adds extra unmount time self-test
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1       # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+       cd /
+       rm -f $tmp.*
+       kill $balance_pid &> /dev/null
+       kill $cancel_pid &> /dev/null
+       "$KILLALL_PROG" -q $FSSTRESS_PROG &> /dev/null
+       $BTRFS_UTIL_PROG balance cancel $SCRATCH_MNT &> /dev/null
+       wait
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+# real QA test starts here
+
+# Modify as appropriate.
+_supported_fs btrfs
+_supported_os Linux
+_require_scratch
+_require_command "$KILLALL_PROG" killall
+
+_scratch_mkfs >> $seqres.full
+_scratch_mount
+
+runtime=15
+
+balance_workload()
+{
+       trap "wait; exit" SIGTERM
+       while true; do
+               _run_btrfs_balance_start &> /dev/null
+       done
+}
+
+cancel_workload()
+{
+       trap "wait; exit" SIGTERM
+       while true; do
+               $BTRFS_UTIL_PROG balance cancel $SCRATCH_MNT &> /dev/null
+               sleep 2
+       done
+}
+
+$FSSTRESS_PROG -d $SCRATCH_MNT -w -n 100000  >> $seqres.full 2>/dev/null &
+balance_workload &
+balance_pid=$!
+
+cancel_workload &
+cancel_pid=$!
+
+sleep $runtime
+
+kill $balance_pid
+kill $cancel_pid
+"$KILLALL_PROG" -q $FSSTRESS_PROG &> /dev/null
+$BTRFS_UTIL_PROG balance cancel $SCRATCH_MNT &> /dev/null
+wait
+
+echo "Silence is golden"
+# success, all done
+status=0
+exit
diff --git a/tests/btrfs/212.out b/tests/btrfs/212.out
new file mode 100644 (file)
index 0000000..32d1139
--- /dev/null
@@ -0,0 +1,2 @@
+QA output created by 212
+Silence is golden
index 66b1beacfd7e5ff5e9a119796c1ce45bba181b41..8d65bddd92e460bf1f953c3cf96381ac9bcfdc1c 100644 (file)
 209 auto quick log
 210 auto quick qgroup snapshot
 211 auto quick log prealloc
+212 auto balance dangerous