generic/520: Remove sync in clean_dir
authorYang Xu <xuyang2018.jy@cn.fujitsu.com>
Mon, 23 Dec 2019 10:21:39 +0000 (18:21 +0800)
committerEryu Guan <guaneryu@gmail.com>
Sun, 2 Feb 2020 12:46:58 +0000 (20:46 +0800)
When I test this case on xfs, it may fail as below:
--------------------------------------------
 === link SCRATCH_MNT/A/foo SCRATCH_MNT/bar  with fsync SCRATCH_MNT/A ===
+umount: /mnt/xfstests/scratch: target is busy.
+        (In some cases useful info about processes that use
+         the device is found by lsof(8) or fuser(1))
---------------------------------------------

It fails because somethings is still using the fs when we call sync and then
try to unmount it. We can simply remove sync as the unmount is supposed to
persist the file/directory removals.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
tests/generic/520

index 167d707759dbb5c5935ed8f960740b6c7722786e..d44573705f102c96c36355995453543699df997c 100755 (executable)
@@ -58,7 +58,6 @@ clean_dir()
 {
        _mount_flakey
        rm -rf $(find $SCRATCH_MNT/* | grep -v "lost+found")
 {
        _mount_flakey
        rm -rf $(find $SCRATCH_MNT/* | grep -v "lost+found")
-       sync
        _unmount_flakey
 }
 
        _unmount_flakey
 }