From: Luis R. Rodriguez Date: Wed, 27 Jun 2018 16:03:55 +0000 (-0700) Subject: build: fix install target using sudo X-Git-Tag: v2022.05.01~1470 X-Git-Url: http://git.apps.os.sepia.ceph.com/?p=xfstests-dev.git;a=commitdiff_plain;h=103258a566b41aeea128597f244f408ab99e0612 build: fix install target using sudo If you install with: sudo make install Depending on the system, you may see that /var/lib/xfstests/ installed properly but /var/lib/xfstests/tests/ is empty and so your install really is broken and not functional. Finding out what went wrong is not obvious. The issue is caused due to the fact that $(PWD) is used nad if sudo is used this can be empty on some systems. PWD is only used on one target on the xfstests build system, the tests/*/ dir install target. We can fix this by using $(CURDIR) instead. This issue is observed on both Fedora and OpenSUSE, but not on Debian. Signed-off-by: Luis R. Rodriguez Suggested-by: Dave Chinner Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- diff --git a/tests/Makefile b/tests/Makefile index 2611b3b8..11164e9e 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -5,7 +5,7 @@ TOPDIR = .. include $(TOPDIR)/include/builddefs -TESTS_SUBDIRS = $(sort $(dir $(wildcard $(PWD)/$(TESTS_DIR)/[a-z]*/))) +TESTS_SUBDIRS = $(sort $(dir $(wildcard $(CURDIR)/[a-z]*/))) include $(BUILDRULES)