From: Yang Xu Date: Mon, 26 Apr 2021 07:57:03 +0000 (+0800) Subject: generic/631: remove useless nfs_export=off X-Git-Tag: v2022.05.01~436 X-Git-Url: http://git.apps.os.sepia.ceph.com/?p=xfstests-dev.git;a=commitdiff_plain;h=6be48523d41bb62ff48a7ad7da274393632de785;ds=sidebyside generic/631: remove useless nfs_export=off The nfs_export feature was introduced since kernel v4.16-rc1 after commit f168f1098dd9038 ("ovl: add support for "nfs_export" configuration"). On old kernel, this case will result in infinite loop because overlay mount failed because of unrecognized mount options nfs_export=off. In kernel documentation, overlay.rst said "the mount options index=off,nfs_export=on are conflicting for a read-write mount and will result in an error.". So using single index=off is also ok in here. Signed-off-by: Yang Xu Reviewed-by: Amir Goldstein Signed-off-by: Eryu Guan --- diff --git a/tests/generic/631 b/tests/generic/631 index c43f3de3..0fa47e49 100755 --- a/tests/generic/631 +++ b/tests/generic/631 @@ -74,7 +74,7 @@ worker() { local l="lowerdir=$SCRATCH_MNT/lowerdir:$SCRATCH_MNT/lowerdir1" local u="upperdir=$SCRATCH_MNT/upperdir$tag" local w="workdir=$SCRATCH_MNT/workdir$tag" - local i="index=off,nfs_export=off" + local i="index=off" touch $SCRATCH_MNT/workers/$tag while test -e $SCRATCH_MNT/running; do