From: Zorro Lang Date: Thu, 19 Jul 2018 10:03:49 +0000 (+0800) Subject: build: replace lowercase letters regex with POSIX character class in Makefile X-Git-Tag: v2022.05.01~1449 X-Git-Url: http://git.apps.os.sepia.ceph.com/?p=xfstests-dev.git;a=commitdiff_plain;h=b29b8b077e0502c9595de5dd605f836d3fd80453 build: replace lowercase letters regex with POSIX character class in Makefile Latest glibc changed some rules of sorting and regexes, the usage likes "[a-z]" maybe not only stand for lowcase letters a..z in different locale. Similar issues include [A-Z], [0-9] and so on. For example, in en_US.UTF-8 locale, [a-z] means aAbBcCdD...zZ, it stands for both of uppercase and lowercase. Currently this issue cause `make install` fails on system with new glibc. So use POSIX character class to instead of [...] group, something likes [:lower:], [:upper:], [:alpha:], [:alnum:], etc... are common. Signed-off-by: Zorro Lang Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- diff --git a/tests/Makefile b/tests/Makefile index 11164e9e..8ce8f209 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -5,7 +5,7 @@ TOPDIR = .. include $(TOPDIR)/include/builddefs -TESTS_SUBDIRS = $(sort $(dir $(wildcard $(CURDIR)/[a-z]*/))) +TESTS_SUBDIRS = $(sort $(dir $(wildcard $(CURDIR)/[[:lower:]]*/))) include $(BUILDRULES)