From: J. Bruce Fields Date: Thu, 19 Dec 2019 22:33:36 +0000 (-0500) Subject: generic/529: use an ACL that doesn't confuse NFS X-Git-Tag: v2022.05.01~908 X-Git-Url: http://git.apps.os.sepia.ceph.com/?p=xfstests-dev.git;a=commitdiff_plain;h=dda94e8088a7a1b3f36a7694a6fa156ca8605dcc generic/529: use an ACL that doesn't confuse NFS For historical reasons having to do with Solaris ACL behavior, the Linux client treats an ACL like the one used as an example here as equivalent to a mode, causing listxattr to report that no ACL is set on the file. (See the comment at the top of fs/nfs_common/nfsacl.c in the kernel source for details, and the "bogus ACL_MASK entry" comment in the same source file.) This causes a spurious generic/529 failure on NFS. As far as I can tell any ACL should trigger the original XFS problem. So, modify it so as not to hit this odd NFS corner case. Signed-off-by: J. Bruce Fields Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- diff --git a/src/t_attr_corruption.c b/src/t_attr_corruption.c index e7d435b1..b5513d44 100644 --- a/src/t_attr_corruption.c +++ b/src/t_attr_corruption.c @@ -59,7 +59,7 @@ int main(int argc, char *argv[]) .e = { {htole16(1), 0, 0}, {htole16(4), 0, 0}, - {htole16(0x10), 0, 0}, + {htole16(0x10), htole16(4), 0}, {htole16(0x20), 0, 0}, }, };