xfstests-dev.git
13 years agofsx: Replace use of bcmp() with memcmp()
Theodore Ts'o [Wed, 13 May 2009 20:52:23 +0000 (15:52 -0500)]
fsx: Replace use of bcmp() with memcmp()
The bcmp() function comes from BSD 4.3, and was deprecated in
POSIX.1-2001.  It was removed entirely in POSIX.1-2008.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agofsx: Replace use of bzero() with memset()
Theodore Ts'o [Wed, 13 May 2009 18:31:46 +0000 (13:31 -0500)]
fsx: Replace use of bzero() with memset()
The bzero() function comes from BSD 4.3, and was deprecated in
POSIX.1-2001.  It was removed entirely in POSIX.1-2008.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agofsx: Use %ll instead of %q in printf format statements
Theodore Ts'o [Wed, 13 May 2009 18:31:46 +0000 (13:31 -0500)]
fsx: Use %ll instead of %q in printf format statements
The ISO C approved way of printing long long variables is %ll.  The %q
length modifier was used in BSD 4.4 and Linux libc5, and its use is
discouraged as non-standards compliant.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agofsx: Use SEEK_END instead of the BSD'ish L_XTND
Theodore Ts'o [Wed, 13 May 2009 18:31:47 +0000 (13:31 -0500)]
fsx: Use SEEK_END instead of the BSD'ish L_XTND
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoxfstests: tidy up 205
Eric Sandeen [Sun, 10 May 2009 15:42:09 +0000 (10:42 -0500)]
xfstests: tidy up 205

Test 205 wasn't marked executable, and had the wrong test
number in the comments.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
13 years agoxfstests 042: point xfs_fsr right at the fragmented file
Eric Sandeen [Sat, 9 May 2009 03:03:40 +0000 (22:03 -0500)]
xfstests 042: point xfs_fsr right at the fragmented file

Somehow 042 as it stands isn't actually defragging the fragmented
file we created (see 042.full post-run)

Probably need to look into that as well, but for now this should
make the call to fsr actually _do_ something.

This has let 2 fsr bugs slip through qa in the past few months.   :(

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
13 years agoxfstests: fix 130, 132 for inifinitely-fast disks
Eric Sandeen [Fri, 24 Apr 2009 18:57:55 +0000 (13:57 -0500)]
xfstests: fix 130, 132 for inifinitely-fast disks

Due to the new quantum/holographic storage I'm testing, my
disks go infinitely fast, thereby breaking some filters:

-XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+3 KiB, 1 ops; 0.0000 sec (inf EiB/sec and inf ops/sec)

I'm no regexp expert but I think the below change will fix it.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
13 years agoRevert "patch more_set_prog_path"
Eric Sandeen [Thu, 23 Apr 2009 17:42:32 +0000 (12:42 -0500)]
Revert "patch more_set_prog_path"

This reverts commit b2fcff900de26dd0b742d2e77fbfc6b8dc13c83e.

This snuck in unintentionally due to my weak git-fu,
and was breaking things.

13 years agoxfstests: filter out imaxpct value in test 096
Eric Sandeen [Thu, 23 Apr 2009 17:33:03 +0000 (12:33 -0500)]
xfstests: filter out imaxpct value in test 096

On large filesystems, imaxpc drops from 25 to 5,
so filter out that difference.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoxfstests: skip fsr tests if xfs_fsr utils not found
Eric Sandeen [Mon, 20 Apr 2009 02:10:42 +0000 (21:10 -0500)]
xfstests: skip fsr tests if xfs_fsr utils not found

Similar to the xfsdump-related patch; gracefully fail
if no xfs_fsr is found.

I'll probably send another for the acl & attr userspace,
it's actually not always installed on minimal boxes.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
13 years agoxfstests: skip dump tests if dump utils not found
Eric Sandeen [Mon, 20 Apr 2009 02:11:32 +0000 (21:11 -0500)]
xfstests: skip dump tests if dump utils not found

I was running xfstests on a NAS box which had no xfsdump,
and any tests which required xfsdump were failing in not-so-nice
ways:

+ xfsdump not found
038      [failed, exit status 1] - output mismatch (see 038.out.bad)

I think using _notrun is a lot better:

038      [not run] xfsdump not found

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Josef 'Jeff' Sipek" <jeffpc@josefsipek.net>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
13 years agoMerge branch 'master' of git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev
Eric Sandeen [Sun, 19 Apr 2009 20:48:54 +0000 (15:48 -0500)]
Merge branch 'master' of git://git./fs/xfs/xfstests-dev

13 years agopatch more_set_prog_path
Eric Sandeen [Sun, 19 Apr 2009 20:48:48 +0000 (15:48 -0500)]
patch more_set_prog_path

13 years agoMerge branch 'master' of git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev
Felix Blyakher [Mon, 13 Apr 2009 21:47:23 +0000 (16:47 -0500)]
Merge branch 'master' of git://git./fs/xfs/xfstests-dev

13 years agoxfstests: fix async io error handling in fsx
Felix Blyakher [Mon, 6 Apr 2009 15:18:34 +0000 (10:18 -0500)]
xfstests: fix async io error handling in fsx

The result of async io returned in the event.res in addition
to the number of bytes read/written provides negated error
number. The broken libaio defines event.res as unsigned
while the same structure in the kernel defines it as signed.
The kernel indeed treats it as signed, and returns the
negated error number. Till libaio is fixed we provide
the signed long temp var.
Also set errno for each error condition in aio_rw, as the
caller is not aio aware and expects ret(-1)+errno by the
traditional libc convention.

Signed-off-by: Felix Blyakher <felixb@sgi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoxfstests: test 205, test writing to ENOSPC
Dave Chinner [Mon, 13 Apr 2009 13:55:41 +0000 (15:55 +0200)]
xfstests: test 205, test writing to ENOSPC

Use larger files and different writing styles to fill a 100MB filesystem
to being full. In each case we should get very close to the filesystem
being full before getting ENOSPC. This tests different types of ENOSPC
failures to test 203 and requires more changes to pass.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agoxfstests: add test 204, a simple delayed allocation ENOSPC test
Dave Chinner [Mon, 13 Apr 2009 13:51:58 +0000 (15:51 +0200)]
xfstests: add test 204, a simple delayed allocation ENOSPC test

Using a small (100MB) filesystem and writing lots of single block files
can result in spurious ENOSPCs being reported. Reproduce this test case
so we can confirm that it gets fixed.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agoxfstests: Add a .gitignore file
Josef 'Jeff' Sipek [Mon, 13 Apr 2009 13:49:04 +0000 (15:49 +0200)]
xfstests: Add a .gitignore file

Ignore generated files.

Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
Signed-off-by: Josef 'Jeff' Sipek <jsipek@eecs.umich.edu>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
13 years agoxfstests: make the mode consistent for all the test scripts
Josef 'Jeff' Sipek [Mon, 13 Apr 2009 13:45:41 +0000 (15:45 +0200)]
xfstests: make the mode consistent for all the test scripts

Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
Signed-off-by: Josef 'Jeff' Sipek <jsipek@eecs.umich.edu>
Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agoreduce the number of processes forked
Dave Chinner [Wed, 25 Mar 2009 19:53:36 +0000 (20:53 +0100)]
reduce the number of processes forked

One of the big cpu time consumers when running xfsqa on UML
is forking of new processes. when looping lots of times,
using 'expr' to calculate the loop counter increment means
we fork at least once every loop. using shell builtins means
that we don't fork and many tests run substantially faster.

Some tests are even runnable with this modification. e.g. 110
went from taking 4500s to run down to 9s with the loop iterators
changed to avoid forking.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agoadd test 203, xfs_io bmap reallocation
Christoph Hellwig [Sat, 21 Mar 2009 20:05:51 +0000 (21:05 +0100)]
add test 203, xfs_io bmap reallocation

Test that we can get all extent/hole information for files with more
than 16 extents and 15 holes which require a reallocation based on
XFS_IOC_FSGETXATTR.

Based on a testcase from Tomasz Majkowski <moosh009@gmail.com>.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoxfstests: a couple of fixes for external logs
Christoph Hellwig [Sat, 21 Mar 2009 20:04:13 +0000 (21:04 +0100)]
xfstests: a couple of fixes for external logs

Fix a couple of issues when running xfsqa with external logs:

 - update the 096 golden output for the external log case
 - add a new _scratch_xfs_check similar to _scratch_xfs_logprint and
   _scratch_xfs_repair that take the log device into account and use it
   in test 134
 - use _scratch_xfs_repair in test 202 to fix it for external log
   devices

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoadd "quick" group
Christoph Hellwig [Mon, 23 Feb 2009 13:28:06 +0000 (14:28 +0100)]
add "quick" group

Add a new group for test to quickly verify WIP patches.  I've started
it by only taking tests fro mthe auto group that take 20 seconds or less
to complete on the kvm virtual machine on my laptop.  The total run
of the quick group takes about 8 minutes for me.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agotest 134 requires quotas
Christoph Hellwig [Fri, 20 Feb 2009 20:54:56 +0000 (21:54 +0100)]
test 134 requires quotas

Add a  _require_quota call to make sure it shows up as not run and not
as failed if the kernel doesn't support quotas.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoremove tests 171, 172 and 173 from auto group
Christoph Hellwig [Fri, 20 Feb 2009 20:53:02 +0000 (21:53 +0100)]
remove tests 171, 172 and 173 from auto group

I don't have a single machine where these succeed, and due to the wait
the filestreams allocator works these tests might depend on the phase
on the moon to get their expected output.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agotest 199: test features2 fixup for the regular case, too
Christoph Hellwig [Sun, 15 Feb 2009 18:18:47 +0000 (19:18 +0100)]
test 199: test features2 fixup for the regular case, too

Eric Sandeen noted that we should not only test the mount ro first, then
remount rw case in 199 but also the regular mount rw case.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agotest 201: fix comment typos
Christoph Hellwig [Sun, 15 Feb 2009 18:17:21 +0000 (19:17 +0100)]
test 201: fix comment typos

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoxfstests: Fix *FLAGS passing and dependencies.
Arkadiusz Miśkiewicz [Mon, 2 Feb 2009 20:20:02 +0000 (14:20 -0600)]
xfstests: Fix *FLAGS passing and dependencies.

Pass *FLAGS in some targets.

Drop LIBHANDLE, LIBATTR and LIBACL from deps since there are in form
"-llibrary".

Signed-off-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoUse explict libtool CC tag
Arkadiusz Miśkiewicz [Sun, 1 Feb 2009 22:10:50 +0000 (16:10 -0600)]
Use explict libtool CC tag

(sometimes libtool can't decide what tag is correct one
if omited).

Preserve CFLAGS/CPPFLAGS to allow:
CPPFLAGS="-I$HOME/here-is-xfsprogs-installed/include" \
LDFLAGS="-L$HOME/here-is-xfsprogs-installed/lib" \
./configure  ...

Signed-off-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoadd test 202, xfs_repair handling of single-AG filesystems
Christoph Hellwig [Sun, 25 Jan 2009 20:31:16 +0000 (21:31 +0100)]
add test 202, xfs_repair handling of single-AG filesystems

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agofix 122 for removed btree types
Christoph Hellwig [Sun, 25 Jan 2009 20:30:07 +0000 (21:30 +0100)]
fix 122 for removed btree types

With the the btree refactoring various btree trypes have been removed,
so remove them from the golden output for 122.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoadd test 201: btree corruption without CONFIG_LBD
Christoph Hellwig [Thu, 22 Jan 2009 20:19:14 +0000 (21:19 +0100)]
add test 201: btree corruption without CONFIG_LBD

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <david@fromorbit.com>
13 years agorun 092 unconditionally
Christoph Hellwig [Mon, 19 Jan 2009 03:49:43 +0000 (04:49 +0100)]
run 092 unconditionally

Now that we support inode64 filesystem on 32-bit plaforms tests 092
should be run unconditionally.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoDon't run test 197 on 64-bit machines
Eric Sandeen [Mon, 19 Jan 2009 01:29:38 +0000 (19:29 -0600)]
Don't run test 197 on 64-bit machines

If it always passes on 64 bits, this gives a false
sense of security.  Make it obvious.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoxfstests: add test 200, exercise read-only block devices and mounts
Christoph Hellwig [Sat, 10 Jan 2009 20:38:24 +0000 (21:38 +0100)]
xfstests: add test 200, exercise read-only block devices and mounts

Make sure we do the right thing with blockdevices with a hard read-only
flag.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoxfstests: add test 199, bad_features2 correction
Christoph Hellwig [Sat, 10 Jan 2009 20:37:27 +0000 (21:37 +0100)]
xfstests: add test 199, bad_features2 correction

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoAdd Makepkgs support to xfstests (tar & rpm only so far)
Eric Sandeen [Sat, 3 Jan 2009 04:29:32 +0000 (22:29 -0600)]
Add Makepkgs support to xfstests (tar & rpm only so far)

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoCreate xfstests install target.
Eric Sandeen [Sat, 3 Jan 2009 04:28:37 +0000 (22:28 -0600)]
Create xfstests install target.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agotest 198, testcase for aio+dio writes into sparse files
Eric Sandeen [Wed, 31 Dec 2008 12:06:23 +0000 (13:06 +0100)]
test 198, testcase for aio+dio writes into sparse files

Older kernels were not doing completion properly, and converting
unwritten extents at the wrong offsets; this exposed stale data.

Xen w/ the blktap driver was hitting this.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agotest 197, add a testcase for d_off truncation
Christoph Hellwig [Wed, 31 Dec 2008 11:59:19 +0000 (12:59 +0100)]
test 197, add a testcase for d_off truncation

Make sure our directory offsets fit into a 32 bit value.
Based on a report by John Stanley.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agotest 196, add a testcase for renames across project boundaries
Christoph Hellwig [Wed, 31 Dec 2008 11:53:33 +0000 (12:53 +0100)]
test 196, add a testcase for renames across project boundaries

Make sure rename across project boundaries is rejected and doesn't
cause hangs.  Based on a report and testcase from Arkadiusz Miskiewicz.

Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agotest 195, add a testcase for the nodump flag
Christoph Hellwig [Wed, 31 Dec 2008 11:53:21 +0000 (12:53 +0100)]
test 195, add a testcase for the nodump flag

Based on http://oss.sgi.com/bugzilla/show_bug.cgi?id=340.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoupdate for xfs_dinode_core_t removal
Christoph Hellwig [Wed, 31 Dec 2008 11:52:35 +0000 (12:52 +0100)]
update for xfs_dinode_core_t removal

Strip away the core. prefixes in 186 to make sure the golden output
works for both old and new xfsprogs.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agofix compiler warnings
Christoph Hellwig [Wed, 31 Dec 2008 11:52:05 +0000 (12:52 +0100)]
fix compiler warnings

Include all nessecary headers, use the correct format strings and don't
redefine _GNU_SOURCE.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agotest 194, test tricky mapping/conversion around holes
Eric Sandeen [Tue, 30 Dec 2008 22:34:17 +0000 (23:34 +0100)]
test 194, test tricky mapping/conversion around holes

Related to
http://oss.sgi.com/bugzilla/show_bug.cgi?id=801

Latest patch posted on that bug makes this testcase pass...

first 2 tests are simple buffred writ tests making sure stale
data isn't exposed, and hole-blocks aren't mapped.

2nd 2 tests are more related to the above bug, tricky testcase
uncovered by fsx on ppc64 which actually re-maps a block
which should be a hole, bringing stale data back into existence.

V2, don't use non-posix awk extensions

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoadd more tests to the auto group
Christoph Hellwig [Tue, 30 Dec 2008 22:33:39 +0000 (23:33 +0100)]
add more tests to the auto group

make sure we run all tests than don't either take forever or currently fail
(or require a tape drive) to the auto group.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
13 years agofix dbtest build
Eric Sandeen [Tue, 30 Dec 2008 22:33:34 +0000 (23:33 +0100)]
fix dbtest build

At least on my x86_64 RHEL5 box, if gdbm-devel is installed, then the
xfstests build fails with:

gcc dbtest.c -o dbtest -g -O2 -DDEBUG -I../include -DVERSION=\"1.0.0\" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -funsigned-char -fno-strict-aliasing -Wall  ../lib/.libs/libtest.a
dbtest.c: In function 'InitDbmLookup':
dbtest.c:147: warning: cast from pointer to integer of different size
dbtest.c:198: warning: cast from pointer to integer of different size
/tmp/ccuekqxe.o: In function `CleanupDbmLookup':
/root/cvs/xfs-cmds-build/xfstests/src/dbtest.c:304: undefined reference to `dbm_close'
/tmp/ccuekqxe.o: In function `DoDbmLookup':
/root/cvs/xfs-cmds-build/xfstests/src/dbtest.c:220: undefined reference to `dbm_fetch'
/root/cvs/xfs-cmds-build/xfstests/src/dbtest.c:264: undefined reference to `dbm_fetch'
/tmp/ccuekqxe.o: In function `InitDbmLookup':
/root/cvs/xfs-cmds-build/xfstests/src/dbtest.c:146: undefined reference to `dbm_open'
/root/cvs/xfs-cmds-build/xfstests/src/dbtest.c:179: undefined reference to `dbm_store'
/root/cvs/xfs-cmds-build/xfstests/src/dbtest.c:192: undefined reference to `dbm_close'
/root/cvs/xfs-cmds-build/xfstests/src/dbtest.c:197: undefined reference to `dbm_open'
collect2: ld returned 1 exit status
gmake[1]: *** [dbtest] Error 1
make: *** [default] Error 2

This patch fixes it for me, but my userspace-fu is weak; does this look ok?

Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agofix xfsqa 189 for log and rt devices
Matthew Kent [Tue, 30 Dec 2008 22:33:30 +0000 (23:33 +0100)]
fix xfsqa 189 for log and rt devices

Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoxfstests: add a unified diff option
Matthew Kent [Tue, 30 Dec 2008 22:33:24 +0000 (23:33 +0100)]
xfstests: add a unified diff option

Add the -udiff option to the test driver to make test output more
easily readable.

[hch:  made -udiff the default]

Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agofix number of arguments to AC_DEFINE
Mike Frysinger [Tue, 30 Dec 2008 22:21:52 +0000 (23:21 +0100)]
fix number of arguments to AC_DEFINE

aclocal hates when you only specify one parameter to AC_DEFINE ... simple patch
to add the other two parameters

fixes for acl and xfstests

[hch: added nfs4acl]

Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agofix up xfs-cmds build after the parallel-fest
Eric Sandeen [Tue, 30 Dec 2008 22:21:24 +0000 (23:21 +0100)]
fix up xfs-cmds build after the parallel-fest

My big parallel build patch lost the "make configure" target.
This broke Makepkgs...

Now, IMHO, running configure from make is a little bass-ackwards;
I'd probably prefer to have Makepkgs explicitly run:

 autoconf; configure --myoptions; make

but for now, this adds back in a workable "make configure" target.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoTest out the perm checks in xfs_setattr - chmod, chown, etc..
Tim Shimmin [Wed, 10 Dec 2008 14:03:09 +0000 (14:03 +0000)]
Test out the perm checks in xfs_setattr - chmod, chown, etc..
Merge of master-melb:xfs-cmds:32713a by kenmcd.

  Test out the perm checks in xfs_setattr - chmod, chown, etc..

13 years agoTest out that access time is updated correctly in memory and on disk.
Tim Shimmin [Tue, 9 Dec 2008 14:15:47 +0000 (14:15 +0000)]
Test out that access time is updated correctly in memory and on disk.
Merge of master-melb:xfs-cmds:32647a by kenmcd.

  Test out that access time is updated correctly in memory and on disk.

13 years agoXFS Quota tests were unaware of usrquota and grpquota mount options
Brad Scarlett [Tue, 2 Dec 2008 04:56:16 +0000 (04:56 +0000)]
XFS Quota tests were unaware of usrquota and grpquota mount options
Merge of master-melb:xfs-cmds:32619a by kenmcd.

  Fix 134 so it is notrun if grpquota mount option is detected.

13 years agoTake into account nfs4acl output
Donald Douwsma [Mon, 1 Dec 2008 14:09:30 +0000 (14:09 +0000)]
Take into account nfs4acl output
Merge of master-melb:xfs-cmds:32613a by kenmcd.

13 years agomkfe2fs unfortunately hasn't heard about real enterprise setups using
Barry Naujok [Wed, 26 Nov 2008 02:43:44 +0000 (02:43 +0000)]
mkfe2fs unfortunately hasn't heard about real enterprise setups using
whole disks and needs the -F option to create a filesystem on those
without asking stupid questions that make the testcases block forever.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:32546a by kenmcd.

  fix xfsqa on whole disks

13 years agoFedora is catching calls to open which have O_CREAT set w/o a mode.
Barry Naujok [Tue, 25 Nov 2008 03:10:07 +0000 (03:10 +0000)]
Fedora is catching calls to open which have O_CREAT set w/o a mode.
Merge of master-melb:xfs-cmds:32535a by kenmcd.

  Fedora is catching calls to open which have O_CREAT set w/o a mode.

13 years agoChange mode string variable declaration
Barry Naujok [Tue, 25 Nov 2008 03:09:43 +0000 (03:09 +0000)]
Change mode string variable declaration
Merge of master-melb:xfs-cmds:32533a by kenmcd.

  Change mode string variable declaration

13 years agoAllow parallel builds of the xfstests package
Barry Naujok [Fri, 21 Nov 2008 02:44:04 +0000 (02:44 +0000)]
Allow parallel builds of the xfstests package
Merge of master-melb:xfs-cmds:32515a by kenmcd.

  Allow parallel builds of the xfstests package

13 years agoCreate a tape group for anything which expects
Barry Naujok [Thu, 20 Nov 2008 14:24:24 +0000 (14:24 +0000)]
Create a tape group for anything which expects
to dump to tape (I guess this is a superset
of "remote" and a few others).  Also, remove
this from the auto group; most people won't have tapes
and -g tape is easy enough (per dchinner's suggestion).
Merge of master-melb:xfs-cmds:32513a by kenmcd.

  create tape group

13 years agoxfstests: fix buffer overflow in lstat64.c
Barry Naujok [Thu, 20 Nov 2008 14:24:01 +0000 (14:24 +0000)]
xfstests: fix buffer overflow in lstat64.c

lstat64.c was putting an 11-byte string into a 10-byte buffer.
Merge of master-melb:xfs-cmds:32512a by kenmcd.

  fix buffer overflow in lstat64.c

13 years agoxfstest: confirm mkfs.gfs[2] in test 032
Barry Naujok [Thu, 20 Nov 2008 14:23:38 +0000 (14:23 +0000)]
xfstest: confirm mkfs.gfs[2] in test 032

mkfs.gfs[2] asks for confirmation before mkfs'ing; without
this test 032 hangs when mkfs.gfs2 is present.

Also, mkfs.gfs needs a few more args to make it go.
Merge of master-melb:xfs-cmds:32510a by kenmcd.

  confirm mkfs.gfs[2] in test 032

13 years agoxfstests: fix nr of args in open calls
Barry Naujok [Thu, 20 Nov 2008 14:23:14 +0000 (14:23 +0000)]
xfstests: fix nr of args in open calls
Merge of master-melb:xfs-cmds:32509a by kenmcd.

  fix nr of args in open calls

13 years agoxfstests: check for dmapi headers
Barry Naujok [Thu, 20 Nov 2008 14:22:49 +0000 (14:22 +0000)]
xfstests: check for dmapi headers
Merge of master-melb:xfs-cmds:32507a by kenmcd.

  xfstests: check for dmapi headers

13 years agoLong devicenames cause this quota output to split onto 2 lines:
Tim Shimmin [Thu, 6 Nov 2008 15:10:24 +0000 (15:10 +0000)]
Long devicenames cause this quota output to split onto 2 lines:

# xfs_quota -c "quota -gpu -birnN 99" /mnt/scratch
/dev/mapper/testvol-test2
                           880       1004       1004   00 [--------]           1         10         10   00 [--------]           0          0          0   00 [--------] /mnt/scratch

but if we make that "\n" go away, the test still passes.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Merge of master-melb:xfs-cmds:32444a by kenmcd.

  Long devicenames cause this quota output to split onto 2 lines:
  # xfs_quota -c "quota -gpu -birnN 99" /mnt/scratch
  /dev/mapper/testvol-test2
  880       1004       1004   00 [--------]           1         10         10   00 [--------]           0          0          0   00 [--------] /mnt/scratch
  but if we make that "\n" go away, the test still passes.
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoUpdate 189.out for the touch test.
Tim Shimmin [Wed, 15 Oct 2008 15:49:12 +0000 (15:49 +0000)]
Update 189.out for the touch test.
Merge of master-melb:xfs-cmds:32339a by kenmcd.

  Update 189.out for the touch test.

13 years agotest out a remount bug where ro->rw doesn't update xfs flag and thinks it is
Tim Shimmin [Tue, 14 Oct 2008 14:58:57 +0000 (14:58 +0000)]
test out a remount bug where ro->rw doesn't update xfs flag and thinks it is
still readonly. Test using touch.
Code provided by Christoph Hellwig.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:32320a by kenmcd.

  test out a remount bug where ro->rw doesn't update xfs flag and thinks it is
  still readonly. Test using touch.
  Code provided by Christoph Hellwig.

13 years agoadd comment to test about its related bugs in bugworks
Tim Shimmin [Mon, 15 Sep 2008 06:19:07 +0000 (06:19 +0000)]
add comment to test about its related bugs in bugworks
Merge of master-melb:xfs-cmds:32116a by kenmcd.

  add comment to test about its related bugs in bugworks

13 years agoUpdate xfsprogs to latest kernel headers and functions
Barry Naujok [Mon, 8 Sep 2008 06:18:43 +0000 (06:18 +0000)]
Update xfsprogs to latest kernel headers and functions
Merge of master-melb:xfs-cmds:32070a by kenmcd.

13 years agoUpdate the group file more completely for nfs4acl support
Tim Shimmin [Fri, 5 Sep 2008 06:19:12 +0000 (06:19 +0000)]
Update the group file more completely for nfs4acl support
Merge of master-melb:xfs-cmds:32059a by kenmcd.

  Update nfs4acl group.

13 years agoCheck in Andreas Gruenbacher's nfs v4 acl tests into the xfstests suite.
Tim Shimmin [Fri, 5 Sep 2008 06:18:15 +0000 (06:18 +0000)]
Check in Andreas Gruenbacher's nfs v4 acl tests into the xfstests suite.
Merge of master-melb:xfs-cmds:32058a by kenmcd.

  Run all the tests in xfstests/nfs4acl

13 years agoFix nametest.c warnings
Barry Naujok [Mon, 1 Sep 2008 15:59:10 +0000 (15:59 +0000)]
Fix nametest.c warnings
Merge of master-melb:xfs-cmds:32013a by kenmcd.

  Fix nametest.c build warnings

13 years agoUpdate QA 096 for ASCII CI mkfs output
Barry Naujok [Thu, 28 Aug 2008 04:09:33 +0000 (04:09 +0000)]
Update QA 096 for ASCII CI mkfs output
Merge of master-melb:xfs-cmds:31997a by kenmcd.

  Execute bits changed from xxx to ---
  Update for ASCII CI mkfs output

13 years agoFix test 190 to work file filesystems with bsize other then 4096.
Peter Leckie [Tue, 26 Aug 2008 16:11:33 +0000 (16:11 +0000)]
Fix test 190 to work file filesystems with bsize other then 4096.
Merge of master-melb:xfs-cmds:31968a by kenmcd.

  Fix test 190 to work file filesystems with bsize other then 4096.

13 years agoAdd test to check unreserve space hole is the same as what we requested.
Peter Leckie [Fri, 22 Aug 2008 06:11:29 +0000 (06:11 +0000)]
Add test to check unreserve space hole is the same as what we requested.
Merge of master-melb:xfs-cmds:31945a by kenmcd.

  Add test to check unreserve space hole is the same as what we requested.

13 years agoDisable tests 098 101 and 102 from running under the auto group.
Peter Leckie [Fri, 22 Aug 2008 06:10:39 +0000 (06:10 +0000)]
Disable tests 098 101 and 102 from running under the auto group.
Merge of master-melb:xfs-cmds:31943a by kenmcd.

  Disable tests 098 101 and 102 from running under the auto group.

13 years agoAdd 017 to mount group. At Christoph's reminder.
Tim Shimmin [Mon, 18 Aug 2008 03:59:14 +0000 (03:59 +0000)]
Add 017 to mount group. At Christoph's reminder.
Merge of master-melb:xfs-cmds:31913a by kenmcd.

  add 017 to mount group

13 years agoAdd a bunch of tests for remount code.
Tim Shimmin [Fri, 15 Aug 2008 16:11:24 +0000 (16:11 +0000)]
Add a bunch of tests for remount code.
Written by Christoph and amended by Tim to do some more testing
with fstab etc.
Merge of master-melb:xfs-cmds:31909a by kenmcd.

  remount test

13 years agoVarious tests were incorrectly identifying themselves in header comments
Brad Scarlett [Tue, 12 Aug 2008 04:14:21 +0000 (04:14 +0000)]
Various tests were incorrectly identifying themselves in header comments
Merge of master-melb:xfs-cmds:31874a by kenmcd.

  Change Header comment to correctly identify test name

13 years agoxfstests/145 has an incorrect comment describing itself as FSQA Test 142
Brad Scarlett [Mon, 11 Aug 2008 16:05:45 +0000 (16:05 +0000)]
xfstests/145 has an incorrect comment describing itself as FSQA Test 142
Merge of master-melb:xfs-cmds:31872a by kenmcd.

13 years agoTims patch to fix test 122: the __arch_pack stuff is confusing it - as was the case...
Brad Scarlett [Thu, 17 Jul 2008 04:11:10 +0000 (04:11 +0000)]
Tims patch to fix test 122:  the __arch_pack stuff is confusing it - as was the case in the past
with the "attribute packed" stuff for the efi/efd items etc..
It is confusing the parsing which works out the type names.
Merge of master-melb:xfs-cmds:31658a by kenmcd.

13 years agoIf test 078 fails and you try to run it again immediately, it
Tim Shimmin [Tue, 15 Jul 2008 06:17:47 +0000 (06:17 +0000)]
If test 078 fails and you try to run it again immediately, it
will execute a 'rm -f' on a directory which will fail. This should
be a rmdir....

Signed-off-by: Dave Chinner <dgc@sgi.com>
Merge of master-melb:xfs-cmds:31637a by kenmcd.

  If test 078 fails and you try to run it again immediately, it
  will execute a 'rm -f' on a directory which will fail. This should
  be a rmdir....  Signed-off-by: Dave Chinner <dgc@sgi.com>

13 years agoAdd CI stat/create/unlink test for multiple directory forms
Barry Naujok [Tue, 24 Jun 2008 16:30:43 +0000 (16:30 +0000)]
Add CI stat/create/unlink test for multiple directory forms
Merge of master-melb:xfs-cmds:31348a by kenmcd.

  Do CI stat/create/unlink test for multiple directory forms

13 years agoAdd CI stat/create/unlink test for multiple directory forms
Barry Naujok [Tue, 24 Jun 2008 16:29:51 +0000 (16:29 +0000)]
Add CI stat/create/unlink test for multiple directory forms
Merge of master-melb:xfs-cmds:31347a by kenmcd.

  Add genhashnames target

13 years agofix XFSQA 145 / test_hole
Donald Douwsma [Wed, 18 Jun 2008 16:09:09 +0000 (16:09 +0000)]
fix XFSQA 145 / test_hole

There are two errors I see all the time in 145:

 - dm_probe_hole returns EINVAL for offsets close to the file size
 - dm_probe_hole wants EAGAIN for a probe at offset 1, length 0

The first error is a consequence of how the hole puching / probing
works.  It always rounds the requested offset up to the next block
size and then checks if that rounded offset still fits into the file
size.  Just do the same rounding in the testcase to make sure we don't
probe invalid offsets.

The second error is very odd to me, as we never return AGAIN in the
whole dm_probe_hole path.  I've just commented it out.

I've also re-enabled the E2BIG to past-EOF test that was uncommented
before because it works perfectly fine now.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:31330a by kenmcd.

  fix XFSQA 145 / test_hole

13 years agoFix XFSQA test 144
Donald Douwsma [Wed, 18 Jun 2008 16:08:20 +0000 (16:08 +0000)]
Fix XFSQA test 144

Two really dumb bugs:

 - "foo & 0x3FFFFFFFFFFFF" doesn't cap at 1TB, but rather at more than
   two magnitudes larger than that.  That gets us EFBIG with typical
   32bit XFS setups.
 - the command array can easily overflow and thus let the test fail

Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:31327a by kenmcd.

  Fix XFSQA test 144

13 years ago074 takes ages to complete on my kvm test VM, but scaling it back to the
Niv Sardi [Wed, 4 Jun 2008 04:25:32 +0000 (04:25 +0000)]
074 takes ages to complete on my kvm test VM, but scaling it back to the
level used on IRIX makes it complete in slightly under 10 minutes.

I'm not sure if checking for UP vs SMP is the right way to go into slow
mode, but I couldn't think of anything better.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:31272a by kenmcd.

13 years agomkfs.reiserfs refuses to create a filesystem on full devices without
Barry Naujok [Thu, 29 May 2008 17:01:09 +0000 (17:01 +0000)]
mkfs.reiserfs refuses to create a filesystem on full devices without
partitions unless it's given -f in addition to the already required Y
input to confirm the fs creation, so give the argument to it.

While we're at it also write the full command line used to create the
filesystem into the log to ease future debugging.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:31250a by kenmcd.

  Execute bits changed from xxx to ---
  Fix up test with reiserfs

13 years agoFix 073 to run on sles10 systems
Brad Scarlett [Wed, 28 May 2008 04:05:02 +0000 (04:05 +0000)]
Fix 073 to run on sles10 systems
Merge of master-melb:xfs-cmds:31236a by kenmcd.

14 years agoDon't run 167 if killall is not installed
Dave Chinner [Thu, 15 May 2008 16:39:01 +0000 (16:39 +0000)]
Don't run 167 if killall is not installed

Test 167 will leave runaway fsstress processes around in case killall is
not installed and thus make all following tests fail.  This patch checks
for killall beeing installed and error out otherwise.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:31171a by kenmcd.

  don't run if killall is not installed.

14 years agoFix pathname filter issue.
Dave Chinner [Thu, 15 May 2008 16:38:14 +0000 (16:38 +0000)]
Fix pathname filter issue.

If the path to the file being bmap'd has a [0-9] in it,
the output filter matches it and we get golden output
failure. Be more specific on the match.
Merge of master-melb:xfs-cmds:31170a by kenmcd.

  Be more specific when trying to match extent output lines.

14 years agoDon't use /tmp for hosting loopback images
Dave Chinner [Thu, 15 May 2008 16:37:27 +0000 (16:37 +0000)]
Don't use /tmp for hosting loopback images

/tmp might be small, might not support files larger than 2GB,
etc, so trying to host loopback images of 100GB filesystems
will break in some situations. We should use $TEST_DIR for the
images.

Note: remounting of loopback images has a major bug (in mount)
that "leaks" loopback device references. Hence all the hackery
with losetup to work around this.
Merge of master-melb:xfs-cmds:31169a by kenmcd.

  Don't use /tmp for hosting loopback images

14 years agoWith the recent change for reliability with 64k page size
Dave Chinner [Thu, 15 May 2008 16:36:40 +0000 (16:36 +0000)]
With the recent change for reliability with 64k page size
made to test 008,the file sizes got much larger. It appears
that randholes actually reads the entire file, so this has
slowed the test down by a factor of ten (all file sizes
were increased by 10x). This means the test is now taking
about 18 minutes to run on a UML session, and all the time
is spent reading the files.

Instead, scale the file size based on the page size. We know
how many holes we are trying to produce and the I/O size
being used to produce them, so the size of the files can be
finely tuned. Assuming a decent random distribution, if the
number of blocks in the file is 4x the page size and the
I/O size is page sized, this means that every I/O should
generate a new hole and we'll only get a small amount of
adjacent extents. This has passed over 10 times on ia64
w/ 64k page and another 15 times on UML with 4k page.

UML runtime is down from ~1000s to 5s, ia64 runtime is down from
~30s to 7s.
Merge of master-melb:xfs-cmds:31168a by kenmcd.

  Greatly reduce runtime by reducing filesizes down to sane minimum.

14 years agoTest 180 breaks if you have long device paths
Mohamed Barwani [Thu, 15 May 2008 04:23:55 +0000 (04:23 +0000)]
Test 180 breaks if you have long device paths
Use -P for df to fix it

       -P, --portability
              use the POSIX output format
Merge of master-melb:xfs-cmds:31162a by kenmcd.

  fix df for long /dev paths

14 years agoFix silly "unmount" typo in dmapi test.
Dave Chinner [Tue, 13 May 2008 04:21:15 +0000 (04:21 +0000)]
Fix silly "unmount" typo in dmapi test.
Merge of master-melb:xfs-cmds:31069a by kenmcd.

  Fix silly "unmount" typo in dmapi test.

14 years agoSample the log traffic to work out its data rate so that we
Tim Shimmin [Fri, 9 May 2008 04:38:54 +0000 (04:38 +0000)]
Sample the log traffic to work out its data rate so that we
have a better idea of predicting when it will get to the end
of the log. This way we can handle a change in log traffic in
the future. A test to keep an eye on log traffic is more of
a performance test than should be done elsewhere.
Merge of master-melb:xfs-cmds:31053a by kenmcd.

  Sample the log traffic to work out its data rate so that we
  have a better idea of predicting when it will get to the end
  of the log. This way we can handle a change in log traffic in
  the future.

14 years agoFilter out onlink (because of v2 inodes by default) and gen# (because of random gener...
Tim Shimmin [Fri, 9 May 2008 04:37:54 +0000 (04:37 +0000)]
Filter out onlink (because of v2 inodes by default) and gen# (because of random generation).
Merge of master-melb:xfs-cmds:31049a by kenmcd.

  Filter out onlink (because of v2 inodes by default) and gen# (because of random generation).

14 years agoCorrectly detect if dmapi is present of not in tests 175-177
Dave Chinner [Thu, 8 May 2008 04:11:07 +0000 (04:11 +0000)]
Correctly detect if dmapi is present of not in tests 175-177
Merge of master-melb:xfs-cmds:31032a by kenmcd.

  Correctly detect if dmapi is present.

14 years agoUse standard awk comment format.
Dave Chinner [Thu, 8 May 2008 04:10:08 +0000 (04:10 +0000)]
Use standard awk comment format.
Merge of master-melb:xfs-cmds:31031a by kenmcd.

  Use standard awk comment format.

14 years agoAdd support for sb_bad_features2 in QA 122
Barry Naujok [Mon, 5 May 2008 06:25:29 +0000 (06:25 +0000)]
Add support for sb_bad_features2 in QA 122
Merge of master-melb:xfs-cmds:31022a by kenmcd.

  Add support for sb_bad_features2 in superblock structure