xfstests-dev.git
12 years agoxfstests: simplify build of preallo_rw_pattern_reader/writer
Christoph Hellwig [Thu, 21 Jan 2010 11:32:50 +0000 (11:32 +0000)]
xfstests: simplify build of preallo_rw_pattern_reader/writer

Instead of having complicated build system hacks just create two
two-line source files defining READ/WRITE and including iopat.c

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
12 years agoxfstests: fix format string warning in aio-dio-extend-stat.c
Christoph Hellwig [Thu, 21 Jan 2010 17:32:36 +0000 (18:32 +0100)]
xfstests: fix format string warning in aio-dio-extend-stat.c

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>
12 years agoxfstests: fix format string warnings in locktest.c
Christoph Hellwig [Thu, 21 Jan 2010 17:31:50 +0000 (18:31 +0100)]
xfstests: fix format string warnings in locktest.c

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>
12 years agoxfstests: kill in 131 needs to be quiet
Dave Chinner [Wed, 20 Jan 2010 21:54:38 +0000 (08:54 +1100)]
xfstests: kill in 131 needs to be quiet

If the kill fails because the processes have already terminates,
the output from kill (no such process) will cause the test to
fail. Make sure kill doesn't output anything.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests: don't redefine _GNU_SOURCE in aio tests
Dave Chinner [Wed, 20 Jan 2010 21:54:31 +0000 (08:54 +1100)]
xfstests: don't redefine _GNU_SOURCE in aio tests

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests: fix printf warnings in locktest.c
Dave Chinner [Wed, 20 Jan 2010 21:54:23 +0000 (08:54 +1100)]
xfstests: fix printf warnings in locktest.c

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests: fix printf format warnings in looptest.c
Dave Chinner [Wed, 20 Jan 2010 21:54:16 +0000 (08:54 +1100)]
xfstests: fix printf format warnings in looptest.c

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests: fix compile warnings in iopat.c
Dave Chinner [Wed, 20 Jan 2010 21:54:08 +0000 (08:54 +1100)]
xfstests: fix compile warnings in iopat.c

Printf format warnings and return value warnings need fixing.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests: fix printf format warnings in aio-stress.c
Dave Chinner [Wed, 20 Jan 2010 21:54:01 +0000 (08:54 +1100)]
xfstests: fix printf format warnings in aio-stress.c

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests: Don't use tempnam in growfiles.c
Dave Chinner [Wed, 20 Jan 2010 21:53:53 +0000 (08:53 +1100)]
xfstests: Don't use tempnam in growfiles.c

tempnam() generates a compiler warning as a dangerous function.
This code doesn't care about security issues with tempnam, so
remove it and just manually build the filenames without the
randomness of tempnam.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests: fix bulkstat related compile warnings.
Dave Chinner [Wed, 20 Jan 2010 21:53:44 +0000 (08:53 +1100)]
xfstests: fix bulkstat related compile warnings.

Use correct types for bulkstat structure to avoid pointer warnings.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests: fix compile warning in doio.c
Dave Chinner [Wed, 20 Jan 2010 21:53:27 +0000 (08:53 +1100)]
xfstests: fix compile warning in doio.c

Use of sigblock is deprecated. Use sigprocmask instead.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfsqa: filter the fsstress seed output in 104
Dave Chinner [Wed, 20 Jan 2010 21:53:17 +0000 (08:53 +1100)]
xfsqa: filter the fsstress seed output in 104

Otherwise it fails to match the golden output. Also add
the test to the auto group so that it is run regularly now
that the growfs problems are fixed.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfsqa: Fix signal usage in aio-dio test code
Dave Chinner [Tue, 19 Jan 2010 23:28:24 +0000 (10:28 +1100)]
xfsqa: Fix signal usage in aio-dio test code

Using signal() to set up signal handlers doesn't always do what you
want. A recent upgrade made test 208 fail because wait() was not
getting interrupted by a SIGALRM. Tracing showed that signal() was
being converted to a sigaction(SA_RESTART) handler, which allows
syscalls that return ERESTARTSYS to immediately restart without
returning EINTR to the calling process. The kernel code returns
ERESTARTSYS to signal interruptions while in wait().

Replace the use of signal with sigaction() to ensure that the
SA_RESTART flag is not set and the EINTR is delivered to the process
sitting in wait().  This makes test 208 terminate at 200s again.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfsqa: update 214 golden output
Dave Chinner [Tue, 19 Jan 2010 23:28:16 +0000 (10:28 +1100)]
xfsqa: update 214 golden output

It does not contain the output from the recently added test,
so fails when the test actually succeeds.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests: Convert all tests to use /bin/bash
Dave Chinner [Tue, 19 Jan 2010 23:27:08 +0000 (10:27 +1100)]
xfstests: Convert all tests to use /bin/bash

While most tests use /bin/sh, they are dependent on /bin/sh being a
bash shell.  Convert all the tests to execute via /bin/bash as it is
much, much simpler than trying to debug and remove all the bashisms
throughout the test code.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
12 years agoxfstests: Use common rules to build binaries
Dave Chinner [Tue, 19 Jan 2010 23:26:10 +0000 (10:26 +1100)]
xfstests: Use common rules to build binaries

Remove explicit target-per-file rules in the subdirectories being
built and replace them with target based rules using the buildrules
hooks for doing this.  This results in the makefiles being simpler,
smaller and more consistent. It does mean that all binaries are
linked against the common set of libraries but this does not cause
any harm.

This patch does not address the dmapi subdirectory of the xfstests
build system.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests: Clean up build output
Dave Chinner [Tue, 19 Jan 2010 23:26:01 +0000 (10:26 +1100)]
xfstests: Clean up build output

We don't need to see every compiler command line for every file that
is compiled. This makes it hard to see warnings and errors during
compile. For progress notification, we really only need to see the
directory/file being operated on.

Turn down the verbosity of output by suppressing various make output
and provide better overall visibility of which directory is being
operated on, what the operation is and what is being done to the
files by the build/clean process.

This patch only addresses the top level makefile and build rules; it
does not clean up the subdirectories - these will be addressed by a
followup patch. It also does not touch the dmapi section of the
xfstests build system.

The old style verbose builds can still be run via "make V=1 ..."

Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests 219: ignore duplicates reported by repquota
Alex Elder [Tue, 19 Jan 2010 20:26:16 +0000 (14:26 -0600)]
xfstests 219: ignore duplicates reported by repquota

Arrange to ignore duplicate entries reported by the repquota command.
This can happen if an id is used more than once (such as when two user
names are assigned the same uid).

Do this here by simply dropping any reported entries whose id number
has already been seen in the output.

Signed-off-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests 050: ignore duplicates reported by repquota
Alex Elder [Tue, 19 Jan 2010 20:26:20 +0000 (14:26 -0600)]
xfstests 050: ignore duplicates reported by repquota

Arrange to ignore duplicate entries reported by the "repquota"
xfs_quota command.  This can happen if an id is used more than once
(such as when two user names are assigned the same uid).

Since we are already sorting the output we can accomplish this by
adding the "-u" (unique) option to the sort command.  Shorten some
long lines while we're at it.

Signed-off-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests 073: unmount source image in cleanup
Eric Sandeen [Sun, 17 Jan 2010 16:35:23 +0000 (10:35 -0600)]
xfstests 073: unmount source image in cleanup

Test 073 is currently failing w/ xfs_repair problems, and when
it does, the whole series stops because the test dir still has
a loopback mounted filesystem on it, and it can't unmount.

Fix that.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests 131: kill locktest process in cleanup & better error msgs
Eric Sandeen [Sun, 17 Jan 2010 16:29:23 +0000 (10:29 -0600)]
xfstests 131: kill locktest process in cleanup & better error msgs

I occasionally get failures in 131 like:

gethostbyname: Success

1) perror is the wrong thing for gethostbyname errors, so this
is confusing

2) the locktest thread doesn't get killed, so the fs
is busy and the next test fails when it can't unmount

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests 032: fix up mkfs.gfs2 args
Eric Sandeen [Fri, 15 Jan 2010 17:59:11 +0000 (11:59 -0600)]
xfstests 032: fix up mkfs.gfs2 args

Looks like gfs2 (recently?) needs more arguments for the
mkfs overwrite test.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Alex Elder <aelder@sgi.com>
12 years agoadd simple xfs_fsr test
Dave Chinner [Tue, 12 Jan 2010 21:51:47 +0000 (22:51 +0100)]
add simple xfs_fsr test

We have very little fsr test coverage in the test suite right now.
042 is the only test that runs it, and it only defragments a single
file.

Improve the coverage by simply running xfs_fsr of the test
filesystem. This gives xfs_fsr a wide variety of inodes to try to
defragment. A simple test like this would have tripped over the
attr2 fork offset problems in the swap extents ioctl long ago
thanks to the varied nature of inodes the test suite leaves around
in this filesystem.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
12 years agofilter log size in 206
Dave Chinner [Tue, 12 Jan 2010 21:49:57 +0000 (22:49 +0100)]
filter log size in 206

With the log size now going past 128MB, test 206 creates a filesystem
with a much larger log than 128MB. The golden output expects at
128MB log size, so the test breaks. Filter the log size out of the
mkfs output and golden output so that the test works on both older and
newer mkfs binaries.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
12 years agomake unmounting loop devices in 073 work again
Dave Chinner [Tue, 12 Jan 2010 21:49:03 +0000 (22:49 +0100)]
make unmounting loop devices in 073 work again

Loop devices are now created and destroyed on demand, and
the existing hacks to do this no longer work. Remove them.

Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
12 years agoadd a test for ctimes updates in futimens
Christoph Hellwig [Tue, 12 Jan 2010 21:47:21 +0000 (22:47 +0100)]
add a test for ctimes updates in futimens

Add a test to check if we update the ctime properly if not updating
the mtime in futimens.

Uses a C program contributed by Eric Blake <ebb9@byu.net>.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <david@fromorbit.com>
12 years agotest quota log replay in 087
Christoph Hellwig [Tue, 12 Jan 2010 21:45:26 +0000 (22:45 +0100)]
test quota log replay in 087

By mounting the filesystem with quotas enabled in 087 we exercise the
replay of the quota log items in this tests, which we otherwise don't
test in xfstests.  OSS bugzilla #855 is an example of something caught
by this.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <david@fromorbit.com>
12 years ago[PATCH] xfstests: add another fallocate test to 214
Eric Sandeen [Wed, 6 Jan 2010 19:00:18 +0000 (13:00 -0600)]
[PATCH] xfstests: add another fallocate test to 214

ext4 had a regression where it double-accounted used blocks
if you fallocated on top of delalloc blocks.  Ted sent a
c program to exploit it (see "fsstress-induced corruption reproduced"
on linux-ext4 on 12/31/2009) and it's trivial to do the same thing
within the xfstests framework using xfs_io.

This also changes the handcrafted xfs_io tests to use the
_require_xfs_io_falloc helper, not sure how that got missed.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agocommit bd53c922 added src/aio-dio-regress to the top-level
Eric Sandeen [Thu, 3 Dec 2009 16:30:11 +0000 (10:30 -0600)]
commit bd53c922 added src/aio-dio-regress to the top-level
Makefile so that it would get caught on make install, but
doing this unconditionally means that we tried to build that
subdir even if libaio headers weren't found.

Fix this up to do a properly chained make install through
the subdirs...

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoFix tests for lazy sb counter defaults
Eric Sandeen [Wed, 2 Dec 2009 17:27:49 +0000 (11:27 -0600)]
Fix tests for lazy sb counter defaults

Fix tests which would be affected by a change to lazy-sb
by default.

All tests now explicitly -specify- -l lazy-sb=1 where appropriate,
so this can go in prior to a userspace change.

Unfortunately many of the logprint outputs must just be taken on faith.

Also, the irix flavors for e.g. 018.op.irix will need fixing up
if anyone cares.

This also needs the patch I just sent for xfs_db clearing attr2
in bad_features2 to complete w/o error.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoAdd a test for ENOSPC when fallocating.
Eric Sandeen [Wed, 25 Nov 2009 22:12:09 +0000 (16:12 -0600)]
Add a test for ENOSPC when fallocating.

Also, add an expected output, not sure how that went missing!

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoInstall src/aio-dio-regress tests on "make install"
Izidor Matusov [Mon, 9 Nov 2009 21:26:36 +0000 (15:26 -0600)]
Install src/aio-dio-regress tests on "make install"

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
12 years agoxfstests: fix up have_xlog_assign_lsn config test for loggen
Eric Sandeen [Tue, 3 Nov 2009 15:38:07 +0000 (09:38 -0600)]
xfstests: fix up have_xlog_assign_lsn config test for loggen

Without this we weren't building src/loggen

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
12 years agoxfstests: add another quotaoff testcase to 220
Christoph Hellwig [Tue, 3 Nov 2009 14:29:50 +0000 (15:29 +0100)]
xfstests: add another quotaoff testcase to 220

Add the quotafile space remove regression test from Ryota Yamauchi to
testcase 220.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>
12 years agotest 220: double inode free in xfs_dqrele_inode
Christoph Hellwig [Fri, 30 Oct 2009 05:41:33 +0000 (06:41 +0100)]
test 220: double inode free in xfs_dqrele_inode

Trivial test case that mounts a filesystem with user quotas, then turns
quotas off an unmounts.  Based on a testcase in a bug report from
Utako Kusaka <u-kusaka@wm.jp.nec.com>.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>
12 years ago_check_generic_filesystem support for fsck parameters
Jaroslav Barton [Wed, 16 Sep 2009 12:55:59 +0000 (09:55 -0300)]
_check_generic_filesystem support for fsck parameters

_check_generic_filesystem now support fsck parameters. Fsck parameters
can be passed by FSCK_OPTIONS environmental variable. Default values
will be used if FSCK_OPTIONS is missing or empty (same mechanism as
MOUNT_OPTIONS and MKFS_OPTIONS).

_check_extN_filesystem function is no longer needed, extN filesystem are
properly handled by default values in _check_generic_filesystem.

12 years agoxfstests: fix 192 for external logs and enable it by default
Christoph Hellwig [Wed, 2 Sep 2009 18:00:17 +0000 (15:00 -0300)]
xfstests: fix 192 for external logs and enable it by default

Use _test_mount instead of plain mount to make it work with external logs.

Enable it by default now that it runs everywhere.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
12 years agoadd ext2/3/4-specific _check_extN_filesystem function
Theodore Ts'o [Thu, 27 Aug 2009 21:17:32 +0000 (18:17 -0300)]
add ext2/3/4-specific _check_extN_filesystem function

The _check_generic_filesystem function doesn't force a full filesystem
check, so filesystem inconsistencies after a test wouldn't be noticed.
To fix this, I added an extN specific check filesystem function.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agoAdd some very basic quota sanity tests for generic filesystems.
Eric Sandeen [Mon, 10 Aug 2009 18:18:39 +0000 (13:18 -0500)]
Add some very basic quota sanity tests for generic filesystems.

This is based on test 108, but uses the generic quota tools,
not xfs_quota, and therefore cannot test project quota.

Also, the IOs are much smaller (48k) so that ext3 won't get into
indirect blocks and throw off the accounting.  This does
assume 4k blocks though.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Lachlan McIlroy <lmcilroy@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoSplit out xfs & generic quota existence tests
Eric Sandeen [Mon, 10 Aug 2009 18:18:50 +0000 (13:18 -0500)]
Split out xfs & generic quota existence tests

Make a new test to test for generic quota tools, for
generic filesystem testing.  Move the existing quota test
to a new "xfs" name.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Lachlan McIlroy <lmcilroy@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoTest a few very basic defragmentation scenarios.
Eric Sandeen [Mon, 10 Aug 2009 18:10:26 +0000 (13:10 -0500)]
Test a few very basic defragmentation scenarios.

This test creates some files, runs defrag on them,
and compares the before/after fragmentation as well
as file md5sums and timestamps.

The test currently expects to find e4defrag in
/usr/bin

It should be relatively easy to add more interestingly
fragmented files to the tests, as well as to test
that memory-mapped files aren't touched, etc -
but this gives us a framework.

V2: remount before checking file contents, and create
common.defrag.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoactually hook up 198, make it generic
Eric Sandeen [Thu, 30 Jul 2009 15:49:13 +0000 (10:49 -0500)]
actually hook up 198, make it generic

Not entirely sure how I managed this, but 198 was not in groups
so was never run - and wasn't in the makefile, so was never built.
Oops.

Fix that up, make it a generic test, and move it to the
aio-dio-regress subdir.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agodon't fail if nslookup is not found
Christian Kujau [Mon, 20 Jul 2009 09:31:39 +0000 (11:31 +0200)]
don't fail if nslookup is not found

When nslookup is not available, execution would stop. This patch moves the
check for nslookup and the _get_fqdn function into the ./new script (since
this is the only place where it's used) and we don't fail any more but try
to find out our FQDN without nslookup.

Signed-off-by: Christian Kujau <lists@nerdbynature.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agoadd missing golden output for test 215
Christoph Hellwig [Wed, 8 Jul 2009 17:00:40 +0000 (19:00 +0200)]
add missing golden output for test 215

Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agofix trivial typo in test 204 description
Christoph Hellwig [Tue, 7 Jul 2009 17:43:51 +0000 (19:43 +0200)]
fix trivial typo in test 204 description

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agosmall common.config cleanup
Christoph Hellwig [Tue, 7 Jul 2009 14:22:36 +0000 (16:22 +0200)]
small common.config cleanup

Don't list various non-mandatory options near the check for the
mandatory ones, and make the test for the mandatory ones a proper if
statements.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agodon't print scratch mkfs and mount options without scratch device
Christoph Hellwig [Tue, 7 Jul 2009 14:20:59 +0000 (16:20 +0200)]
don't print scratch mkfs and mount options without scratch device

Also clean up the way the test configuration is printed.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoxfstests: add tests to check log size scaling
Dave Chinner [Tue, 7 Jul 2009 13:25:13 +0000 (15:25 +0200)]
xfstests: add tests to check log size scaling

Add two tests that check that log size scaling works correctly for old
and new maximum log sizes.

Signed-off-by: Dave Chinner <dgc@sgi.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agoxfstests: test c/mtime updates through mapped writes
Christoph Hellwig [Tue, 7 Jul 2009 10:35:56 +0000 (12:35 +0200)]
xfstests: test c/mtime updates through mapped writes

Check that we correctly update the timestamps when writing to a file
through an mmap mapping.  Currently fails for XFS due a VFS bug but
succeeds for many other filesystems.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoFix syntax error in common.rc
Eric Sandeen [Thu, 25 Jun 2009 15:14:24 +0000 (10:14 -0500)]
Fix syntax error in common.rc

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agofallocate + read/write tests, ext4 regression tests
Eric Sandeen [Wed, 24 Jun 2009 17:58:11 +0000 (12:58 -0500)]
fallocate + read/write tests, ext4 regression tests

New test to test basic mixed fallocate + read & write,
includes a couple regression tests for bugs that ext4
hit.  Uses xfs_io to generate fallocate calls, so requires
git xfsprogs and very recent glibc at this point.

Ext4 folks, this is hopefully a reasonable example of
how to add a new test.   :)

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoMove duplicated xfs_io filters to common.filter
Eric Sandeen [Wed, 24 Jun 2009 17:57:24 +0000 (12:57 -0500)]
Move duplicated xfs_io filters to common.filter

Also fix up 132 output, which was misfiltered due
to a bug in the filtering.

Doing this because I need this same filter for the next
added test.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agobasic fallocate boundary tests
Eric Sandeen [Wed, 24 Jun 2009 17:58:30 +0000 (12:58 -0500)]
basic fallocate boundary tests

This is just like test 072, but using fallocate instead
of the xfs ioctl.  Just very basic fallocate tests.

Also adds a "prealloc" group (./check -g prealloc)
and a _require_xfs_io_falloc check.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agofix common.config to allow SCRATCH_DEV and SCRATCH_MNT to be optional
Theodore Ts'o [Sat, 20 Jun 2009 17:14:14 +0000 (19:14 +0200)]
fix common.config to allow SCRATCH_DEV and SCRATCH_MNT to be optional

Commit 3ae9f2f8 purports to allow SCRATCH_DEV and SCRATCH_MNT to be
optional, but tests in common.config will cause check to exit with an
error if these environment variables are not defined.  Fix this problem.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agofix _require_scratch test for extN, resierfs, gfs2, and btrfs
Theodore Ts'o [Sat, 20 Jun 2009 17:05:45 +0000 (19:05 +0200)]
fix _require_scratch test for extN, resierfs, gfs2, and btrfs

The extN, reiserfs, gfs2, and btrfs filesysytem types should use the
same check for a block device as XFS and UDF, and not the test for
NFS, which was checking for host:/foo/bar/baz when checking for a
scratch device.

Also, the NFS logic was also incorrect, in that it would allow a
zero-length SCRATCH_DEV to continue.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
13 years agoskip _check_test_fs unless a test is actually run
Theodore Ts'o [Sat, 20 Jun 2009 17:01:43 +0000 (19:01 +0200)]
skip _check_test_fs unless a test is actually run

Running _check_test_fs can take a non-trivial amount of time, and if a
test has been skipped because it doesn't work on Linux, or it doesn't
work of for ext4, it's pointless to re-run _check_test_fs.  So move
the call to _check_test_fs so it is only run if a test is actually run.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
13 years agoSkip dump _cleanup if filesystem is not xfs
Eric Sandeen [Wed, 10 Jun 2009 20:05:04 +0000 (15:05 -0500)]
Skip dump _cleanup if filesystem is not xfs

Many/most dump tests include common.dump before checking
supported fs, and this means that even if the dump tests
are skipped, the sleep & filesystem check in _cleanup
gets run, which makes it take rather a long time to
skip these tests for non-xfs filesystems.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoGracefully fail aio tests if they weren't built
Eric Sandeen [Wed, 10 Jun 2009 20:04:52 +0000 (15:04 -0500)]
Gracefully fail aio tests if they weren't built

configure & make succeeds w/o aio headers or libs,
so tests should handle that.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoEnable test 080 for Linux
Eric Sandeen [Tue, 9 Jun 2009 18:38:11 +0000 (13:38 -0500)]
Enable test 080 for Linux

Seems to work here... Also disable IRIX as supported,
since the comments & code say it doesn't work and
it short-circuits anyway.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoEnable still more tests for generic filesystems
Eric Sandeen [Tue, 9 Jun 2009 18:35:28 +0000 (13:35 -0500)]
Enable still more tests for generic filesystems

Make the following tests _supported_fs generic:

088 - test out CAP_DAC_OVERRIDE and CAP_DAC_SEARCH code
089 - Emulate the way Linux mount manipulates /etc/mtab
113 - aio-stress (explicitly mark as generic)
126 - tests various file permission options
129 - looptests

These all pass on ext3, ext4, btrfs, and gfs2 as well
as xfs.

Also remove "generic" group from "groups," which was
accidentally added.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoallow more xfs_io tests to be generic
Eric Sandeen [Tue, 9 Jun 2009 15:32:29 +0000 (10:32 -0500)]
allow more xfs_io tests to be generic

These tests just do generic reads & writes with xfs_io;
if we add a "-F" they will run on other filesystems.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoAllow fsx tests to run on generic filesystems
Eric Sandeen [Mon, 8 Jun 2009 16:27:23 +0000 (11:27 -0500)]
Allow fsx tests to run on generic filesystems

There is already logic in 075 to gracefully skip nfs for fsx
invocations with -x (xfs-specific preallocation) - just extend
this to any non-xfs filesystem, and add to test 112 as well.

Later we can change this behavior to use fallocate and include
more filesystems but this gets some fsx coverage for now.

Test 127 doesn't seem to have anything xfs-specific, so mark
that as generic too.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoMake "new" script insert appropriate license on tests
Eric Sandeen [Fri, 5 Jun 2009 22:07:20 +0000 (17:07 -0500)]
Make "new" script insert appropriate license on tests

Don't default to SGI copyright, someone else may be
making this test...

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoAdd GPL license plate to SGI's files.
Felix Blyakher [Fri, 5 Jun 2009 20:41:14 +0000 (15:41 -0500)]
Add GPL license plate to SGI's files.

Signed-off-by: Felix Blyakher <felixb@sgi.com>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Felix Blyakher <felixb@sgi.com>
13 years agoupdate aio-stress.c, with copyright information intact
Eric Sandeen [Fri, 5 Jun 2009 19:12:27 +0000 (14:12 -0500)]
update aio-stress.c, with copyright information intact

Pulled from:
http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/io/ltp-aiodio/aio-stress.c
revision 1.8

There are a couple new options, but the main motivator is to
get the license text intact again.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoadd license boilerplate to 205
Dave Chinner [Fri, 5 Jun 2009 09:51:55 +0000 (11:51 +0200)]
add license boilerplate to 205

Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoaio-dio-regress: fix aio-dio-extend-stat on s390
Eric Sandeen [Thu, 4 Jun 2009 21:32:24 +0000 (16:32 -0500)]
aio-dio-regress: fix aio-dio-extend-stat on s390

This patch:

o Changes the BUFSIZE to 4096 so that we can successfully perform direct
  I/O on devices that have a sector size of 4k, such as the virtual disks
  found on the s390 architecture.
o Removes an unused variable.
o Checks the proper field in the ioevent to determine if there was an
  error in the I/O submission.

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Zach Brown <zach.brown@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
13 years agoRevert "aio-dio-regress: fix aio-dio-extend-stat on s390"
Eric Sandeen [Thu, 4 Jun 2009 21:29:39 +0000 (16:29 -0500)]
Revert "aio-dio-regress: fix aio-dio-extend-stat on s390"

This reverts commit 6b26794772a4acbe8df1cc48d7a169011268d97e.

A later version of this patch was submitted, and I committed
the wrong one.  -Eric

13 years agoxfstests: fix syntax error in check
Christoph Hellwig [Thu, 4 Jun 2009 17:12:55 +0000 (19:12 +0200)]
xfstests: fix syntax error in check

Bash 3.2 wants a space before the closing "]" in a test.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
13 years agoCheck for xlog_assign_lsn in xfs headers
Eric Sandeen [Wed, 3 Jun 2009 20:15:15 +0000 (15:15 -0500)]
Check for xlog_assign_lsn in xfs headers

Checking for libxfs.h isn't enough; some debian installs
have libxfs.h but no xlog_assign_lsn, and the loggen build still
fails.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Tested-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoHi,
Jeff Moyer [Wed, 3 Jun 2009 20:13:53 +0000 (15:13 -0500)]
Hi,

So, the xfs test suite does a mount, followed by running the test, then
an unmount after the test exits.  aio-dio-invalidate-failure spawns two
children, and will kill them off before it exits.  The problem is that
it doesn't wait for them to exit before returning, so the xfs test
harness ends up failing the umount as the mount point is still busy.

The fix is to simply wait for each of the children exits before
returning from the parent.

(Eric Sandeen: add one more waitpid to error case)

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
13 years agoaio-dio-regress: fix aio-dio-extend-stat on s390
Jeff Moyer [Wed, 3 Jun 2009 20:11:24 +0000 (15:11 -0500)]
aio-dio-regress: fix aio-dio-extend-stat on s390

Hi,

The following patch queries the sector size of the underlying device so
that we can size the write buffer appropriately.  Without this patch, we
try to do an O_DIRECT write of 1KB to a device that has a sector size of
4KB.  This returns EINVAL, of course.  I also noticed that the test was
not checking the right fields for the return code.  It was checking the
original iocb's nbytes field instead of event->res.  So, I fixed that.

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
13 years agoaio-dio-regress: align I/O buffers to 4k for 4k sector devices
Jeff Moyer [Wed, 3 Jun 2009 20:09:34 +0000 (15:09 -0500)]
aio-dio-regress: align I/O buffers to 4k for 4k sector devices

(and virtual devices as found on s390)

Without this patch, these tests can randomly fail on s390 systems which
use a virtual block device with sector size of 4k.  Testing confirms
that this patch resolves the issue.

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
13 years agoAdd aio-dio-regress tests
Eric Sandeen [Wed, 3 Jun 2009 20:07:02 +0000 (15:07 -0500)]
Add aio-dio-regress tests

Pull in the aio-dio-regress test suite from
http://git.kernel.org/?p=linux/kernel/git/zab/aio-dio-regress.git

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agodon't run 122 if required headers aren't found
Eric Sandeen [Wed, 3 Jun 2009 18:12:20 +0000 (13:12 -0500)]
don't run 122 if required headers aren't found

Now that libxfs etc is optional, 122 (which compiles on the fly)
is failing if those extra headers are missing.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoMake the SCRATCH_DEV optional
Eric Sandeen [Wed, 3 Jun 2009 18:11:35 +0000 (13:11 -0500)]
Make the SCRATCH_DEV optional

Tests will fail gracefully if there is no SCRATCH_DEV defined, so change

the check script to allow it, and update README to reflect this.

This just makes it simpler to set up the tests, at the expense of
coverage.

Long term it might be nice to allow either SCRATCH_DEV xor TEST_DEV
to be missing, but for now this is simple.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoenable generic filesystems to be checked
Eric Sandeen [Tue, 2 Jun 2009 20:42:21 +0000 (22:42 +0200)]
enable generic filesystems to be checked

This includes a fair bit of rearranging to avoid code duplication,
but the goal is to allow 'fsck -n -t $FSTYP $device' to be run on
any generic filesystem.

Any FS for which this doesn't work will need it's own fsck routine.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agolibxfs.h is really only needed for the loggen test;
Eric Sandeen [Tue, 2 Jun 2009 20:36:13 +0000 (15:36 -0500)]
libxfs.h is really only needed for the loggen test;
make it config-time optional.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
13 years agoxfstests: initial reiserfs, gfs2, btrfs support
Eric Sandeen [Fri, 29 May 2009 20:12:28 +0000 (15:12 -0500)]
xfstests: initial reiserfs, gfs2, btrfs support

This patch gets reiserfs, gfs2, and btrfs off the ground.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoFix 206 expected output
Eric Sandeen [Fri, 29 May 2009 18:02:59 +0000 (13:02 -0500)]
Fix 206 expected output

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoTest trim of last small AG for large filesystem resizes
Eric Sandeen [Fri, 29 May 2009 17:48:23 +0000 (12:48 -0500)]
Test trim of last small AG for large filesystem resizes

As reported at
http://article.gmane.org/gmane.comp.file-systems.xfs.general/29187
this trimming may cause an overflow in the new size calculation.

Patch to fix it, and testcase at
http://article.gmane.org/gmane.comp.file-systems.xfs.general/29193

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoxfstests: add GPL boilerplates to my testcases
Eric Sandeen [Thu, 28 May 2009 18:27:36 +0000 (13:27 -0500)]
xfstests: add GPL boilerplates to my testcases

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoReport which tests did get run
Eric Sandeen [Thu, 28 May 2009 16:40:39 +0000 (11:40 -0500)]
Report which tests did get run

fs type mismatches are now likely enough that it may be
nice to report which tests -were- run at the end...

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoSet default extN mount options
Eric Sandeen [Thu, 28 May 2009 16:39:20 +0000 (11:39 -0500)]
Set default extN mount options

ext2/3/4 don't support acls & attrs w/o specific mount
options, so make those the default whenever we mount
these filesystems.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoDetect FS type to test based on TEST_DEV
Eric Sandeen [Wed, 27 May 2009 18:44:57 +0000 (13:44 -0500)]
Detect FS type to test based on TEST_DEV

This helps support generic / non-xfs fileystems.

Rather than defaulting to xfs or expecting a fs
type passed in, just look at what is on TEST_DEV
and use that for FSTYP by default.

We may wish to add a generic way to override this later.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoSet up testdir for generic filesystems
Eric Sandeen [Thu, 28 May 2009 16:38:16 +0000 (11:38 -0500)]
Set up testdir for generic filesystems

Make the default filesystem testdir setup the same as
what xfs did; simply set up the testdir variable.

Update the comment for UDF & NFS, as to why they are
currently doing something different.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years ago069: make scratch mkfs quiet
Eric Sandeen [Thu, 28 May 2009 16:37:56 +0000 (11:37 -0500)]
069: make scratch mkfs quiet

The _scratch_mkfs call in test 069 was not redirecting
stderr to /dev/null; other mkfs's may be more noisy
on stderr.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoSupport "generic" filesystem type
Eric Sandeen [Thu, 28 May 2009 16:37:38 +0000 (11:37 -0500)]
Support "generic" filesystem type

Create a new "generic" _supported_fs type for tests
which are not really filesystem-specific.  "generic"
tests do expect that acl & attr are supported though.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoUse xfs.h rather than libxfs.h
Eric Sandeen [Thu, 28 May 2009 16:36:27 +0000 (11:36 -0500)]
Use xfs.h rather than libxfs.h

Use xfs/xfs.h when possible rather than xfs/libxfs.h,
now that libxfs.h isn't part of a normal xfsprogs-devel
install.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoDrop the xfs-specific MAXNAMELEN in favor of the Posix NAME_MAX
Eric Sandeen [Thu, 28 May 2009 16:35:56 +0000 (11:35 -0500)]
Drop the xfs-specific MAXNAMELEN in favor of the Posix NAME_MAX

This makes it easier to lose libxfs.h later.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
13 years agoxfstests: move GPL boilerplates to fix lsqa.pl
Christoph Hellwig [Thu, 28 May 2009 15:04:15 +0000 (17:04 +0200)]
xfstests: move GPL boilerplates to fix lsqa.pl

It turns out lsqa.pl nees the test number and description first in the
file, so move the GPL boilerplates below it.

Also remove acouple of cases where we have one full copyright line + gpl
boilerplate before the description and another copyright line after
the description.

Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agoxfstests: only run 164 for xfs
Christoph Hellwig [Wed, 27 May 2009 08:12:34 +0000 (10:12 +0200)]
xfstests: only run 164 for xfs

Test 164 uses the xfs_io bmap subcommand which only works for XFS,
so don't offer it for nfs and udf.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
13 years agoxfstests: add GPL boilerplates to my testcases
Christoph Hellwig [Wed, 27 May 2009 08:10:42 +0000 (10:10 +0200)]
xfstests: add GPL boilerplates to my testcases

Signed-off-by: Christoph Hellwig <hch@lst.de>
13 years agoMerge branch 'master' of git://oss.sgi.com/xfs/cmds/xfstests
Christoph Hellwig [Wed, 27 May 2009 07:55:51 +0000 (09:55 +0200)]
Merge branch 'master' of git://oss.sgi.com/xfs/cmds/xfstests

13 years agoAdd GPL license plate to SGI's test files.
Felix Blyakher [Tue, 12 May 2009 18:24:15 +0000 (13:24 -0500)]
Add GPL license plate to SGI's test files.

Signed-off-by: Felix Blyakher <felixb@sgi.com>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Felix Blyakher <felixb@sgi.com>
13 years agofsx: Add check for mmap last-page zero fill
Theodore Ts'o [Wed, 13 May 2009 20:52:42 +0000 (15:52 -0500)]
fsx: Add check for mmap last-page zero fill
Check to make sure the VM system provided 0's beyond the true end of
the file mapping (as required by mmap def in 1996 posix 1003.1)

This check was taken from the FreeBSD version of fsx.c.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agofsx: Replace use of bcmp() with memcmp()
Theodore Ts'o [Wed, 13 May 2009 20:52:23 +0000 (15:52 -0500)]
fsx: Replace use of bcmp() with memcmp()
The bcmp() function comes from BSD 4.3, and was deprecated in
POSIX.1-2001.  It was removed entirely in POSIX.1-2008.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agofsx: Replace use of bzero() with memset()
Theodore Ts'o [Wed, 13 May 2009 18:31:46 +0000 (13:31 -0500)]
fsx: Replace use of bzero() with memset()
The bzero() function comes from BSD 4.3, and was deprecated in
POSIX.1-2001.  It was removed entirely in POSIX.1-2008.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
13 years agofsx: Use %ll instead of %q in printf format statements
Theodore Ts'o [Wed, 13 May 2009 18:31:46 +0000 (13:31 -0500)]
fsx: Use %ll instead of %q in printf format statements
The ISO C approved way of printing long long variables is %ll.  The %q
length modifier was used in BSD 4.4 and Linux libc5, and its use is
discouraged as non-standards compliant.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>