From 08a617f21dca5acd0c0dbd54c5e4ea78de912395 Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Tue, 2 Feb 2021 11:41:58 -0800 Subject: [PATCH] xfs: test a regression in dquot type checking This is a regression test for incorrect ondisk dquot type checking that was introduced in Linux 5.9. The bug is that we can no longer switch a V4 filesystem from having group quotas to having project quotas (or vice versa) without logging corruption errors. That is a valid use case, so add a regression test to ensure this can be done. [Eryu: add _require_check_dmesg and print the 'corruption' dmesg] Signed-off-by: Darrick J. Wong Reviewed-by: Brian Foster Reviewed-by: Chandan Babu R Signed-off-by: Eryu Guan --- tests/xfs/527 | 63 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/527.out | 5 ++++ tests/xfs/group | 1 + 3 files changed, 69 insertions(+) create mode 100755 tests/xfs/527 create mode 100644 tests/xfs/527.out diff --git a/tests/xfs/527 b/tests/xfs/527 new file mode 100755 index 00000000..f612e7ac --- /dev/null +++ b/tests/xfs/527 @@ -0,0 +1,63 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2021 Oracle. All Rights Reserved. +# +# FS QA Test No. 527 +# +# Regression test for incorrect validation of ondisk dquot type flags when +# we're switching between group and project quotas while mounting a V4 +# filesystem. This test doesn't actually force the creation of a V4 fs because +# even V5 filesystems ought to be able to switch between the two without +# triggering corruption errors. +# +# The appropriate XFS patch is: +# xfs: fix incorrect root dquot corruption error when switching group/project +# quota types + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/quota + +# real QA test starts here +_supported_fs xfs +_require_xfs_debug +_require_quota +_require_scratch +_require_check_dmesg + +rm -f $seqres.full + +echo "Format filesystem" | tee -a $seqres.full +_scratch_mkfs > $seqres.full + +echo "Mount with project quota" | tee -a $seqres.full +_qmount_option 'prjquota' +_qmount +_require_prjquota $SCRATCH_DEV + +echo "Mount with group quota" | tee -a $seqres.full +_qmount_option 'grpquota' +_qmount +$here/src/feature -G $SCRATCH_DEV || echo "group quota didn't mount?" + +echo "Check dmesg for corruption" +_dmesg_since_test_start | grep corruption + +# success, all done +status=0 +exit diff --git a/tests/xfs/527.out b/tests/xfs/527.out new file mode 100644 index 00000000..5112f3ce --- /dev/null +++ b/tests/xfs/527.out @@ -0,0 +1,5 @@ +QA output created by 527 +Format filesystem +Mount with project quota +Mount with group quota +Check dmesg for corruption diff --git a/tests/xfs/group b/tests/xfs/group index 9e780365..e861cec9 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -524,3 +524,4 @@ 524 auto quick mkfs 525 auto quick mkfs 526 auto quick mkfs +527 auto quick quota -- 2.30.2