From 0e4dd8b9d2c86b447024d63a18b27eb97f7b1da4 Mon Sep 17 00:00:00 2001 From: Luis Chamberlain Date: Wed, 25 Aug 2021 14:15:20 -0700 Subject: [PATCH] common/rc: fix ignoring of errors on Commit 0c95c8acb ("common: hide permision warning from mkswap for exfat") and commit 08e93fa7c ("generic/554: hide permision warning on exfat") removed a warning by grepping an error out. It however broke use on older versions of bash such as 4.4.23: ./common/rc: line 2554: syntax error near unexpected token `>' ./common/rc: line 2554: ` MKSWAP_PROG "$fname" 2> >(grep -v 'insecure permission' >&2) >> $seqres.full' Fix both instances by using a $(foo) to run the executable. Cc: Pavel Reichl Signed-off-by: Luis Chamberlain Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- common/rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/rc b/common/rc index e0b6d508..46b6b220 100644 --- a/common/rc +++ b/common/rc @@ -2550,14 +2550,14 @@ _format_swapfile() { $CHATTR_PROG +C "$fname" > /dev/null 2>&1 _pwrite_byte 0x61 0 "$sz" "$fname" >> $seqres.full # Ignore permission complaints on filesystems that don't support perms - $MKSWAP_PROG "$fname" 2> >(grep -v 'insecure permission' >&2) >> $seqres.full + $(MKSWAP_PROG "$fname" 2> >(grep -v 'insecure permission' >&2)) >> $seqres.full } _swapon_file() { local fname="$1" # Ignore permission complaints on filesystems that don't support perms - swapon "$fname" 2> >(grep -v "insecure permissions" >&2) + $(swapon "$fname" 2> >(grep -v "insecure permissions" >&2)) } # Check that the filesystem supports swapfiles -- 2.30.2