From 65a20890998e854624eb37a5acb0d113a48ac61e Mon Sep 17 00:00:00 2001 From: Anand Jain Date: Wed, 30 Sep 2020 12:44:16 +0800 Subject: [PATCH] btrfs/064: add a comment to the test case header It appears that the goal of this case was to test balance and replace concurrency. But these two operations aren't meant to run concurrently and the replace failing errors are captured in the seqres.full output. Which are expected errors. To avoid further confusion, this patch adds comments. The reason to keep this test case is at the Link. Link: https://patchwork.kernel.org/patch/11806307/ Reported-by: Josef Bacik Signed-off-by: Anand Jain Reviewed-by: Josef Bacik Signed-off-by: Eryu Guan --- tests/btrfs/064 | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/btrfs/064 b/tests/btrfs/064 index 683a69f1..ce73acf7 100755 --- a/tests/btrfs/064 +++ b/tests/btrfs/064 @@ -4,9 +4,11 @@ # # FSQA Test No. btrfs/064 # -# Run btrfs balance and replace operations simultaneously with fsstress -# running in background. -# +# Run btrfs balance and replace operations simultaneously with fsstress running +# in the background, check with the scrub if all the blocks are ok. +# Balance and replace operations are mutually exclusive operations they can't +# run simultaneously. One of them is expected to fail when the other is running. + seq=`basename $0` seqres=$RESULT_DIR/$seq echo "QA output created by $seq" @@ -62,6 +64,8 @@ run_test() $FSSTRESS_PROG $args >/dev/null 2>&1 & fsstress_pid=$! + # Start both balance and replace in the background. + # Either balance or replace shall run, the other fails. echo -n "Start balance worker: " >>$seqres.full _btrfs_stress_balance $SCRATCH_MNT >/dev/null 2>&1 & balance_pid=$! -- 2.30.2