From 6fc0bd027a74cb2f2d5f70dd6ef61836bc712f71 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Thu, 8 Jul 2021 18:35:18 +0200 Subject: [PATCH] generic/{453,454}: Don't run for FSs restricting names Running generic/{453,454} tests is probably only useful for filesystems that allow unrestricted byte streams for names. Signed-off-by: Pavel Reichl Suggested-by: Darrick J. Wong Reviewed-by: Theodore Ts'o Reviewed-by: Darrick J. Wong Signed-off-by: Eryu Guan --- common/rc | 13 +++++++++++++ tests/generic/453 | 1 + tests/generic/454 | 1 + 3 files changed, 15 insertions(+) diff --git a/common/rc b/common/rc index d4ad421e..d4b1f21f 100644 --- a/common/rc +++ b/common/rc @@ -4599,6 +4599,19 @@ _require_od_endian_flag() _notrun "od does not support endian flag" } +# Skip this test unless the filesystem treats names (directory entries, +# fs labels, and extended attribute names) as raw byte sequences. +_require_names_are_bytes() { + case "$FSTYP" in + ext2|ext3|ext4|f2fs|xfs|btrfs) + # do nothing + ;; + *) + _notrun "$FSTYP does not allow unrestricted byte streams for names" + ;; + esac +} + init_rc ################################################################################ diff --git a/tests/generic/453 b/tests/generic/453 index 55ddcc01..a0fb802e 100755 --- a/tests/generic/453 +++ b/tests/generic/453 @@ -15,6 +15,7 @@ _begin_fstest auto quick dir # Import common functions. _require_scratch +_require_names_are_bytes echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1 diff --git a/tests/generic/454 b/tests/generic/454 index 3aefa9f0..133e2e9d 100755 --- a/tests/generic/454 +++ b/tests/generic/454 @@ -17,6 +17,7 @@ _begin_fstest auto quick attr _require_scratch _require_attrs +_require_names_are_bytes echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1 -- 2.30.2