From 91c239fae9983d04cba4a3589eda4f474dce7f41 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Tue, 27 Apr 2021 10:59:29 +0200 Subject: [PATCH] generic/192: fix instability on exFAT exFAT's access time has 2s granularity and is rounded down. This can cause problems, e.g.: if real access times are: time1=2 and time2=7, then 7 - 2 = 5; but exfat_atime(7) - exfat_atime(2) => 6 - 2 = 4 which is less than expected delay. To fix this, even (delay - 1s) should be considered as a valid result for exFAT. Signed-off-by: Pavel Reichl Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- tests/generic/192 | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/generic/192 b/tests/generic/192 index 900e2cb5..2bc8835f 100755 --- a/tests/generic/192 +++ b/tests/generic/192 @@ -52,8 +52,13 @@ time3=`_access_time $testfile | tee -a $seqres.full` delta1=`expr $time2 - $time1` delta2=`expr $time3 - $time1` +min_tol=0 +if [ "$FSTYP" = "exfat" ]; then + min_tol=1 +fi + # tolerate an atime up to 2s later than the ideal case -_within_tolerance "delta1" $delta1 $delay 0 2 -v +_within_tolerance "delta1" $delta1 $delay $min_tol 2 -v _within_tolerance "delta2" $delta2 $delta1 0 0 -v # success, all done -- 2.30.2