From b536de2a042484bb241cca120ce55c974309513a Mon Sep 17 00:00:00 2001 From: Yang Xu Date: Mon, 23 Dec 2019 18:21:39 +0800 Subject: [PATCH] generic/520: Remove sync in clean_dir When I test this case on xfs, it may fail as below: -------------------------------------------- === link SCRATCH_MNT/A/foo SCRATCH_MNT/bar with fsync SCRATCH_MNT/A === +umount: /mnt/xfstests/scratch: target is busy. + (In some cases useful info about processes that use + the device is found by lsof(8) or fuser(1)) --------------------------------------------- It fails because somethings is still using the fs when we call sync and then try to unmount it. We can simply remove sync as the unmount is supposed to persist the file/directory removals. Signed-off-by: Yang Xu Reviewed-by: Darrick J. Wong Signed-off-by: Eryu Guan --- tests/generic/520 | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/generic/520 b/tests/generic/520 index 167d7077..d4457370 100755 --- a/tests/generic/520 +++ b/tests/generic/520 @@ -58,7 +58,6 @@ clean_dir() { _mount_flakey rm -rf $(find $SCRATCH_MNT/* | grep -v "lost+found") - sync _unmount_flakey } -- 2.25.1