From c50db10dfb240d60b32a877b57d6aeea59afbe81 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Mon, 29 Sep 2014 12:47:02 +1000 Subject: [PATCH] ext4: use mkfs.ext4 -F instead of piping in yes Using "yes | mkfs.ext4 ..." results in the error message results in the test failing, at least for some versions of e2fsprogs: +yes: standard output: Broken pipe +yes: write error It better to use the -F option, which will eliminate the questions. Signed-off-by: Theodore Ts'o Reviewed-by: Eryu Guan Signed-off-by: Dave Chinner --- tests/ext4/003 | 2 +- tests/ext4/306 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ext4/003 b/tests/ext4/003 index fde0e9c1..53875a94 100755 --- a/tests/ext4/003 +++ b/tests/ext4/003 @@ -43,7 +43,7 @@ _require_ext4_bigalloc rm -f $seqres.full -yes | $MKFS_EXT4_PROG -O bigalloc -C 65536 -g 256 $SCRATCH_DEV 512m \ +$MKFS_EXT4_PROG -F -O bigalloc -C 65536 -g 256 $SCRATCH_DEV 512m \ >> $seqres.full 2>&1 _scratch_mount || _fail "couldn't mount fs" diff --git a/tests/ext4/306 b/tests/ext4/306 index caffe0e4..edc02045 100755 --- a/tests/ext4/306 +++ b/tests/ext4/306 @@ -48,7 +48,7 @@ _require_scratch rm -f $seqres.full # Make a small ext4 fs with extents disabled & mount it -yes | $MKFS_EXT4_PROG -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1 +$MKFS_EXT4_PROG -F -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1 _scratch_mount || _fail "couldn't mount fs" # Create a small non-extent-based file -- 2.30.2