From d3942f5a09d22a424295dbc206cf7c1ebe33e585 Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Fri, 20 Aug 2010 14:15:50 -0500 Subject: [PATCH 1/1] xfstests 241: run parallel dbench ext4 was corrupting inode table bitmaps due to a mishmash of atomic & nonatomic bitops. This got broken twice and fixed twice; let's add a test. On a 4-way box this reliably ends up with a corrupted filesystem if we get it wrong (upstream as of 2.6.35 at least is fine again) Signed-off-by: Eric Sandeen Reviewed-by: Dave Chinner --- 240 | 0 241 | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++ common.config | 1 + common.dbench | 2 +- group | 1 + 5 files changed, 63 insertions(+), 1 deletion(-) mode change 100644 => 100755 240 create mode 100755 241 diff --git a/240 b/240 old mode 100644 new mode 100755 diff --git a/241 b/241 new file mode 100755 index 00000000..b5aa7b0e --- /dev/null +++ b/241 @@ -0,0 +1,60 @@ +#! /bin/bash +# FS QA Test No. 241 +# +# Run parallel dbench & check for filesystem corruption +# This corrupted ext4 inode bitmaps due to races at one point +# +# Copyright (c) 2010 Red Hat, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# +# creator +owner=sandeen@sandeen.net + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +_supported_fs generic +_supported_os Linux + +[ "$DBENCH_PROG" = "" ] && _notrun "dbench not found" + +echo "Silence is golden." + +# real QA test starts here +rm -f $seq.full + +rm -rf $TEST_DIR/dbench +mkdir $TEST_DIR/dbench + +dbench -t 30 -D $TEST_DIR/dbench 4 >> $seq.full + +status=$? +exit diff --git a/common.config b/common.config index 926846bf..04bdcf6b 100644 --- a/common.config +++ b/common.config @@ -149,6 +149,7 @@ export XFS_PARALLEL_REPAIR64_PROG="`set_prog_path xfs_prepair64`" export XFSDUMP_PROG="`set_prog_path xfsdump`" export XFSRESTORE_PROG="`set_prog_path xfsrestore`" export XFSINVUTIL_PROG="`set_prog_path xfsinvutil`" +export DBENCH_PROG="`set_prog_path dbench`" # Generate a comparable xfsprogs version number in the form of # major * 10000 + minor * 100 + release diff --git a/common.dbench b/common.dbench index 026acdf1..b59be71e 100755 --- a/common.dbench +++ b/common.dbench @@ -17,7 +17,7 @@ # #check dbench is installed -if [ "`whereis dbench`" == "dbench:"]; then +if [ "`whereis dbench`" == "dbench:" ]; then echo $0 error dbench not installed. exit fi diff --git a/group b/group index afe7614f..2baa5383 100644 --- a/group +++ b/group @@ -354,3 +354,4 @@ deprecated 238 auto quick metadata ioctl 239 auto aio rw 240 auto aio quick rw +241 auto -- 2.30.2